From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Geis <pgwipeout@gmail.com>, Lee Jones <lee.jones@linaro.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mfd: rk808: add reboot support to rk808.c
Date: Mon, 20 Dec 2021 17:53:23 +0300 [thread overview]
Message-ID: <67131f4a-2544-0365-1a92-261983cdd979@gmail.com> (raw)
In-Reply-To: <20211220144654.926112-1-pgwipeout@gmail.com>
20.12.2021 17:46, Peter Geis пишет:
> +static int rk808_restart_notify(struct notifier_block *this, unsigned long mode, void *cmd)
> +{
> + int ret;
> + unsigned int reg, bit;
> + struct rk808 *rk808 = i2c_get_clientdata(rk808_i2c_client);
Such code usually should be written in a form of reverse Xmas tree in
kernel, but no need to respin just because of it. The patch looks good
to me, thank you.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
next prev parent reply other threads:[~2021-12-20 15:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 14:46 Peter Geis
2021-12-20 14:53 ` Dmitry Osipenko [this message]
2021-12-20 16:33 ` Aw: " Frank Wunderlich
2021-12-20 16:36 ` Dmitry Osipenko
2021-12-20 17:07 ` Peter Geis
2021-12-21 8:48 ` Lee Jones
2021-12-21 9:10 ` Frank Wunderlich
2021-12-22 11:09 ` Lee Jones
2021-12-22 11:31 ` Aw: " Frank Wunderlich
2021-12-22 12:53 ` Lee Jones
2021-12-22 13:19 ` Peter Geis
2021-12-20 17:06 Peter Geis
2021-12-21 15:56 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67131f4a-2544-0365-1a92-261983cdd979@gmail.com \
--to=digetx@gmail.com \
--cc=frank-w@public-files.de \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®