From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751190AbeCIKeT (ORCPT ); Fri, 9 Mar 2018 05:34:19 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:39448 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbeCIKeS (ORCPT ); Fri, 9 Mar 2018 05:34:18 -0500 X-Google-Smtp-Source: AG47ELvaKkouGMTe0hITY58VGyr40QugNSeOwmG22WQKU8aVouYyvcZpXPALSesJ3l3ieL9QQln2sw== From: Arvind Yadav To: jdmason@kudzu.us, dave.jiang@intel.com, allenbh@gmail.com Cc: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com Subject: [PATCH] ntb_transport: use put_device() instead of kfree() Date: Fri, 9 Mar 2018 16:03:24 +0530 Message-Id: <6717325ea580df9a0294db6f83fd72a5db3daad9.1520591515.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/ntb/ntb_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 9878c48..8182a3a 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -393,7 +393,7 @@ int ntb_transport_register_client_dev(char *device_name) rc = device_register(dev); if (rc) { - kfree(client_dev); + put_device(dev); goto err; } -- 1.9.1