From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E38A443AA5 for ; Tue, 21 Jul 2026 08:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784621705; cv=none; b=EPRrnkWn+awRlXMHHKH2UQecXVU3xWPvc5ptEki5xBMfAR5JwTKl0aVGCcmTi1hl2OrEfOy1uPjK3iUKvAy2+stHKCrve97fK67nRbGs/v3cELIqLARtYkp6ZZt7SX6I16q+i9kdzBuzWoPBlU0Nbu4moKYt0KzLnGO/cmsWh20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784621705; c=relaxed/simple; bh=Kli47aDfn8sTFT6QxBaC3v33Fczl2UHvcXCdDWn0zlg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RU36y0lQzSEcU02HKQSKFFxu70iKqJtMBwQ5v6Wl1Vj6Lavuuc5PDJLCe49NDtt08KGHTNr24xBYXzpWc2GXafrte58jObr4lOlpxbMaJ3ulVvMzIYVD3xHrrAX+KCtBkOHwj9bmakeTR8to5fAz3mQouaFEQtEmbcSuYr/8kO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LtoaQrgC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RV72f/Xc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LtoaQrgC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RV72f/Xc" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66L6ESK44107138 for ; Tue, 21 Jul 2026 08:14:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BHqWPTGkcUObPXH+9mFnZ5IGzYXysMrpMFOOmXxYMmM=; b=LtoaQrgChVPO3SON nH3yhfABGz6hEUEp5WAyMWPbH5+NX1c5lNiWAeDZ3I5NR2w69jVXqHlB7PVNZ8CB pp8PQMa2j3Gr2W7WrHbwMde9fVCggRJEsbItfl0YakdrswYlnWJYoTwNQ6IHwV1x hOI0YFpGTOXjh5E8wMGOM+7tJbwPsxoQY1+6CyVpo3JngLXWw6P/+rJ10lAHk1cT ID8nyDKZ+esk6FkZ6Uzntrs9fW0fEeABFd/wtBQgiFq5z78oWMwhzTEGV16KTK7w LFc7zrusrMHvNZlogORq9Ow3l2Q154Tre+EbkXbp1R8n3LP/YccZbmrG6RAQj8mw dJtitw== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhvqn9wyv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 08:14:48 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-848474825ffso5765276b3a.0 for ; Tue, 21 Jul 2026 01:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784621687; x=1785226487; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BHqWPTGkcUObPXH+9mFnZ5IGzYXysMrpMFOOmXxYMmM=; b=RV72f/XcMUZJ/qZFL7ToqxmFgsuDLc4JoXjGZugpuUvoZSKBIJ+qcpuJZ2dtaUmPZb MlaPwNms0SdyG5V3VGqOrfWxNB0vlInmRatwSEd9FITS2r25JEOKoiAH6ZkArmBggm4G +YdAteyf8UqMG27Fz3zpN5zaOIl+3Y+i3KWfvozRXZBCw47uW7k/5YleA4TECwh09uVY D1Jv7/uLHBGUShr6/l1UJIAjBqVal0UKQTcRvgAjtjY/6RtcHi2X6F79MUPisL5Ny7Mu kxIwdvU5aPLn0DXXGNFJ7vJkv+IR99vXLEYFpUvAc3cHM8PhFTC18cWWkEuZ3m/fefE0 By9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784621687; x=1785226487; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BHqWPTGkcUObPXH+9mFnZ5IGzYXysMrpMFOOmXxYMmM=; b=p95/uMlWHBAOhYoEDJucjBtjHlUu6+yW/20wq4BfIF6c212WMdoZer9MMf2+k8DLcL o/PIMvPU79POfyLw2U7GTwFK/9WPZYrGySNMbDrFQBwMa6m5kFuz8WWcVCbtzgb7L/ww 2MTMeGF+ToInLtmSy9FCJnUb3d/ZLPo3caBplgJz0GOmM5+KpRTKFKWi0dxNiPHDz9dD O7ZxyFzv1IY1Y7qpoTTaMBpJM8a6HTztzT8SZ0Fs3zYkcFIjM1FeHHY0HOytWDPPMo+u t+rktQWn7n7Onkv5xtRjRk1A7OkI8WXIk12HjbrtByiqWov5sjAOewN6CuU2Rul9AwQI ABpA== X-Forwarded-Encrypted: i=1; AHgh+RqPbGXWzCR/6NXYTWv53oSjR0RJ7cqH0kiz8un30f+OrJdOm6F9KQfQbmPsFgJFs73tH8om8LiNAihBDr4=@vger.kernel.org X-Gm-Message-State: AOJu0YxpZqUA/55VwP9asNzwKu8v/0yvMat+IMFRpn8qp9ifJIIRpBVy EfeSwsyeBGwHbVVpfYML85aQDLWxnGUV1Zn8X2okazlJkOWRqODuBEq4zwzW9kCw/Xn9Nkj0377 fquM5EUC8Z3Hj+ZzjNf7Ewzm3fMVcj4s6eG4yWWbuMjVrBrg9W+7AbeGgJW2avmLg19U= X-Gm-Gg: AR+sD10nkVV3r46GUyz42FAu6nqfpCnr/Scx9MhMuNyBp32cdudhtCQfvvoeac607UX v0RcV7bZygTiIb/zoKloeYNgUZ52Alm9ruuys7EfFlH1dFD/UzQe1U+4+jS6TtRuk1hd8lF9Pw0 98beOyI9yA5VPZIrJM1g4zwyOc6CbdJ8871CEaquXKhWYADtemqhPsOZfXk1S/Vq5gvJjOOO4o7 i4UDUpt9NZ+CW2EibTdo3vhUj5Kng54d4eJ38plRlQ9to1JCM2OZWJTzRZhxyjKJOhGGL5JCcfv 7LFv4BuPZ5y48vLhZ7IgWw+KpwgTci2IEjdod3KC6FVAwZFzGHmAaFb8N8rMj9qOgpVMzKkzmmW HZmj7yJvCPAnYsHk940ooBNW2rtKxyjjvRMvL3oM= X-Received: by 2002:a05:6a00:3a0b:b0:84a:2b96:5986 with SMTP id d2e1a72fcca58-84beb057d97mr21988295b3a.8.1784621687334; Tue, 21 Jul 2026 01:14:47 -0700 (PDT) X-Received: by 2002:a05:6a00:3a0b:b0:84a:2b96:5986 with SMTP id d2e1a72fcca58-84beb057d97mr21988253b3a.8.1784621686894; Tue, 21 Jul 2026 01:14:46 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2adcc78asm7005847b3a.23.2026.07.21.01.14.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 01:14:46 -0700 (PDT) Message-ID: <67179d90-6201-462c-9004-9b4cfd114250@oss.qualcomm.com> Date: Tue, 21 Jul 2026 13:44:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode To: Krzysztof Kozlowski Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla References: <20260720160226.1026440-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260720160226.1026440-2-mohammad.rafi.shaik@oss.qualcomm.com> <20260721-fiery-sheep-of-piety-4fd04b@quoll> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <20260721-fiery-sheep-of-piety-4fd04b@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDA4NSBTYWx0ZWRfXyGliQhsIgAr/ /sczTkSXEANm1Xu040JdGc6i5M6hBLeafXtjGLmn3yJ/hx8GJ38za6U3Tn8Uc4XlTeB847ekX7T NygxP8HIS62CdXOM0rC9a12grWW3bpocSq+OUkPaznKoCEYgJWw15nnxu9JWynZIrVcfHpOsEVE NYe2camEEbkSr7onYAQJ2bN+Nke1EkiiG+HdDxf6TzshRfvrrIZ/VEbyaTl+hJRT/B2E7V6w4ZF lXyqKwW2B2uOKwgXyEojOPY6QtDaPIG/DNg/RBa37xoVetI5rhd4npEtkKvpcriKNdi5Q3lvsg9 HcwMpG5zgehQGrZBm8HnQ4xF/uSZROe9hb86hWoB/h90wxCVgD1dlPQgQcVFkmmDdaY18Ot+pWz DJf2CEVti6D/IE96Gh2eNuHsPW4iJNMlgz291mGtuynxbQxqnyElUaQrtkko52runD17WZC52Y9 6hu69chj1Z7CDUiHeWQ== X-Proofpoint-ORIG-GUID: C1bk0Woi9xD5wWi7G_DevwrNf3TsF4ns X-Proofpoint-GUID: C1bk0Woi9xD5wWi7G_DevwrNf3TsF4ns X-Authority-Analysis: v=2.4 cv=M5F97Sws c=1 sm=1 tr=0 ts=6a5f2a78 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=VwQbUJbxAAAA:8 a=pWr4hPsiy6qYYviyjrMA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDA4NSBTYWx0ZWRfX/ZgiAKa7+a7G v1Y58DKFY4qRs50hv2qO2UCpUv17QvsABh/4Y9ztzzVffNx/ZpTd/SbLA5nrTyNK0zRaD0wmy07 5Ds+6UpKd4SDZC15siROc6F1DKh/TNY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210085 On 7/21/2026 12:18 PM, Krzysztof Kozlowski wrote: > On Mon, Jul 20, 2026 at 09:32:24PM +0530, Mohammad Rafi Shaik wrote: >> +# Digital Audio Interfaces >> +patternProperties: >> + '^dai@[0-9a-f]+$': >> + type: object >> + description: >> + Q6DSP Digital Audio Interfaces. >> + >> + properties: >> + reg: >> + maxItems: 1 >> + description: >> + Digital Audio Interface ID >> + >> + clocks: >> + minItems: 1 >> + items: >> + - description: MI2S bit clock >> + - description: MI2S external bit clock >> + - description: MI2S master clock >> + >> + clock-names: >> + minItems: 1 >> + items: >> + - enum: [bclk, eclk, mclk] >> + - const: mclk > > This does not match your clocks. > will fix this. clocks descriptions are misleading because they imply an ordered bclk + eclk configuration. I'll drop those descriptions. will keep only clocks: minItems: 1 maxItems: 2 > I gave you exact syntax to use, then in previous version you used > something else. So I reminded. Again you used something else. > > If you decide not to use it, sure, your right but YOU CANNOT come with > clearly invalid code as a substitute. > > NAK Suggested change: https://lore.kernel.org/all/2b4448d0-81f8-410f-b849-0d957a2d2a17@kernel.org/#t minItems: 1 items: - enum: [ bclk, eclk ] - const: eclk - const: mclk I tested the suggested schema, but it results in DT binding check failures. DT binding check errors with the suggested change 1. Only mclk enabled bedais: dai@10:clock-names:0: 'mclk' is not one of ['bclk', 'eclk'] 2. bclk and mclk enabled bedais:dai@10:clock-names:1: 'eclk' was expected With the current version of this patch, I do not see any DT binding check issues. I tested all supported clock combinations, and dt_binding_check passes successfully in each case. Thanks & Regards, Rafi. > > Best regards, > Krzysztof >