From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF4D5392C27 for ; Mon, 4 May 2026 10:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889342; cv=none; b=tEOmY7eDzTv4+F1z3VMowVNPwK3idMHslgEjBbi0/wXv5x67pJjWkIoD+4wvyoK6zpWe2I+2IB0w1KU1igobRRcyJcqNW+nmxzZgOP7JM7koh4cu9hvl3Yxh8YpysgrGKtV2dgmqcJx39p7cM+GlpjgxpBhfKIjHjInMzu9NFY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889342; c=relaxed/simple; bh=ecvD7cXCIG9VrEOOchfKBfniIVf6VtECCyv5SmPD1kI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KZ+HsOiQu61ZFiGZ7LNgfu4AWUwdzOLCj2nr+OdmoDwW50RgQPHjgUtH9E6oQm7OCGHagLOBbDy9LLt2ircZ3lwkxqqqGCUbsJrEeunXnKtVlJRijIJ8dx3MhRBi6+r/DGdreCbhCaZW1GOd+L8/1t/j0QS2rWp4RnZgE47vBbI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aWni/hly; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aWni/hly" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-393800586aeso14211311fa.1 for ; Mon, 04 May 2026 03:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777889334; x=1778494134; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rmNwLKC44+y7Cqt7OcmRZ9UY7ReRqF1/k1kRQnz8QNY=; b=aWni/hlyQIP+QilTm5Xe1LiBFc7ExKzkwyvFprVTmEXAQYpoYD38Zrfi5q+nwrBMkJ LQlsDCK340GvJWNeN+HtIEo3D0mI404aYQMjAh+Qse2+F2TJ9mIdnoqIueu4qXPvrY5h 18YIqDhfiCyjNn3Fq2jnu3tnDvFS4wKevMFIudj5owUxkNT12h1SI3BqI1Zb1gY+vYNf EE0hiEKADwCqS3AHgki8mVDUhbGB85GzEaFbkhoSYNLlJzdngnSwIoBINyEStUw0AUIy 5GFB8jN2IWqPeNrczs4+zi61qB67J8fOW63BEB5xXHO21Wn6QjZRWQ1i11aGZZ6+5owV 2UnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777889334; x=1778494134; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rmNwLKC44+y7Cqt7OcmRZ9UY7ReRqF1/k1kRQnz8QNY=; b=TtcBjgPdCL2orB08wG9PDkU2+qu8ePh1M9hwdZ5EyyQzPf40lvGHfakRBRgxaM5DSp KSk5EjJO29XzxE/BuYqNbgNVv1S0i93RvTn7eUMpAR70V6VvOy34QS+7kNMie4NAMYof +752HCcpv/CAfeflJLatLVUGM9Gt3mVkRb4qtsyoi5D8OXyZFs6zP+8cUDZMza0pI5l/ zJMfH9Rh94KTKbrozttTVWuCyWNhepezRkUUvnbwcgPxqktEOA7xrDEjnx1o8+xPb2VE 9M0vZvkqJTnI8gVIJ0scK/naObFTCwuEWl+1I9E7EaqeQYieHpDoC0+cwTsBs/dtsWYI laCQ== X-Gm-Message-State: AOJu0Yw5RJZEtXO2A8mL6MR067N36QnXccc3c3AFTcbcpdp4FNEH1nKX 1WzNo2zT93RyfQ9WRoWt6kWuHUgQe0HGprT5e/lxfGCw+OXSMe1W/OA8o19EAv/CF+Ok4UdGFRc = X-Gm-Gg: AeBDies0l1+ieHzeHvOnmdfeYNynGRNzg1HATYzlR+Ndc9dLLCaMlbxHzupNLxxCrG+ ziT/QbiO8sfwNBGa1bFvES+hzcYJfrQbVa0TmE+iWDIn4zYNjHWadr+sBKSOQnD+9bnvSTn9MEy WGH+pdaHsRRsrQexbiFDVrlN9s1JzGzSNwHalS1MsftaiYwyKtoG1I3bIBofQbIIm+215PyCOax mNJPlTN8SBub3RHbKuGOv3t9JWqyAuk0oGng1Pna/2Wda7nCcyhoQKrgFf/0tuGHL0pbAXbweui 63oCdqpT2M49oqcblO0HkOYWQg1Cdd11dYoiKJr8Sm7LLm0SzYheU7GUAMnIYag3xzf6LzJx3+F nRz3PydS4n3myepLrMxT07biW/GLecQtTA6zFG/SxklGYpYRCbJ5fORh0/jdxhKGG6nDWvYejHR DqVDr5jivtissJm0kyv+a3E5b6sC1cM0XVMz6oTAKmEt0f+Q8l1UQP/WHyImyUz2Q3HFOA5Jw= X-Received: by 2002:a05:6512:2208:b0:5a2:c962:59f1 with SMTP id 2adb3069b0e04-5a86215f89emr2358405e87.16.1777889334019; Mon, 04 May 2026 03:08:54 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a86645ae7csm1979099e87.79.2026.05.04.03.08.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 03:08:53 -0700 (PDT) From: Vastargazing To: linux-kernel@vger.kernel.org Cc: Vastargazing , stable@vger.kernel.org, Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , David Woodhouse , Lennert Buytenhek , linux-mtd@lists.infradead.org Subject: [PATCH 3/5] mtd: maps: physmap: fix reference leak on failed device registration Date: Mon, 4 May 2026 13:08:45 +0300 Message-ID: <6717e0b2a6244ee4e691dba03eb8c790c202e89e.1777889235.git.vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When platform_device_register() fails in physmap_init(), the embedded struct device has already been initialized by device_initialize() inside platform_device_register(). The error path unregisters the driver but returns without dropping the device reference: physmap_init() -> platform_device_register(&physmap_flash) -> device_initialize(&physmap_flash.dev) /* kref = 1 */ -> platform_device_add(&physmap_flash) /* fails */ <- platform_driver_unregister() called, but kref still 1 Per platform_device_register() kernel-doc: NOTE: _Never_ directly free @pdev after calling this function, even if it returned an error! Always use platform_device_put() to give up the reference initialised in this function instead. Fix this by calling platform_device_put() before unregistering the driver. Fixes: 73566edf9b91 ("[MTD] Convert physmap to platform driver") Cc: stable@vger.kernel.org Assisted-by: GitHub Copilot (Claude Sonnet 4.5) Signed-off-by: Vastargazing --- drivers/mtd/maps/physmap-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/maps/physmap-core.c b/drivers/mtd/maps/physmap-core.c index dcda7685fc99..45d79ca622c1 100644 --- a/drivers/mtd/maps/physmap-core.c +++ b/drivers/mtd/maps/physmap-core.c @@ -654,8 +654,10 @@ static int __init physmap_init(void) #ifdef CONFIG_MTD_PHYSMAP_COMPAT if (err == 0) { err = platform_device_register(&physmap_flash); - if (err) + if (err) { + platform_device_put(&physmap_flash); platform_driver_unregister(&physmap_flash_driver); + } } #endif -- 2.51.0