From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF5003ACA5F for ; Mon, 30 Mar 2026 09:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774862698; cv=none; b=UF9CE1QpWHfn8LNLfIAsc43OpNvNRlbDqAvjHGaTGCrxNK4tFQMn7jFZ09MgJC9l/GujclVMdMD3Jl5jRPJFaLtbtzbsvmAMCgEdWFNv0z1b3xlPuZb07PcgVBRTzK4Zs/CeIpQhtyS6uJYmWbDrSdrf+IDI/gc9U7Bha//R8Ys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774862698; c=relaxed/simple; bh=8cg+3kQLXXiTkfV3cU9A/x5nfqzAT5cAj6P84d3VV1U=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=VfziOmL4poyQd+3/Q5upU4kPuPvS+291rvP6ZCCnSXQ+kCpQh3iMIUcH4rFrOQWZaHYxloP3l6Hd8RMNah6+ZbBuKp7z7OwrkzJ7wu1u0leQHywy+T3LKUlortr6a2eDP7fJoa0vA1d++dfLUBxbaGf/OVuZsBbNK9qYGDW7iQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k6iLvl9L; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k6iLvl9L" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2c156c4a9efso3988394eec.1 for ; Mon, 30 Mar 2026 02:24:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774862696; x=1775467496; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=GpOZsFA9YDn0yRQpDJcAiVM07QWQzHxZa1ILteDRZbc=; b=k6iLvl9LPz2/w133TEPEysXJG3Aivszk2lZUaY2EAq03nLl3CGtcPNZPbWGrDkaiEJ 6vvX4MMCjI0iVIipmBnvrrVqJwkB7XOgC8TaSpzOqqErMAtdb59Dy7KqnmW/RHRWJRU8 ShuH5dk5k9pYjQVGQt5aU3VE4TNgzB+DTWs26i3c5SIxZvmGl6PXYQDpNSjXHcq4pgu4 vTMkUVbWY5slW5aJKI2C+Lw0T74JrOmdQo24aVFSRiwUpjmYZUgCwKq1PSNta621V2ak 2OrIkDDzufPs/tGdFpx2sORlj9xhG/jjXi2wUVRTGeAmyUH8LA7qHlE+Bs1EMDIRfy/N JYzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774862696; x=1775467496; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GpOZsFA9YDn0yRQpDJcAiVM07QWQzHxZa1ILteDRZbc=; b=l2PthldOAMPmQWmHlAxC2QlFqGJdw50j4rKdEr9ymdgUHsKWioZqALKFAcXiBOzM6B mIjCXI4lOGlKXBVHT6L+fDFEKfXceejIFHjVYBpg/ku4Rt3bf0iO6ATuZA4Y29zniID7 sSkR4Jyw+5f7FyFp/SLutyBle53+fBm5KnAvdHNnky4oOtdFCc75dSnO4+2RMiydnCWz kyyWbhmz7oKMoW6XxD7E6mJh2tDMw4P7d1ae8TdJ2/+/WyVWWCi5DgwDS/rlE/HlESvo tSXD0D3OhcZQ0n6MvsaDSoO+NntgQ/2me2vNkcsku25wxjadhnUCRd4ycs7A/MUwc5VF 653w== X-Forwarded-Encrypted: i=1; AJvYcCUfOULDaIxyQkBUYMzIb262+5uL2Kgir5JwyWAPefOtdtfECdzoEM9J+N04QlwFOgj/kh7xjzLn/7NgxB0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6poP7pr1Xc1to9hm1Ug7UTxtxoMy9zipOf6U8+qKQMa9PU9su kv2AwPCyEWI2HLR7NvhHeuplVaFTvcUcWJUmlMRjkXffE9adUJlLRJKy X-Gm-Gg: ATEYQzxeOTPr3r19gvIvGBmRbo+sOVtXW+d2CUI9v9s5QU6NvD3IPYhAbzi8F6VFdLy GTbYairlecxbVKD4UD1d4H1Kxf+MpI8jGFmlu4/QNQqY94Ursnw08wQJikO+91n4GVZGKnIujVT ND5JgaUAqrV5V+D7TZqYVJZlhV5tGPPcOHbZFVRf69mAWc5GYihouXxjAkvUehmc2/0QHKiSjOs V6c953uu0tFMZEFTXaivdm50m4dvY2XF0escVL+ik57O/ny0zpNaDeTFmnM54CyGWcoFPRe1Zud 9eYV2wlQ4DgfXOfEIXvMZhs/VeDsLYJg4ZCVSPR79YOIw50MTBX6K7iapjllDc7zvVHOlyV47K+ n3JjGTSGgO9KWscG6uBZe30OZg68eNRh2pai0GsBU10tHYMqP33CqIRUNfN+DwoQ0YM1g+DKmxj Sf+g2q63+28p4WGIg5SxKVGd8F+dyMN19MUUjTTveKLWQ= X-Received: by 2002:a05:7301:da0b:b0:2c3:b172:83c2 with SMTP id 5a478bee46e88-2c3b1728c62mr3307373eec.20.1774862696044; Mon, 30 Mar 2026 02:24:56 -0700 (PDT) Received: from ehlo.thunderbird.net ([2601:647:5e00:4acd:e6a1:71c0:d327:1ab4]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2c3c68b2ff2sm6740116eec.18.2026.03.30.02.24.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 02:24:55 -0700 (PDT) Date: Mon, 30 Mar 2026 02:24:52 -0700 From: Dmitry Torokhov To: Bartosz Golaszewski CC: =?ISO-8859-1?Q?Nuno_S=E1?= , Andy Shevchenko , Linus Walleij , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Jonathan Cameron , Jonathan Cameron , David Lechner Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v4_4/4=5D_iio=3A_adc=3A_ti-ads7950=3A_co?= =?US-ASCII?Q?mplete_conversion_to_using_managed_resources?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20260329-ti-ads7950-facelift-v4-0-c568c508c49a@gmail.com> <20260329-ti-ads7950-facelift-v4-4-c568c508c49a@gmail.com> Message-ID: <671889B9-1D36-4F00-B044-0173A13F7403@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On March 30, 2026 2:20:33 AM PDT, Bartosz Golaszewski w= rote: >On Mon, 30 Mar 2026 00:47:09 +0200, Dmitry Torokhov > said: >> All resources that the driver needs have managed API now=2E Switch to >> using them to make code clearer and drop ti_ads7950_remove()=2E >> >> Reviewed-by: David Lechner >> Signed-off-by: Dmitry Torokhov >> --- >> - > >[snip] > >> -static void ti_ads7950_remove(struct spi_device *spi) >> -{ >> - struct iio_dev *indio_dev =3D spi_get_drvdata(spi); >> - struct ti_ads7950_state *st =3D iio_priv(indio_dev); >> - >> - gpiochip_remove(&st->chip); >> - iio_device_unregister(indio_dev); >> - iio_triggered_buffer_cleanup(indio_dev); >> - mutex_destroy(&st->slock); > >That's a functional change, there's no corresponding conversion to using >devm_mutex_init()=2E devm_mutex_init() makes absolutely no sense, as well as having mutex_destr= oy() in remove()=2E The memory containing the mutex will be released right = after=2E=20 --=20 Dmitry