From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120BBECDFB1 for ; Tue, 17 Jul 2018 12:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE12420C09 for ; Tue, 17 Jul 2018 12:25:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE12420C09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731533AbeGQM5w (ORCPT ); Tue, 17 Jul 2018 08:57:52 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:45712 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730246AbeGQM5w (ORCPT ); Tue, 17 Jul 2018 08:57:52 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C83B115AD; Tue, 17 Jul 2018 05:25:27 -0700 (PDT) Received: from [10.1.207.53] (e112298-lin.cambridge.arm.com [10.1.207.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B9A333F5A0; Tue, 17 Jul 2018 05:25:26 -0700 (PDT) Subject: Re: [RFC PATCH 1/4] genirq: Provide basic NMI management for interrupt lines To: Peter Zijlstra Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, ricardo.neri-calderon@linux.intel.com, marc.zyngier@arm.com, mingo@kernel.org References: <1531152846-19374-1-git-send-email-julien.thierry@arm.com> <1531152846-19374-2-git-send-email-julien.thierry@arm.com> <20180717112842.GT2476@hirez.programming.kicks-ass.net> From: Julien Thierry Message-ID: <671cb2a4-9ffb-ceef-a078-3162387962a5@arm.com> Date: Tue, 17 Jul 2018 13:25:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180717112842.GT2476@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/07/18 12:28, Peter Zijlstra wrote: > On Tue, Jul 17, 2018 at 12:13:44PM +0100, Julien Thierry wrote: > >> I'm a bit unsure about this one. In practice NMI handlers shouldn't take >> forever nor block the system for too long. > > On x86 at least, kgdb can be in NMI context for extended periods. Not > saying that's a good thing, but on occasion we get reports on stuff > coming apart because of that. > > (most times we tell people to not do that then) > Thanks for the explanation. I'll remove the function to avoid issues related to those scenario to arise. Thanks, -- Julien Thierry