From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1306F13D250; Tue, 26 Mar 2024 19:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711481580; cv=none; b=fD9SaW79AlIYYK8ulJsYczgMyWwMXqqIKe0udqtCPors8pwVT/9+6JHZoLANK4CIOk+BFqdzPrk65clEQPyG9P1xypcDTgRwnGQq7ctE+7g/3JCeRrsgMQq/WOp0yz2wwUvqvFgD3Wew8t1VOLyc4WZWoGsYiQyKREJ56DW38m8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711481580; c=relaxed/simple; bh=TT/c+vCfFCoW0sJf8wLgVLVqVAyrV2Dxi5ZqNL/+3dE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=C85ig0MpqAwaHT+zWFod81XPgoP3rg+drlaw3TWmgZIwnwQ9MMdUyFtZrx6njV9Z658kL8aIqAqMT8qkGzXt9F4fBvpGXxCJIADyozKscnG43vA929xtnNl/90JL3/lNLb7O682ywzgbmJ0VxlPPj6O2C6d9R3fQPtXIagq4nhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=nr4Gyn5a; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="nr4Gyn5a" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 42QIgwco027984; Tue, 26 Mar 2024 19:32:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=Gvl/cErnJ0hcWPz7bh+uiNg8+CKOhxG44k87KtPunH0=; b=nr 4Gyn5aS6vsLZdpONgV1Q/2VMOeDPW3noCeZFXJTXePf26K3wuMD9T0Sq2W2UjWlC A0bqoPQaTVEXkJtHIY+oSztw7S3NSa2cUuTd+dAKJyYHqv3X2ykZpdzBNdzJwJR4 zwhtPGHsk4Addr5ru8FLzCFO3Ae/vwdwROEC/Ytt4vAbEbrYOcF59852ZVQnqCaM 5L058iuYn271RkYmngoscPjcpOjW4ZpOELZPTu3GwZfoXT24R5fmNaiZluSfoU2O gs2P1V5IJl34PSb0BJHviA99pXAHSKMTENS8X5ElED81iv+EbDfB7XvrhkjK3nAQ m6GTJwbqcwywRA3KtZow== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3x3q0n2jaj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 19:32:45 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 42QJWiRU015728 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Mar 2024 19:32:44 GMT Received: from [10.71.109.81] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 26 Mar 2024 12:32:41 -0700 Message-ID: <671d2662-df4e-4350-0084-476eb1671cc1@quicinc.com> Date: Tue, 26 Mar 2024 12:32:40 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable 'out' set but not used Content-Language: en-US To: Dmitry Baryshkov CC: Miguel Ojeda , Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , linux-arm-msm , dri-devel , , linux-kernel References: <85204b78-7b24-61cd-4bae-3e7abc6e4fd3@quicinc.com> From: Abhinav Kumar In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 45Zt0ye1_N9N-CvHZY087ABXmToD95_R X-Proofpoint-ORIG-GUID: 45Zt0ye1_N9N-CvHZY087ABXmToD95_R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-26_08,2024-03-21_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2403210001 definitions=main-2403260140 On 3/26/2024 12:10 PM, Dmitry Baryshkov wrote: > On Tue, 26 Mar 2024 at 20:31, Abhinav Kumar wrote: >> >> >> >> On 3/26/2024 11:19 AM, Dmitry Baryshkov wrote: >>> On Tue, 26 Mar 2024 at 20:05, Miguel Ojeda >>> wrote: >>>> >>>> Hi, >>>> >>>> In today's next, I got: >>>> >>>> drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: error: variable >>>> 'out' set but not used [-Werror,-Wunused-but-set-variable] >>>> >>>> `out` seems to be there since commit 64d6255650d4 ("drm/msm: More >>>> fully implement devcoredump for a7xx"). >>>> >>>> Untested diff below assuming `dumper->iova` is constant -- if you want >>>> a formal patch, please let me know. >>> >>> Please send a proper patch that we can pick up. >>> >> >> This should be fixed with https://patchwork.freedesktop.org/patch/581853/. > > Is that a correct fix? If you check other usage locations for > CRASHDUMP_READ, you'll see that `out` is the last parameter and it is > being incremented. > Right but in this function out is not the last parameter of CRASHDUMP_READ. Maybe you or Rob can correct me but I thought the fix looked sane although noone commented on that patch. >> >> We can pickup that one with a Fixes tag applied. >> >>>> >>>> Cheers, >>>> Miguel >>>> >>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c >>>> b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c >>>> index 1f5245fc2cdc..a847a0f7a73c 100644 >>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c >>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c >>>> @@ -852,7 +852,7 @@ static void a6xx_get_shader_block(struct msm_gpu *gpu, >>>> (block->type << 8) | i); >>>> >>>> in += CRASHDUMP_READ(in, REG_A6XX_HLSQ_DBG_AHB_READ_APERTURE, >>>> - block->size, dumper->iova + A6XX_CD_DATA_OFFSET); >>>> + block->size, out); >>>> >>>> out += block->size * sizeof(u32); >>>> } >>> >>> >>> > > >