From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753490AbdHKNeG (ORCPT ); Fri, 11 Aug 2017 09:34:06 -0400 Received: from mout.web.de ([212.227.15.14]:54648 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753173AbdHKNeD (ORCPT ); Fri, 11 Aug 2017 09:34:03 -0400 To: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, Fabio Estevam , Jaroslav Kysela , Liam Girdwood , Mark Brown , Nicolin Chen , Takashi Iwai , Timur Tabi , Xiubo Li From: SF Markus Elfring Subject: [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions Cc: LKML , kernel-janitors@vger.kernel.org Message-ID: <671f4a88-bee9-85b4-ea9b-68abcdb40443@users.sourceforge.net> Date: Fri, 11 Aug 2017 15:32:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:pmBhkfiOQEinGiDn2rNP3wLkHGhh/MPky31ob4jbu5QUAUviW4O SviQu9ZkOVDWMAXEsN/jGJ2AD7rUvcnPfl7yrYQFOEO5jfKVB6tyBOG8fcn+5jG7SiWwJNo bAOUyxl0xIVSTzmd11b0fOoKdL5snBue8d53gpf6EE7fcrS7c4mGEW6yScA/kjxDjX2uK+J 1iuGa01q2K2tc4sooiy2A== X-UI-Out-Filterresults: notjunk:1;V01:K0:SvKzdEUG1sA=:ko1MHDlCSrgYBQdTLGEZr5 W4xB7P3G3sYivQqtkZu26kpk23x15FIzKNWbmz10Z0Tozc/UEJa9og1qnr40ofl9jTxx49/Vk 4UVA7P66uiCUZ5uLRN9PpGdWqLmfng88CsPvDXaahZ2wh9NGnlLNQT8rL9DOpItI10i/20XJj UeB4AjSTtQ8szi8+DBA6+d0NuVOMIcBRoZDZgB+EbuUTcB/FVcT5BiXmdhDKNH8+Sa4uY+Ezm n0EX3hK65W0uVTd7OUA2OAQ1B0S9xD6Q77YVf5PFAdGzxISBENSALqYY7RRQlkHDN9H/NKKom JaPTEpNfOLNrg1hqBrdS5XtunLgpC/uw1LCEMCZF4O0pOg3UL1LZU/uYc+pcW4T7htWuQV4N1 ovhGxAK9jmsZlMiat7hPsODNkqlVBCcZSRoQpMB1Xc/9E07AQlMQJrIhcEOqSB6p2CSUj/0Mn Gpx5HxsqFZlLjyQyd73YHUTNp4P6vx6jNY7MMQ7RTyeeP6l7DgGn4sBkJb/np09tYN1DFQze+ oWMFWZDBnsueyrv2Ntd0IRKyrT5E2jqErMzyXxFstFRC2gbvBEKlDo0imZ3OKeSxHgBNwoOF3 WaksaOOTUpFDenc0fJGBmKauhyS0ZFPFP5LTyyyXlIPhS+n2rm+i02EQ6IZ6iHfx7hiziSJqy Vbhj8rX3+3/nTWQzUMgK2fWG2gQwbZZ5yXYaawCVONBqSyUtyv/zEpeyuCnfSIbsnCEpGfyp6 4SUFvKSL4ut2O9qMrRwRmFnVFhqdUkuE8zCAGjuG4ufy1Fxq75WP3FtwjCyOgSmuNzyl/Y1Qq Y9OwtQA6DFTJ1lYG5wFWZh4eNGvvkyGfSoyIiICL1xeEFZMbqo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>From 885ccd6c63291dcd4854a0cbaab5188cdc3db805 Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Fri, 11 Aug 2017 15:10:43 +0200 Subject: [PATCH] ASoC: Freescale: Delete an error message for a failed memory allocation in three functions Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- sound/soc/fsl/fsl_asrc_dma.c | 4 +--- sound/soc/fsl/fsl_dma.c | 1 - sound/soc/fsl/fsl_ssi.c | 4 +--- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc_dma.c b/sound/soc/fsl/fsl_asrc_dma.c index 282d841840b1..2baf19608bd0 100644 --- a/sound/soc/fsl/fsl_asrc_dma.c +++ b/sound/soc/fsl/fsl_asrc_dma.c @@ -282,7 +282,5 @@ static int fsl_asrc_dma_startup(struct snd_pcm_substream *substream) - if (!pair) { - dev_err(dev, "failed to allocate pair\n"); + if (!pair) return -ENOMEM; - } pair->asrc_priv = asrc_priv; diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c index ccadefceeff2..0ce172f86d6c 100644 --- a/sound/soc/fsl/fsl_dma.c +++ b/sound/soc/fsl/fsl_dma.c @@ -907,5 +907,4 @@ static int fsl_soc_dma_probe(struct platform_device *pdev) if (!dma) { - dev_err(&pdev->dev, "could not allocate dma object\n"); of_node_put(ssi_np); return -ENOMEM; } diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 173cb8496641..64598d1183f8 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c @@ -1435,7 +1435,5 @@ static int fsl_ssi_probe(struct platform_device *pdev) - if (!ssi_private) { - dev_err(&pdev->dev, "could not allocate DAI object\n"); + if (!ssi_private) return -ENOMEM; - } ssi_private->soc = of_id->data; ssi_private->dev = &pdev->dev; -- 2.14.0