From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B44FC6F31E for ; Tue, 29 Oct 2024 01:31:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730165467; cv=none; b=OoIIid8hMxAipr8N/SQkI89SOf7EjbcJM/1Q4zsYmO7JXpZaxn/4eyXIn8ydpGC1+pHk3xXemlJ+UWAMQeGBV9MDB9sYfZvIwqSwfbToCc1zZgagXjqlGMHKMOFCpRZNxF40NbNXzy0NkfzRNjDBHl465cHBW3cc6Yt8n6h9h7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730165467; c=relaxed/simple; bh=G7+LKAiEZjojCMWiMWzS8DEHT6uIiawiMYrhFh77Ybk=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To:Cc: Content-Type; b=iUol+6DN8fvcMl9v/MPUWzI+pABt2AGnzGPZxGMZeUYqmewTVXig4joGZtIyJQom/n+W562V1EWVGFw/gxbqJC06Nh+rs3hBAnAFZ06KlpGbgBW985ZUFYnBlD4bA8iKE3ieKQJjU3l9Hi6y0mwJ725S7Vn0Rsj8kEtBlMuJQyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-io1-f70.google.com with SMTP id ca18e2360f4ac-83acaa1f819so422363639f.3 for ; Mon, 28 Oct 2024 18:31:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730165464; x=1730770264; h=cc:to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=blpgd8YjvB2diS1BbB0mEocyLq4LjgleFkEtSAHxhZs=; b=AfwgdxSFa1nNn3eeYZJEyfiFar2jH3i/Jt2tI9TOtmGB40dQ1eB86mmnmkh+/ZnEKk ALmnmGh+jCAe9q3Qb6lj+22H5YbcQQj+6Ucqg2pv+s/IetkXfEUsQUV7i2qOy5JsHWRY sJN6ZXCA9m/N8TEJ5KuHbSY4RGCBm7AQcJXh4ZfmtqGKtXdwBlHShkHiq5elrMqSdIAr yN9yRnH3Ndg3cRuO15B6zt5LPSLSN8CSiy95dgLM9+O2spm4A5t2FOLuEpsxCM7UlEaE OmYErfhczPvDlhc0VFChI8nlxRvPc0zrv/7DzKFJW60g/m6QheCN+/i5FPjueLQsrqEn sttQ== X-Forwarded-Encrypted: i=1; AJvYcCVeBgeFAQxdsJuQyAFVcNFmL+uONurEePY8ctCQMDFmRE+aSqct1qMPFsrSUrjpfHR8Boob0gBWJWSBiPk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyd8vycl7WoadwfPcEeoYhoYXmyO/T9fn2YLpXGd7yfS9B4ORKF hQHNENVpFvnZXL5T0dytCdn6i0p4kWMyh200dqbFDH+YpO4FaCa9iRXwUtsxm9Y/C8mKdYD0UEz wcI2VfTCrjiSNkx+9INB12e2PoYPqf/wS1vJ4husAPKjeuSNPICxuBrM= X-Google-Smtp-Source: AGHT+IEWgvAzO+814Xt+kbwutmBtI9bt/2Exl3iiknlXOhx36vo/4zUQdSJPWCLGsAmlQg+MY2DTas2Y1U+fg86cJhRYJQowlAwD Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6e02:12e8:b0:3a4:ec57:d7c1 with SMTP id e9e14a558f8ab-3a4ed2f7184mr91863315ab.17.1730165463808; Mon, 28 Oct 2024 18:31:03 -0700 (PDT) Date: Mon, 28 Oct 2024 18:31:03 -0700 In-Reply-To: <110cda95-ae46-406a-9de5-50aca68d6ebb@kernel.org> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <67203ad7.050a0220.11b624.04ba.GAE@google.com> Subject: Re: [f2fs-dev] [syzbot] [f2fs?] possible deadlock in f2fs_record_stop_reason From: syzbot To: chao@kernel.org Cc: chao@kernel.org, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" > #syz dup: "possible deadlock in f2fs_evict_inode" can't find the dup bug > > On 2024/10/21 17:39, syzbot wrote: >> Hello, >> >> syzbot found the following issue on: >> >> HEAD commit: c964ced77262 Merge tag 'for-linus' of git://git.kernel.org.. >> git tree: upstream >> console output: https://syzkaller.appspot.com/x/log.txt?x=11420240580000 >> kernel config: https://syzkaller.appspot.com/x/.config?x=cfbd94c114a3d407 >> dashboard link: https://syzkaller.appspot.com/bug?extid=be4a9983e95a5e25c8d3 >> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 >> >> Unfortunately, I don't have any reproducer for this issue yet. >> >> Downloadable assets: >> disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7feb34a89c2a/non_bootable_disk-c964ced7.raw.xz >> vmlinux: https://storage.googleapis.com/syzbot-assets/e937ef58569a/vmlinux-c964ced7.xz >> kernel image: https://storage.googleapis.com/syzbot-assets/f1df9880ca4b/bzImage-c964ced7.xz >> >> IMPORTANT: if you fix the issue, please add the following tag to the commit: >> Reported-by: syzbot+be4a9983e95a5e25c8d3@syzkaller.appspotmail.com >> >> ====================================================== >> WARNING: possible circular locking dependency detected >> 6.12.0-rc3-syzkaller-00087-gc964ced77262 #0 Not tainted >> ------------------------------------------------------ >> kswapd0/79 is trying to acquire lock: >> ffff888011824088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2199 [inline] >> ffff888011824088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_record_stop_reason+0x52/0x1d0 fs/f2fs/super.c:4068 >> >> but task is already holding lock: >> ffff88804bd92610 (sb_internal#2){.+.+}-{0:0}, at: f2fs_evict_inode+0x662/0x15c0 fs/f2fs/inode.c:842 >> >> which lock already depends on the new lock. >> >> >> the existing dependency chain (in reverse order) is: >> >> -> #2 (sb_internal#2){.+.+}-{0:0}: >> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 >> percpu_down_read include/linux/percpu-rwsem.h:51 [inline] >> __sb_start_write include/linux/fs.h:1716 [inline] >> sb_start_intwrite+0x4d/0x1c0 include/linux/fs.h:1899 >> f2fs_evict_inode+0x662/0x15c0 fs/f2fs/inode.c:842 >> evict+0x4e8/0x9b0 fs/inode.c:725 >> f2fs_evict_inode+0x1a4/0x15c0 fs/f2fs/inode.c:807 >> evict+0x4e8/0x9b0 fs/inode.c:725 >> dispose_list fs/inode.c:774 [inline] >> prune_icache_sb+0x239/0x2f0 fs/inode.c:963 >> super_cache_scan+0x38c/0x4b0 fs/super.c:223 >> do_shrink_slab+0x701/0x1160 mm/shrinker.c:435 >> shrink_slab+0x1093/0x14d0 mm/shrinker.c:662 >> shrink_one+0x43b/0x850 mm/vmscan.c:4818 >> shrink_many mm/vmscan.c:4879 [inline] >> lru_gen_shrink_node mm/vmscan.c:4957 [inline] >> shrink_node+0x3799/0x3de0 mm/vmscan.c:5937 >> kswapd_shrink_node mm/vmscan.c:6765 [inline] >> balance_pgdat mm/vmscan.c:6957 [inline] >> kswapd+0x1ca3/0x3700 mm/vmscan.c:7226 >> kthread+0x2f0/0x390 kernel/kthread.c:389 >> ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 >> ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 >> >> -> #1 (fs_reclaim){+.+.}-{0:0}: >> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 >> __fs_reclaim_acquire mm/page_alloc.c:3834 [inline] >> fs_reclaim_acquire+0x88/0x130 mm/page_alloc.c:3848 >> might_alloc include/linux/sched/mm.h:318 [inline] >> prepare_alloc_pages+0x147/0x5b0 mm/page_alloc.c:4493 >> __alloc_pages_noprof+0x16f/0x710 mm/page_alloc.c:4722 >> alloc_pages_mpol_noprof+0x3e8/0x680 mm/mempolicy.c:2265 >> alloc_pages_noprof mm/mempolicy.c:2345 [inline] >> folio_alloc_noprof+0x128/0x180 mm/mempolicy.c:2352 >> filemap_alloc_folio_noprof+0xdf/0x500 mm/filemap.c:1010 >> do_read_cache_folio+0x2eb/0x850 mm/filemap.c:3787 >> read_mapping_folio include/linux/pagemap.h:1011 [inline] >> f2fs_commit_super+0x3c0/0x7d0 fs/f2fs/super.c:4032 >> f2fs_record_stop_reason+0x13b/0x1d0 fs/f2fs/super.c:4079 >> f2fs_handle_critical_error+0x2ac/0x5c0 fs/f2fs/super.c:4174 >> f2fs_write_inode+0x35f/0x4d0 fs/f2fs/inode.c:785 >> write_inode fs/fs-writeback.c:1503 [inline] >> __writeback_single_inode+0x711/0x10d0 fs/fs-writeback.c:1723 >> writeback_single_inode+0x1f3/0x660 fs/fs-writeback.c:1779 >> sync_inode_metadata+0xc4/0x120 fs/fs-writeback.c:2849 >> f2fs_release_file+0xa8/0x100 fs/f2fs/file.c:1941 >> __fput+0x23f/0x880 fs/file_table.c:431 >> task_work_run+0x24f/0x310 kernel/task_work.c:228 >> resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] >> exit_to_user_mode_loop kernel/entry/common.c:114 [inline] >> exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline] >> __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] >> syscall_exit_to_user_mode+0x168/0x370 kernel/entry/common.c:218 >> do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89 >> entry_SYSCALL_64_after_hwframe+0x77/0x7f >> >> -> #0 (&sbi->sb_lock){++++}-{3:3}: >> check_prev_add kernel/locking/lockdep.c:3161 [inline] >> check_prevs_add kernel/locking/lockdep.c:3280 [inline] >> validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 >> __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202 >> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 >> down_write+0x99/0x220 kernel/locking/rwsem.c:1577 >> f2fs_down_write fs/f2fs/f2fs.h:2199 [inline] >> f2fs_record_stop_reason+0x52/0x1d0 fs/f2fs/super.c:4068 >> f2fs_handle_critical_error+0x2ac/0x5c0 fs/f2fs/super.c:4174 >> f2fs_evict_inode+0xa61/0x15c0 fs/f2fs/inode.c:883 >> evict+0x4e8/0x9b0 fs/inode.c:725 >> f2fs_evict_inode+0x1a4/0x15c0 fs/f2fs/inode.c:807 >> evict+0x4e8/0x9b0 fs/inode.c:725 >> dispose_list fs/inode.c:774 [inline] >> prune_icache_sb+0x239/0x2f0 fs/inode.c:963 >> super_cache_scan+0x38c/0x4b0 fs/super.c:223 >> do_shrink_slab+0x701/0x1160 mm/shrinker.c:435 >> shrink_slab+0x1093/0x14d0 mm/shrinker.c:662 >> shrink_one+0x43b/0x850 mm/vmscan.c:4818 >> shrink_many mm/vmscan.c:4879 [inline] >> lru_gen_shrink_node mm/vmscan.c:4957 [inline] >> shrink_node+0x3799/0x3de0 mm/vmscan.c:5937 >> kswapd_shrink_node mm/vmscan.c:6765 [inline] >> balance_pgdat mm/vmscan.c:6957 [inline] >> kswapd+0x1ca3/0x3700 mm/vmscan.c:7226 >> kthread+0x2f0/0x390 kernel/kthread.c:389 >> ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 >> ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 >> >> other info that might help us debug this: >> >> Chain exists of: >> &sbi->sb_lock --> fs_reclaim --> sb_internal#2 >> >> Possible unsafe locking scenario: >> >> CPU0 CPU1 >> ---- ---- >> rlock(sb_internal#2); >> lock(fs_reclaim); >> lock(sb_internal#2); >> lock(&sbi->sb_lock); >> >> *** DEADLOCK *** >> >> 3 locks held by kswapd0/79: >> #0: ffffffff8ea37160 (fs_reclaim){+.+.}-{0:0}, at: balance_pgdat mm/vmscan.c:6844 [inline] >> #0: ffffffff8ea37160 (fs_reclaim){+.+.}-{0:0}, at: kswapd+0xbf1/0x3700 mm/vmscan.c:7226 >> #1: ffff88804bd920e0 (&type->s_umount_key#47){.+.+}-{3:3}, at: super_trylock_shared fs/super.c:562 [inline] >> #1: ffff88804bd920e0 (&type->s_umount_key#47){.+.+}-{3:3}, at: super_cache_scan+0x94/0x4b0 fs/super.c:196 >> #2: ffff88804bd92610 (sb_internal#2){.+.+}-{0:0}, at: f2fs_evict_inode+0x662/0x15c0 fs/f2fs/inode.c:842 >> >> stack backtrace: >> CPU: 0 UID: 0 PID: 79 Comm: kswapd0 Not tainted 6.12.0-rc3-syzkaller-00087-gc964ced77262 #0 >> Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 >> Call Trace: >> >> __dump_stack lib/dump_stack.c:94 [inline] >> dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 >> print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 >> check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 >> check_prev_add kernel/locking/lockdep.c:3161 [inline] >> check_prevs_add kernel/locking/lockdep.c:3280 [inline] >> validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 >> __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5202 >> lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5825 >> down_write+0x99/0x220 kernel/locking/rwsem.c:1577 >> f2fs_down_write fs/f2fs/f2fs.h:2199 [inline] >> f2fs_record_stop_reason+0x52/0x1d0 fs/f2fs/super.c:4068 >> f2fs_handle_critical_error+0x2ac/0x5c0 fs/f2fs/super.c:4174 >> f2fs_evict_inode+0xa61/0x15c0 fs/f2fs/inode.c:883 >> evict+0x4e8/0x9b0 fs/inode.c:725 >> f2fs_evict_inode+0x1a4/0x15c0 fs/f2fs/inode.c:807 >> evict+0x4e8/0x9b0 fs/inode.c:725 >> dispose_list fs/inode.c:774 [inline] >> prune_icache_sb+0x239/0x2f0 fs/inode.c:963 >> super_cache_scan+0x38c/0x4b0 fs/super.c:223 >> do_shrink_slab+0x701/0x1160 mm/shrinker.c:435 >> shrink_slab+0x1093/0x14d0 mm/shrinker.c:662 >> shrink_one+0x43b/0x850 mm/vmscan.c:4818 >> shrink_many mm/vmscan.c:4879 [inline] >> lru_gen_shrink_node mm/vmscan.c:4957 [inline] >> shrink_node+0x3799/0x3de0 mm/vmscan.c:5937 >> kswapd_shrink_node mm/vmscan.c:6765 [inline] >> balance_pgdat mm/vmscan.c:6957 [inline] >> kswapd+0x1ca3/0x3700 mm/vmscan.c:7226 >> kthread+0x2f0/0x390 kernel/kthread.c:389 >> ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 >> ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 >> >> >> >> --- >> This report is generated by a bot. It may contain errors. >> See https://goo.gl/tpsmEJ for more information about syzbot. >> syzbot engineers can be reached at syzkaller@googlegroups.com. >> >> syzbot will keep track of this issue. See: >> https://goo.gl/tpsmEJ#status for how to communicate with syzbot. >> >> If the report is already addressed, let syzbot know by replying with: >> #syz fix: exact-commit-title >> >> If you want to overwrite report's subsystems, reply with: >> #syz set subsystems: new-subsystem >> (See the list of subsystem names on the web dashboard) >> >> If the report is a duplicate of another one, reply with: >> #syz dup: exact-subject-of-another-report >> >> If you want to undo deduplication, reply with: >> #syz undup >> >> >> _______________________________________________ >> Linux-f2fs-devel mailing list >> Linux-f2fs-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel >