mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>,
	gregkh@linuxfoundation.org
Cc: f3sch.git@outlook.com, guozihua@huawei.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8192e: spaces preferred around that '<<' (ctx:VxV)
Date: Mon, 19 Sep 2022 20:51:21 +0200	[thread overview]
Message-ID: <672512d7-06ae-c6ca-280c-13183c5bdd00@gmail.com> (raw)
In-Reply-To: <20220919141624.8765-1-aruna.hewapathirane@gmail.com>

On 9/19/22 16:16, Aruna Hewapathirane wrote:
> This patch fixes 2 checkpatch CHECK issues
> 
> Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@gmail.com>
> ---
>   drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
> index f651947f6b44..933f347fc17e 100644
> --- a/drivers/staging/rtl8192e/rtllib_tx.c
> +++ b/drivers/staging/rtl8192e/rtllib_tx.c
> @@ -818,10 +818,10 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
>   					 cpu_to_le16(rtllib_query_seqnum(ieee, skb_frag,
>   							     header.addr1));
>   				frag_hdr->seq_ctl =
> -					 cpu_to_le16(le16_to_cpu(frag_hdr->seq_ctl)<<4 | i);
> +					 cpu_to_le16(le16_to_cpu(frag_hdr->seq_ctl) << 4 | i);
>   			} else {
>   				frag_hdr->seq_ctl =
> -					 cpu_to_le16(ieee->seq_ctrl[0]<<4 | i);
> +					 cpu_to_le16(ieee->seq_ctrl[0] << 4 | i);
>   			}
>   			/* Put a SNAP header on the first fragment */
>   			if (i == 0) {


Please remove the 3/3
add a V2 and a change history



      reply	other threads:[~2022-09-19 18:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-19 14:16 Aruna Hewapathirane
2022-09-19 18:51 ` Philipp Hortmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=672512d7-06ae-c6ca-280c-13183c5bdd00@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=aruna.hewapathirane@gmail.com \
    --cc=f3sch.git@outlook.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guozihua@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®