From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756345AbZBFQpM (ORCPT ); Fri, 6 Feb 2009 11:45:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751821AbZBFQo5 (ORCPT ); Fri, 6 Feb 2009 11:44:57 -0500 Received: from gate.crashing.org ([63.228.1.57]:51975 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbZBFQo5 (ORCPT ); Fri, 6 Feb 2009 11:44:57 -0500 Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Message-Id: <67331C84-5400-4FE5-B6FA-395F13A482F8@kernel.crashing.org> From: Kumar Gala To: Julia Lawall In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v930.3) Subject: Re: [PATCH] arch/powerpc: Eliminate double sizeof Date: Fri, 6 Feb 2009 10:44:44 -0600 References: X-Mailer: Apple Mail (2.930.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Feb 4, 2009, at 3:43 PM, Julia Lawall wrote: > From: Julia Lawall > > Taking sizeof the result of sizeof is quite strange and does not > seem to be > what is wanted here. > > This was fixed using the following semantic patch. > (http://www.emn.fr/x-info/coccinelle/) > > // > @@ > expression E; > @@ > > - sizeof ( > sizeof (E) > - ) > > @@ > type T; > @@ > > - sizeof ( > sizeof (T) > - ) > // > > Signed-off-by: Julia Lawall > --- > arch/powerpc/platforms/82xx/pq2ads-pci-pic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied - k