From: Joe Perches <joe@perches.com>
To: Dwaipayan Ray <dwaipayanray1@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com
Subject: Re: [PATCH] checkpatch: Fix unescaped left brace
Date: Mon, 16 Nov 2020 15:02:36 -0800 [thread overview]
Message-ID: <67332536788cefbc39c7f87129adca462bb42fa5.camel@perches.com> (raw)
In-Reply-To: <d3d6b68178b4193f04c35863163ce811a1571c0a.camel@perches.com>
On Sun, 2020-11-15 at 19:43 -0800, Joe Perches wrote:
> On Mon, 2020-11-16 at 01:59 +0530, Dwaipayan Ray wrote:
> > There is an unescaped left brace in a regex in OPEN_BRACE
> > check. This throws a runtime error when checkpatch is run
> > with --fix flag and the OPEN_BRACE check is executed.
> >
> > Fix it by escaping the left brace.
> >
> > Fixes: 8d1824780f2f ("checkpatch: add --fix option for a couple OPEN_BRACE misuses")
> > Signed-off-by: Dwaipayan Ray <dwaipayanray1@gmail.com>
>
> Thanks Dwaipayan.
>
> Obviously that code path hasn't been tested in awhile.
>
> I think the notice to require an escape for a { was added back in
> perl 5.16 or so.
Just fyi: it seems the requirement was actually implemented in perl 5.22
and this code predates the release of perl 5.22
https://github.com/Perl/perl5/blob/blead/pod/perl5220delta.pod
next prev parent reply other threads:[~2020-11-16 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 20:29 Dwaipayan Ray
2020-11-16 3:43 ` Joe Perches
2020-11-16 23:02 ` Joe Perches [this message]
2020-11-17 9:07 ` Dwaipayan Ray
2020-11-17 16:04 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67332536788cefbc39c7f87129adca462bb42fa5.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®