From: Dave Hansen <dave.hansen@intel.com>
To: Xin Li <xin@zytor.com>, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
peterz@infradead.org, andrew.cooper3@citrix.com
Subject: Re: [PATCH v2 1/1] x86/fred: Clear WFE in missing-ENDBRANCH #CPs
Date: Thu, 7 Nov 2024 10:57:57 -0800 [thread overview]
Message-ID: <6734b32e-c089-4754-9209-4ba01095c785@intel.com> (raw)
In-Reply-To: <49b6c23b-dfd8-4874-bd6e-998dd039ed1a@zytor.com>
On 11/7/24 10:54, Xin Li wrote:
> +static void ibt_clear_fred_wfe(struct pt_regs *regs)
> +{
> + regs->fred_cs.wfe = 0;
> +}
Also, just looking at this, we have obviously FRED-specific code without
any FRED checks. Now I know we asked you to remove those checks, but
this does need commenting or at least a changelog sentence on why this
incorrect-looking code is still OK.
next prev parent reply other threads:[~2024-11-07 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 18:10 Xin Li (Intel)
2024-11-07 18:54 ` Xin Li
2024-11-07 18:57 ` Dave Hansen [this message]
2024-11-08 20:53 ` Andrew Cooper
2024-11-12 2:53 ` Xin Li
2024-11-07 20:51 ` Dave Hansen
2024-11-08 2:02 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6734b32e-c089-4754-9209-4ba01095c785@intel.com \
--to=dave.hansen@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®