Re: mm/slub: fix a memory leak in sysfs_slab_add()

[syzbot <syzbot+d0bd96b4696c1ef67991@syzkaller.appspotmail.com>]

> #syz test

This bug is already marked as fixed. No point in testing.

>
> diff --git a/mm/slub.c b/mm/slub.c
> index 4148235ba554..d10c4fbf8c84 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -5653,7 +5653,7 @@ static int sysfs_slab_add(struct kmem_cache *s)
> s->kobj.kset = kset;
> err = kobject_init_and_add(&s->kobj, &slab_ktype, NULL, "%s",
> name);
> if (err) {
> - kobject_put(&s->kobj);
> + kfree_const(&s->kobj.name);
> goto out;
> }
>
> On Thu, Nov 14, 2024 at 1:18 PM syzbot <
> syzbot+d0bd96b4696c1ef67991@syzkaller.appspotmail.com> wrote:
>
>> > #syz test git://
>> git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>
>> want either no args or 2 args (repo, branch), got 1
>>
>> > master
>> >
>> > diff --git a/mm/slub.c b/mm/slub.c
>> > index 4148235ba554..d10c4fbf8c84 100644
>> > --- a/mm/slub.c
>> > +++ b/mm/slub.c
>> > @@ -5653,7 +5653,7 @@ static int sysfs_slab_add(struct kmem_cache *s)
>> > s->kobj.kset = kset;
>> > err = kobject_init_and_add(&s->kobj, &slab_ktype, NULL, "%s",
>> > name);
>> > if (err) {
>> > - kobject_put(&s->kobj);
>> > + kfree_const(&s->kobj.name);
>> > goto out;
>> > }
>>