From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D64B5463B98 for ; Tue, 18 Aug 2026 11:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787054338; cv=none; b=UzKqxhOe+WfWKbpGX2NBVUAVaiAh7OYTbQlImEZPvSFWn1Uj8+kwLT92qmD9t5NiavRrNX4wwO6fp0IO4GCeh2cKNjQnMdrieL0mZCkAq8/GkXhirRhfFguV6PxlJ7aX2nRnMvM/ZErKmVkMemeYCW59BLxqxjP+OrFHOrPToGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787054338; c=relaxed/simple; bh=cBsjwGnq7m3PBpDVHoEIoFuskUMz6L3TJJljzXNosc4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OBHmdeac1fZwGwVZAiI8DVXP2HR6/nhiUtLNhX46FBySFzQHjvslcphurERctaUTpdFhNjFA5km3o7k6FK7ZDWZgZ4Rq5gCZ9MrgoYedMAZ+5S5jUaJ8TpCqC4QDHEED6SSBZ3deA+6ScB7tqC0VgCz/cZdGwLurHMrLkOj9pAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=f4cc47Sp; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="f4cc47Sp" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-49954b88fffso50892045e9.0 for ; Tue, 18 Aug 2026 04:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1787054335; x=1787659135; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bP85D3OmgxN7hDQ/WBox4fmJQt7qI0HEkQthONdkZ30=; b=f4cc47SpR3C8jmGrjAmwOKOPX85UYCCc+Fy56LA8BcfN8qQcpWjaF7CUo58eBgzGgP i64SZdXPGh554eNplRP0MAS/bdv6P5LuTHtIs06RZC/6Ug2nOSF+vk9MBbVxGuS+LmNH ruCQbTv5JNufooA/mebIE0qKzWMoX4g3g85zw5F+ioLNsqjTPFsK64Vdpl3iWl1kN1Vj lenvPERYTBfDin3u28UZNHKD7f84SHH52kBJ7j+fjbjjywcMVQhdb0J+jx7Jvql8uDKW tCckAehrlw/peD+XvweYupzotRDAqaa69h+ZkIRF3Qfe6LRqTyRTY86tXuwezenRYysq up1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787054335; x=1787659135; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bP85D3OmgxN7hDQ/WBox4fmJQt7qI0HEkQthONdkZ30=; b=o3IACtWyn2YX7J+JAoXMJvjQxR94a7rIP9aUFLva20+6ZRuSfyfCLPMZSoNErtOu8X a7DziLXQwy9iRSOF7kcND0SZLuUIhVIyIcx+1B2abLhwLSvq51l0iHnQkbF26EEA+RWD 4Pn1pEGOzq2Ou3fj0bp/cFQDU1JvVspr5GmKWJjeTugVaHMjKY4HlvE3usPYc6moAUGN 2Sajkhb48/xKt32I2wxVpo3i+AhkAiPzH8pEp1akmaZepCLtvK7nBD92pP2dZ8euXht9 rxlSctjrvZqccdFzyaSdOoN2nmBjaBUGs2uMoVzVDsnE5qtQMeEWzDqxyfBSGIV6nchW SgwA== X-Forwarded-Encrypted: i=1; AHgh+RpM07paFsUXEmq6Cf60mgdKar8exDcPT2uHLXwJa0doFCuWPbInZlLB4RuViX9Ls3cVhKJEI4JnNVfFvbo=@vger.kernel.org X-Gm-Message-State: AOJu0YwhUvJfmP/cPMvomYpn1ctyiuFpuDwylN7CxvYBheoJ4PH4SuEP IU3sK3IcZGW+x05NZuPga5ysrxTgdsHW6pQ47EuvGKz/ADm6A2HWGg5rgykfsWKfqMo= X-Gm-Gg: AR+sD10q7/bjdHKuiZosNaoBV7ANEJOI/EU//v5OIr88yDr5ToQrJhW8Y2KQsymigu8 0aAh6J2CqjGUdhYjYr1QCSRRcefuyXz6ec10XNAH2FzdKdEj1o0SpM5sc47yuim4xn/YKwKeyR4 nAXy8g8ZXqsUpjRBTIWZnCgO6rde/H1cmHxyjstpU6XGBznAiUHH4Jbk4p9Pi88p5d1CzatkT7o DonX0oAZbeftl98m9NE1usQ9v1IXPTSmRWpiFnvxJCDwxA3cDv5ETCFq9jnhwCJahlCHw5IStAP xE+gcmM4tsZ5qc/o5xZ4VAy5nTlZfMy/o6DM4p6DES195IRhqJLfRjcwGnFRcRjLC9oCDGUdfuR fp7QsJFUSLku4nyUyaxyOxY7SXOsJ4vhWny++QkVmxEQIoRXF5yfvgmXG1+F4NMNm5H7nHrHYw8 s9JqErzorKod9yidFtRni3UERO/7BSu1Urtz566H1zNUnYSOm3OIh3r/XFPR7VrtRSIbJSERSyk 2f8E+WCXdMd6B+aAvDM6+9K X-Received: by 2002:a05:600c:4e56:b0:499:a69d:e14b with SMTP id 5b1f17b1804b1-499a69de2fbmr38435355e9.4.1787054335163; Tue, 18 Aug 2026 04:58:55 -0700 (PDT) Received: from ?IPV6:2a07:de40:8100:0:fc6c:f9a2:4a0a:6354? ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482a5b7834dsm11494313f8f.28.2026.08.18.04.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 04:58:54 -0700 (PDT) Message-ID: <674042ea-243c-48f5-8010-9181f3e99f06@suse.com> Date: Tue, 18 Aug 2026 13:58:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] module/kallsyms: Refactor current symbol filtering into is_kept_symbol() To: Tiezhu Yang Cc: Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , linux-modules@vger.kernel.org, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260812032807.15034-1-yangtiezhu@loongson.cn> <20260812032807.15034-3-yangtiezhu@loongson.cn> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260812032807.15034-3-yangtiezhu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/12/26 5:28 AM, Tiezhu Yang wrote: > Currently, the loops in layout_symtab() and add_kallsyms() duplicate the > exact same checks (i == 0 || is_livepatch_module() || is_core_symbol()) > to determine whether a symbol should be preserved in the module's core > symbol table. > > Rename is_core_symbol() to is_kept_symbol() and move the entire checking > logic inside it, including the special handlers for the first symbol and > livepatch modules. > > No functional change. > > Suggested-by: Petr Pavlu > Signed-off-by: Tiezhu Yang Looks ok to me. I'm also fine also keeping the current name, is_core_symbol(), as Huacai mentions in his review [1]. I previously suggested is_kept_symbol() [2], since the is_livepatch_module() check is moved into this function. However, is_core_symbol() is still ok, as it is consistent with where the symbols are assigned, in module::core_kallsyms. The important part is to avoid duplicating the checks that determine whether a symbol should be kept in layout_symtab() and add_kallsyms(). Reviewed-by: Petr Pavlu [1] https://lore.kernel.org/linux-modules/CAAhV-H5w8VVW_L6cRes-syjEvhbWmevSKWrZWPFapRkuemmjaw@mail.gmail.com/ [2] https://lore.kernel.org/linux-modules/39a48465-22b6-4b18-9f7e-ce258513181b@suse.com/ -- Thanks, Petr