From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB8533093CF for ; Mon, 9 Feb 2026 09:59:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770631199; cv=none; b=L1B57gjyI1zBpUaDFEywsxPOI6MR7CLP/c9z1IlTv4UZ1a9Lt3KZotdxLnxELN/0nSkcFPCoB0OFyahimwsKv98pVD/7Lym07qC29VTKY3UMP7txDsiNTFfQEcRU9K8uNvvGJ68RW+X6BsoM4UBoQKmJSoBNgkDWfN0VEQaU9Es= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770631199; c=relaxed/simple; bh=A/e7FzRMEd3NlQn9M43ALXRbk/O5iSkta1Q9eSeeClg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=TanRSxS3M5Wywohm/uxt8rDZgRr+rpqiW6MF+FuNYqUvHLBZ2pxK79sACZ2OpoFpoiicg5W0u5WP6C5mUL6QDmFna+TdahijQjSwJsF70CMb9Gu2QHAySvLwpCplaE7xItfFEhLP8kIFy8qEyyAEfAtsIX2gj6RpsXhH2X3EZjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=qpV3gWpV; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="qpV3gWpV" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20260209095951euoutp01baa7963db88fd1688a5076527b2ae237~Si6-3eJLA1795217952euoutp010 for ; Mon, 9 Feb 2026 09:59:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20260209095951euoutp01baa7963db88fd1688a5076527b2ae237~Si6-3eJLA1795217952euoutp010 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1770631191; bh=5Jq6T2NL3sJU/yaMiBjfOEI1QO0U+OXfk+QKONCyl7c=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=qpV3gWpV2gxI649/5LHw4/XLYJd7VVCVg5XXoJKwQMlYRQsi+rXtVKtSA9VquOHKv NAmblswScThWgMkWWNDAZnWz5lvT86q3/mVcroTADOACj4CUvuljoY8jEhntPGoJHW CErjDG3kPRZaMgWvXWEgI0M/lOBUtap99oB+f4dw= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20260209095951eucas1p10adcd75ea027ee2a57a7646328ed362e~Si6-mdUVH2286522865eucas1p1U; Mon, 9 Feb 2026 09:59:51 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260209095950eusmtip298958b48357f2492c8b907614e73150d~Si6_1ohpG0894008940eusmtip2a; Mon, 9 Feb 2026 09:59:50 +0000 (GMT) Message-ID: <67426771-7df6-4544-a77c-97f44ee08d99@samsung.com> Date: Mon, 9 Feb 2026 10:59:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH] mm: cma: Fix stub for cma_skip_dt_default_reserved_mem() To: "David Hildenbrand (Arm)" , Mark Brown , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Rob Herring (Arm)" , Oreoluwa Babatunde Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: <4fc5e312-b56a-4664-9722-81163ecef515@kernel.org> Content-Transfer-Encoding: 8bit X-CMS-MailID: 20260209095951eucas1p10adcd75ea027ee2a57a7646328ed362e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20260209081154eucas1p2ce1f3c7bd5cae843fd60355314c8d4ce X-EPHeader: CA X-CMS-RootMailID: 20260209081154eucas1p2ce1f3c7bd5cae843fd60355314c8d4ce References: <20260128-cma-fix-stubs-v1-1-e07a077d5b33@kernel.org> <4fc5e312-b56a-4664-9722-81163ecef515@kernel.org> On 09.02.2026 09:11, David Hildenbrand (Arm) wrote: > On 1/28/26 17:28, Mark Brown wrote: >> The stub for cma_skip_dt_default_reserved_mem() is not inlined so >> triggers build warnings: >> >> In file included from /tmp/next/build/fs/proc/meminfo.c:18: >> /tmp/next/build/include/linux/cma.h:68:13: warning: >> 'cma_skip_dt_default_reserved_mem' defined but not used >> [-Wunused-function] >>     68 | static bool cma_skip_dt_default_reserved_mem(void) >>        |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> which are fatal with -Werror. >> >> Fixes: 26332ae848f08 ("of: reserved_mem: Allow reserved_mem framework >> detect "cma=" kernel param") >> Signed-off-by: Mark Brown > > $ git show 26332ae848f08 > fatal: ambiguous argument '26332ae848f08': unknown revision or path > not in the working tree. > > This is not upstream or against an mm tree. Against which tree is it? The fix for this issue has been squashed into commit 0fd17e598333 ("of: reserved_mem: Allow reserved_mem framework detect "cma=" kernel param") and merged to v6.19-rc8, so the above fix is not longer needed. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland