From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752447AbdK3Nzk (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 08:55:40 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:18219 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752241AbdK3Nzi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 08:55:38 -0500
Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset
 with 'do_flr' SysFS attribute
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Juergen Gross <jgross@suse.com>, linux-kernel@vger.kernel.org
References: <20171106174842.20276-1-Govinda.Tatti@Oracle.COM>
 <5A01D3F3020000780018CE86@prv-mh.provo.novell.com>
 <8940b38d-715c-9fcb-cc74-46574d416703@oracle.com>
 <5A041FB9020000780018D6E8@prv-mh.provo.novell.com>
 <af25e0d8-ca55-7eb4-649e-5297b0e09299@oracle.com>
 <5A1EE1D50200007800193318@prv-mh.provo.novell.com>
 <20171129162907.GO31092@char.us.oracle.com>
 <5A1EF1040200007800193425@prv-mh.provo.novell.com>
 <20171129192630.GS31092@char.us.oracle.com>
 <b6698aef-c6f4-0a94-ae2f-b95f1643924d@oracle.com>
 <5A1FCF95020000780019364A@prv-mh.provo.novell.com>
From: Govinda Tatti <govinda.tatti@oracle.com>
Organization: Oracle Corporation
Message-ID: <674347a4-68f3-b1fc-1cf2-d910e84f3026@oracle.com>
Date: Thu, 30 Nov 2017 07:55:27 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <5A1FCF95020000780019364A@prv-mh.provo.novell.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 11/30/2017 2:29 AM, Jan Beulich wrote:
>>>> On 29.11.17 at 20:44, <govinda.tatti@oracle.com> wrote:
>> So, we will use the following sequence to reset the requested
>> device/function.
>>
>> - FLR (as first option)
>> - BUS/SLOT reset (as fall-back option) if FLR is not supported or any
>> issue with FLR
> It looks to me as if the slot reset could also fail despite the probe
> having succeeded. In such a case it might be better to try a bus
> reset, i.e. the sequence would become
> - FLR
> - slot reset if FLR failed
> - bus reset if slot reset failed
Fine with me.

Cheers
GOVINDA