From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751089AbdK3WRA (ORCPT ); Thu, 30 Nov 2017 17:17:00 -0500 Received: from ale.deltatee.com ([207.54.116.67]:50028 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbdK3WQ7 (ORCPT ); Thu, 30 Nov 2017 17:16:59 -0500 To: Serge Semin , jdmason@kudzu.us, dave.jiang@intel.com, Allen.Hubbe@emc.com, Shyam-sundar.S-k@amd.com, Xiangliang.Yu@amd.com Cc: Sergey.Semin@t-platforms.ru, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org References: <20171130213910.21052-1-fancer.lancer@gmail.com> From: Logan Gunthorpe Message-ID: <67533cef-83f0-05e4-1cb2-0071db3d8576@deltatee.com> Date: Thu, 30 Nov 2017 15:16:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171130213910.21052-1-fancer.lancer@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, Sergey.Semin@t-platforms.ru, Xiangliang.Yu@amd.com, Shyam-sundar.S-k@amd.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, jdmason@kudzu.us, fancer.lancer@gmail.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] NTB: Set dma mask and dma coherent mask to NTB devices X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/11/17 02:39 PM, Serge Semin wrote: > diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c > index f0788aae05c9..3cfa46876239 100644 > --- a/drivers/ntb/hw/amd/ntb_hw_amd.c > +++ b/drivers/ntb/hw/amd/ntb_hw_amd.c > @@ -1020,6 +1020,10 @@ static int amd_ntb_init_pci(struct amd_ntb_dev *ndev, > goto err_dma_mask; > dev_warn(&pdev->dev, "Cannot DMA consistent highmem\n"); > } > + rc = dma_coerce_mask_and_coherent(&ndev->ntb.dev, > + dma_get_mask(&pdev->dev)); > + if (rc) > + goto err_dma_mask; I can't say I understand fully what this is solving. Perhaps you could explain it a little further in the commit message. In any case, to me, it looks like it would be better in ntb_register_device() instead of every single driver. > diff --git a/drivers/ntb/ntb.c b/drivers/ntb/ntb.c > index 03b80d89b980..79e50a5f8902 100644 > --- a/drivers/ntb/ntb.c > +++ b/drivers/ntb/ntb.c > @@ -112,7 +112,6 @@ int ntb_register_device(struct ntb_dev *ntb) > > init_completion(&ntb->released); > > - memset(&ntb->dev, 0, sizeof(ntb->dev)); > ntb->dev.bus = &ntb_bus; > ntb->dev.parent = &ntb->pdev->dev; > ntb->dev.release = ntb_dev_release; > This is unrelated to above. I agree it should probably be removed but I'd suggest it should be in its own commit with its own justification. Thanks, Logan