From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9101C433E0 for ; Wed, 23 Dec 2020 14:16:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9662E23371 for ; Wed, 23 Dec 2020 14:16:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728990AbgLWOQZ (ORCPT ); Wed, 23 Dec 2020 09:16:25 -0500 Received: from out28-99.mail.aliyun.com ([115.124.28.99]:48463 "EHLO out28-99.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728827AbgLWOQX (ORCPT ); Wed, 23 Dec 2020 09:16:23 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.08652065|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_system_inform|0.496146-0.000596255-0.503258;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047213;MF=zhouyanjie@wanyeetech.com;NM=1;PH=DS;RN=5;RT=5;SR=0;TI=SMTPD_---.JAd2Ezk_1608732932; Received: from 192.168.10.118(mailfrom:zhouyanjie@wanyeetech.com fp:SMTPD_---.JAd2Ezk_1608732932) by smtp.aliyun-inc.com(10.147.44.118); Wed, 23 Dec 2020 22:15:32 +0800 Subject: Re: [PATCH] phy: ingenic: Remove useless field .version To: Paul Cercueil , Kishon Vijay Abraham I , Vinod Koul Cc: =?UTF-8?B?5ryG6bmP5oyv?= , linux-kernel@vger.kernel.org References: <20201223124505.40792-1-paul@crapouillou.net> From: Zhou Yanjie Message-ID: <67564e1e-a5a8-9e0f-6dc1-5e2ce1df5e5b@wanyeetech.com> Date: Wed, 23 Dec 2020 22:15:32 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20201223124505.40792-1-paul@crapouillou.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 2020/12/23 下午8:45, Paul Cercueil wrote: > Remove the useless field .version from the private structure, which is > set but never read. > > Signed-off-by: Paul Cercueil > --- > drivers/phy/ingenic/phy-ingenic-usb.c | 23 ----------------------- > 1 file changed, 23 deletions(-) Reviewed-by: 周琰杰 (Zhou Yanjie) Thanks and best regards! > > diff --git a/drivers/phy/ingenic/phy-ingenic-usb.c b/drivers/phy/ingenic/phy-ingenic-usb.c > index 4d1587d82286..ea127b177f46 100644 > --- a/drivers/phy/ingenic/phy-ingenic-usb.c > +++ b/drivers/phy/ingenic/phy-ingenic-usb.c > @@ -82,18 +82,7 @@ > #define USBPCR1_PORT_RST BIT(21) > #define USBPCR1_WORD_IF_16BIT BIT(19) > > -enum ingenic_usb_phy_version { > - ID_JZ4770, > - ID_JZ4775, > - ID_JZ4780, > - ID_X1000, > - ID_X1830, > - ID_X2000, > -}; > - > struct ingenic_soc_info { > - enum ingenic_usb_phy_version version; > - > void (*usb_phy_init)(struct phy *phy); > }; > > @@ -300,38 +289,26 @@ static void x2000_usb_phy_init(struct phy *phy) > } > > static const struct ingenic_soc_info jz4770_soc_info = { > - .version = ID_JZ4770, > - > .usb_phy_init = jz4770_usb_phy_init, > }; > > static const struct ingenic_soc_info jz4775_soc_info = { > - .version = ID_JZ4775, > - > .usb_phy_init = jz4775_usb_phy_init, > }; > > static const struct ingenic_soc_info jz4780_soc_info = { > - .version = ID_JZ4780, > - > .usb_phy_init = jz4780_usb_phy_init, > }; > > static const struct ingenic_soc_info x1000_soc_info = { > - .version = ID_X1000, > - > .usb_phy_init = x1000_usb_phy_init, > }; > > static const struct ingenic_soc_info x1830_soc_info = { > - .version = ID_X1830, > - > .usb_phy_init = x1830_usb_phy_init, > }; > > static const struct ingenic_soc_info x2000_soc_info = { > - .version = ID_X2000, > - > .usb_phy_init = x2000_usb_phy_init, > }; >