mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf auxtrace: Alter addr_filter__entire_dso() to work if there are no symbols
Date: Mon, 10 Dec 2018 15:17:05 +0200	[thread overview]
Message-ID: <67587a92-200c-ac7a-67bd-20df06cdd41b@intel.com> (raw)
In-Reply-To: <20181127124226.GC15747@kernel.org>

On 27/11/18 2:42 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 27, 2018 at 10:46:34AM +0200, Adrian Hunter escreveu:
>> addr_filter__entire_dso() uses the first and last symbols from a dso,
>> and so does not work when there are no symbols.  Alter it to filter the
>> whole file instead.
> 
> I'm splitting this patch into a first prep one that renames and exports
> the static function dso__data_file_size() and a second that does what
> this commig log message states.
> 
> The reason is that sometimes we find out that the main part of the patch
> is wrong and we then decide to revert the patch, only to realize that
> the exported function is by that time already used elsewhere.

Thanks for looking at this, but did it get lost?  I don't see it in your tree.

  reply	other threads:[~2018-12-10 13:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-27  8:46 Adrian Hunter
2018-11-27 12:42 ` Arnaldo Carvalho de Melo
2018-12-10 13:17   ` Adrian Hunter [this message]
2018-12-10 13:39     ` Arnaldo Carvalho de Melo
2018-12-20 17:57 ` [tip:perf/core] perf dso: Export data_file_size() method " tip-bot for Adrian Hunter
2018-12-20 17:58 ` [tip:perf/core] perf auxtrace: Alter addr_filter__entire_dso() to work if " tip-bot for Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67587a92-200c-ac7a-67bd-20df06cdd41b@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome