From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Temitope obabi <obabitemitope765@gmail.com>
Cc: <mhiramat@kernel.org>, <mathieu.desnoyers@efficios.com>,
<linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>, <rostedt@goodmis.org>
Subject: Re: [PATCH v2] ASoC: Intel: Remove unused intel-sst.h trace header
Date: Thu, 12 Nov 2026 10:53:04 +0100 [thread overview]
Message-ID: <675a6f5a-879f-49c4-a608-d7a82d09d36c@intel.com> (raw)
In-Reply-To: <20261111223102.1310-1-obabitemitope765@gmail.com>
On 11/11/2026 11:31 PM, Temitope obabi wrote:
> Commit 970d299b0a0a ("ASoC: Intel: Remove unused code") removed
> sound/soc/intel/common/sst-dsp.c, the only file that defined
> CREATE_TRACE_POINTS and included trace/events/intel-sst.h.
>
> Nothing includes this header anymore, so none of its tracepoints are
> built. Remove the unused header.
>
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
> ---
> Changes in v2:
> - Remove the whole header instead of only sst_ipc_inbox_rdata, since
> nothing includes it (reported by the Sashiko review of v1).
> - Drop the Fixes tag and the claim about memory used per tracepoint.
> - This also replaces the earlier sst_ipc_msg_tx patch for the same header.
Next time, please CC sound/soc/intel maintainers. The very commit starts
with "ASoC: Intel:".
Nitpick: if trace-subsystem maintainers permit ASoC-scoping for
include/trace, please update the title to: "ASoC: Intel: atom:" to
highlight which driver it does relate to.
The nitpick alone is not a reason for re-send.
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
prev parent reply other threads:[~2026-11-12 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 22:31 Temitope obabi
2026-11-12 9:53 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=675a6f5a-879f-49c4-a608-d7a82d09d36c@intel.com \
--to=cezary.rojewski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=obabitemitope765@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®