From: Dan Carpenter <dan.carpenter@linaro.org>
To: eisantosh95@gmail.com
Cc: Dave Penkler <dpenkler@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shuah Khan <skhan@linuxfoundation.org>,
"Everest K.C." <everestkc@everestkc.com.np>,
Kees Bakker <kees@ijzerbout.nl>, Arnd Bergmann <arnd@arndb.de>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: Replace semaphore with completion for one-time signaling
Date: Fri, 13 Dec 2024 10:02:05 +0300 [thread overview]
Message-ID: <675aedb1-b7dd-4565-b028-1a718fe3fb09@stanley.mountain> (raw)
In-Reply-To: <20241212162112.13083-1-eisantosh95@gmail.com>
On Thu, Dec 12, 2024 at 09:51:04PM +0530, eisantosh95@gmail.com wrote:
> From: Santosh Mahto <eisantosh95@gmail.com>
>
> Replaced 'down_interruptible()' and 'up()' calls
> with 'wait_for_completion_interruptible()' and
> 'complete()' respectively. The completion API
> simplifies the code and adheres to kernel best
> practices for synchronization primitive
>
> Signed-off-by: Santosh Mahto <eisantosh95@gmail.com>
Looks okay to me.
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
prev parent reply other threads:[~2024-12-13 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 16:21 eisantosh95
2024-12-13 7:02 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=675aedb1-b7dd-4565-b028-1a718fe3fb09@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=arnd@arndb.de \
--cc=dpenkler@gmail.com \
--cc=eisantosh95@gmail.com \
--cc=everestkc@everestkc.com.np \
--cc=gregkh@linuxfoundation.org \
--cc=kees@ijzerbout.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®