From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: hughd@google.com, baolin.wang@linux.alibaba.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] shmem: skip empty unmap ranges when punching holes
Date: Tue, 3 Nov 2026 20:41:47 +0100 [thread overview]
Message-ID: <675cfc9a-48ab-446d-9fd0-a1937dfeb0f4@kernel.org> (raw)
In-Reply-To: <CAGEkeHcwUEQ0tAXZ5npAhPp1OPMqkmZcNPTU1OnRuNTrwkDJMQ@mail.gmail.com>
On 11/3/26 20:38, Hungyu Lin wrote:
>> Can this be >= ?
>
> I think we should keep > here, since unmap_end + 1 is the exclusive
> end. Equality would pass a zero length to unmap_mapping_range(),
> which means unmap to EOF. For example, with offset = 0 and len = 1,
> both sides are zero.
>= is much clearer than then +1 trick, no?
To be clear, I was asking whether we could do
if ((u64)(unmap_end) >= (u64)unmap_start)
--
Cheers,
David
next prev parent reply other threads:[~2026-11-03 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 17:17 Hungyu Lin
2026-10-28 3:02 ` Baolin Wang
2026-11-03 16:08 ` David Hildenbrand (Arm)
2026-11-03 19:38 ` Hungyu Lin
2026-11-03 19:41 ` David Hildenbrand (Arm) [this message]
2026-11-03 20:00 ` Hungyu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=675cfc9a-48ab-446d-9fd0-a1937dfeb0f4@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dennylin0707@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®