From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8085237CD21 for ; Fri, 22 May 2026 19:19:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779477563; cv=none; b=RBXhtKjQtiMA13Zhv1KJ2FbgfAknCTNtXarGJCEm9SkT70YWlXeAOSf5TW4eQrvtFxkaEp1F6eVELjY7sro8ySbBH8SoeShkPmejR18AqW6onwUyojkR6uyrOmT2LCJ+k+JxhujvLikDV7NQ26OvSfC+2XglH+y6+Q5NbVsb9Rs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779477563; c=relaxed/simple; bh=+ZAe4tlkZzKHX7X5t4615D1xJnFK4/IiGNoeCQbEOV8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j18euRSwOob+vGhPPCzatw2vY8fPMcUB/QGBzkBqc1k43abedMU7NgvQLEhRGvlffclVTHMD0Fxu8u+PSg2aykmD5+3LLzFELj096yT2MQMD/YXP2vdL6YSw0B2wONXLnjC2rq8d42rPKO928m8qGE7yDBD6M2YoTp5iXg7qkXA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OclHh4hL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QW1sLW91; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OclHh4hL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QW1sLW91" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MHfK9l3600955 for ; Fri, 22 May 2026 19:19:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3O3CwZM57IGqkScx7N1v3lEW3tORhTFbt3uo4B8zhv8=; b=OclHh4hLa8vNZEM3 pQ9Ut99azhlVHeNmeXNU+nWxBQMau0YTx4PjZ9NedKXexMDFAln7nyabkNSw8yTu EJHyGAeCmkbkfN29E+65+m949EWXFM64nSo1/AbwommO14gALlWkWFkuKAXjvZ1Y NU4mm9tW3aB+Xi9bVFNxDCc0CeeRR6NXqZOF0YWvQEx04Bfiw0fOJ0QKCdHKTWtf FqFAuTMqwl6RVRWSLHMCOOiPWPSNq5oQrC1IhdSas58wmKTlu6/uoi3wQCdsHpqT dLO8ypeXDsYvHKzjrf5dneicpeBxci8I/PurUOZFY7PC60Y6ImTKNEww9DpuBZ74 8a7y4w== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eaury0aea-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 19:19:14 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3663d5e9bf4so7282125a91.1 for ; Fri, 22 May 2026 12:19:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779477553; x=1780082353; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3O3CwZM57IGqkScx7N1v3lEW3tORhTFbt3uo4B8zhv8=; b=QW1sLW91BYOjBhieYv8uvLkKLufV5uZfV2mfjTVwPAvBHxMsVRQuwqvFQykuBuWZJS Tcelu1Dpb5AmamkkQ0LByd5u2bQ9A/xz2gBbayXwhPHcJ4SELyCWhLbFdMpCXC20zAAt mNX3GzvxlWoQg57rMXgyFdNC79Hr8dVVvyOb3fwDIY9V9qVQeZ/m/kS+72b2BYPN+nWy FWiLST5OchJuQdV61MAdKV7DoZ6eG1VEeRkKv7KlA00LG75Li84DjdddGf1XdUP2+nsn AE3ywTi3Fw6YiHA8OQJPEcSAkSRppjeqBJKTWZYnAqV+NVH3WXjIPxRJ9YoF8561ywDU Ff7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779477553; x=1780082353; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3O3CwZM57IGqkScx7N1v3lEW3tORhTFbt3uo4B8zhv8=; b=qoRGwOmbPIPGwSMPrxV0pB/iAPz3O+kYDro9q+PMscAMiMq8XnMSVMSnfTdM16SUfg 5iQ+7PqH1UaymgDPaDIf1TfTf1jmSgtmB3Qoeqx4pW+cbcimT1Uibs2Lft5X8JWRt9Qy Nvlee5E1WA5BOJkQew0cxg5jxixOHG4MGJVgvsTqMOcFFQ3fj8Wh8+BvC66eCREvQX+2 0ikboRyT74c3wsAzwru5sUyloAjnNx4n3aOh6eJ541yRwZaiaL3BinmhxV1SPus9UBqU pcu8jcTOH7GmFOKDfI7VMSQW2TdHhyq9lE9Fz5bsPWhh2TyONWasoE1rTnWWIYhY9heR WQ4w== X-Forwarded-Encrypted: i=1; AFNElJ9VqYlX+D4TE7bZvP21xdNyerlYOQ68NV+UtLESAIGpJbxUQZg2TNeWOT/veBEDJVHYJlWeNnQrdWfHMTc=@vger.kernel.org X-Gm-Message-State: AOJu0YxFdIsjBy4RXt/7tmpxWkkAR67+U+CJ36vwgf6JCS006BgZ8oRV dOWXFs01+aeViRuR9x3DFZy9GEw6C8P49vLLEI2SKZVdDT+SB1ev8AJk5kqIx+VlnPB0e+TZ8nL HaunERdoPkB/XKKOJvIEDW68e5gXnhzfpQSdrln1QqotYlgmeNiz2GPPjDBabcRZ3BlE= X-Gm-Gg: Acq92OHqng6rjV1E2SdOToDdJXoj94rRLSDGYfRAbeG1E2+B+4+N7TVoHbHtRLcY56K IKOOYQppE3uZi4ut+jXRTD8fxkshA4DlQyLvVB+Sl5NapNOvUC5xi0UJyRGVQnG4mH13wqo+A+j FCyJi+DC2tIn9Z6mu6UMEqLBoEv44gdLKie8wpKHjJ5VozGo/jGTFgf46RuLOwbo7BXS7Q2LIgw IG3TwPzEMEtT1x7FN3XuZduqaCKRULiizv0ZVejzk7zd5f9SROLpNHUSBzrlhEmc5L+GzHqF4y5 X01jxoAeiH/Jw5AZIpN8sv4QmGQTkzFAlxMOfasgjSfgeu1UrBfAoTING2OkG+MLkyhoJYCT0ib zQ1rEnAYGzmNnp7MsdO1E9NPgCh1P9y/sx3HhmSxbsyuhA+TeHw== X-Received: by 2002:a17:90b:4c50:b0:369:bddb:79bd with SMTP id 98e67ed59e1d1-36a676c6a95mr4836870a91.25.1779477552859; Fri, 22 May 2026 12:19:12 -0700 (PDT) X-Received: by 2002:a17:90b:4c50:b0:369:bddb:79bd with SMTP id 98e67ed59e1d1-36a676c6a95mr4836847a91.25.1779477552393; Fri, 22 May 2026 12:19:12 -0700 (PDT) Received: from [192.168.1.6] ([223.230.21.136]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a721282e7sm2599195a91.0.2026.05.22.12.19.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 May 2026 12:19:12 -0700 (PDT) Message-ID: <675fefdb-a9e3-4eb3-abf9-65ef8f104603@oss.qualcomm.com> Date: Sat, 23 May 2026 00:49:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM To: Konrad Dybcio , Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Srinivas Kandagatla , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mohammad.rafi.shaik@oss.qualcomm.com References: <20260522073324.e18bb240b6f6@oss.qualcomm.com> <20260522130459.3411038-1-ajay.nandam@oss.qualcomm.com> <0c408230-61cc-4751-938a-06e715744c66@sirena.org.uk> <3ffcf6a0-e975-4eb4-9a4e-d6afb583e0b3@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <3ffcf6a0-e975-4eb4-9a4e-d6afb583e0b3@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDE5MiBTYWx0ZWRfX+QVJbTwqN1Pc jlez2l6WDtmFO75ZrcBbB8HjootvbOYJXAUjYxDYPcwdGnRJjSGCzA7okoPcXvHmuJ2iHvdExWW zslIbpO8jqjjcefQMpwqbSKf5+Aud+o15CUV5fNCSXbjA8ePFKPH9eQPi2YFlUwuyTXjjnHk4yX jgH8+6ayuC46uyhd3Xmd7y/2l89y6IX9bE2HhuHrQBRV+Q+UZxjhILkxGepIDHDqk7XKV3TKrWE 3rmzeaP56btcSsxz4WXLj2CS3e62VxEV+0mm6BIyanlAT0YxnQARZvLR1fgdUTcRpQE3E6s6eiG EPMLfZlblEX9DyHEcSdz11965dXTTuniFaJCTrWMB/PAFSqYRdD8BTKUW1x6CYOODDk48ATFzLw F4VxmWgQZIK+q0HqZab5Rml09Gd7OykDlvPnv4fAm3uBIpzMqb+ulj9N9Cw2czLmAR58ESKheC8 Hkgg4MzOve6OQmTsRdw== X-Proofpoint-ORIG-GUID: QxBR0r9f1pjSMOos2aZF2hOROh79u3cv X-Authority-Analysis: v=2.4 cv=d8fFDxjE c=1 sm=1 tr=0 ts=6a10ac32 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=dyxLLOf8pC0bdfPLpLFr6A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EXL2SugY_77LC3pzBmYA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: QxBR0r9f1pjSMOos2aZF2hOROh79u3cv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_05,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220192 On 5/22/2026 8:07 PM, Konrad Dybcio wrote: > On 5/22/26 3:17 PM, Mark Brown wrote: >> On Fri, May 22, 2026 at 06:34:40PM +0530, Ajay Kumar Nandam wrote: >> >>> The driver now relies on pm_clk helpers and runtime PM instead of >>> manually enabling and disabling macro, dcodec, mclk, npl, and fsgen >>> clocks. Runtime suspend and resume handling is delegated to the PM >>> core via pm_clk_suspend() and pm_clk_resume(), while existing runtime >>> PM callbacks continue to manage regcache state. >> >>> config SND_SOC_LPASS_WSA_MACRO >>> depends on COMMON_CLK >>> + depends on PM >>> select REGMAP_MMIO >>> select SND_SOC_LPASS_MACRO_COMMON >>> tristate "Qualcomm WSA Macro in LPASS(Low Power Audio SubSystem)" >> >> Shouldn't this be PM_CLK? That's what the APIs are actually conditional >> on, currently this will work out since PM_CLK depends on PM and HAVE_CLK >> but the indirection leaves a window for things to break in future. > > Yeah, leaving it as-is sounds like a bad idea ACK, will update in V6 Thanks Ajay Kumar > > Konrad