From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/amd: fix missing tag from dev_err message
Date: Tue, 03 Jul 2018 03:07:15 -0700 [thread overview]
Message-ID: <6763ec382f8d629f5f356f4cc023f20c2f76b26a.camel@perches.com> (raw)
In-Reply-To: <20180703064005.18908-1-colin.king@canonical.com>
On Tue, 2018-07-03 at 07:40 +0100, Colin King wrote:
> Currently tag is being assigned but not used, it is missing from
> the dev_err message, so add it in.
>
> Cleans up clang warning:
> warning: variable 'tag' set but not used [-Wunused-but-set-variable]
[]
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
[]
> @@ -616,9 +616,9 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt)
> pasid = ((event[0] >> 16) & 0xFFFF)
> | ((event[1] << 6) & 0xF0000);
> tag = event[1] & 0x03FF;
> - dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x]\n",
> + dev_err(dev, "INVALID_PPR_REQUEST device=%02x:%02x.%x pasid=0x%05x address=0x%016llx flags=0x%04x tag=0x%03x]\n",
> PCI_BUS_NUM(devid), PCI_SLOT(devid), PCI_FUNC(devid),
> - pasid, address, flags);
> + pasid, address, flags, tag);
Seems to have a superfluous ] that should be removed.
next prev parent reply other threads:[~2018-07-03 10:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 6:40 Colin King
2018-07-03 10:07 ` Joe Perches [this message]
2018-07-03 12:56 ` Gary R Hook
2018-07-03 15:55 ` Joe Perches
2018-07-03 16:21 ` Hook, Gary
2018-07-03 16:24 ` Colin Ian King
2018-07-03 16:27 ` Hook, Gary
2018-07-03 16:38 ` Joe Perches
2018-07-03 12:54 ` Gary R Hook
2018-07-03 16:57 Walter Harms
2018-07-03 17:34 ` Joe Perches
2018-07-06 13:00 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6763ec382f8d629f5f356f4cc023f20c2f76b26a.camel@perches.com \
--to=joe@perches.com \
--cc=colin.king@canonical.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®