From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FF343D6CC6; Mon, 6 Jul 2026 09:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783331438; cv=none; b=gBfUcnaXbT6n/pxW01g3ccjzi45KrNTPSOcdLQ3OAScHoeROMirvoGInSctbtk0vr1/TauR354kb3rsYEMwU0ESZ82L8U1dWOwIwRfWKxoI11wENKCr6IWOi7s0bhPRrPY166JaU1HzE4z5krQKjtzXyd5rW+6uag/ELpEGgg9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783331438; c=relaxed/simple; bh=tBi7rLdPR2mrwXg7OnTIdj1NAPgyZ3z9uxXjlCgi8E0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AM79iVyjL/AhoenMTR2iBQnEhh6bxdB9FAS6+RXcAyZnCCBs9BKNnELK8nyhUqKFMDgW57JUAPCuc8ZJsBkqHtMUQtJH+foPtCMlsjB81wjzxveXOxljCazrb4dcdC1hSFPOsOwNH+9bapA9i/eIIYeD2fqV4bQ62jYDO5JiU3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FWRXUOwp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FWRXUOwp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F07741F000E9; Mon, 6 Jul 2026 09:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783331433; bh=26afmC+0uDztCMWGBbLw38W2d/S18afQ32VhOWo1JuU=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=FWRXUOwpqML/DT11JKz2N5//x3ZZkARcxS34xp4O+CBxIg+LXDAkIY4H2/8iR/nLj HI/iaTqI9NUtinMndsxpxZY0NtwVxxsPwHW8hiRZNdNwrFUJHyQmuuJtrSk8TY4GCt 46EnhV/Wtq7UvN3dUVReFjXB7elMZA5wUn+7O0d+6VhFGNxvpLJ2gzt3Ztbi03pET7 yH8rY+Bp628wzK7rvEAQxxDlsjlNz66G8ngsYsOn0zHT0srMD7EycU7C6Egz5Id8yB BHPh+agRGzUPd0nDejFoKHC1esInfFrYeWkrTh+uZ8Q03RsPbSxs6IE5VJICngLa/s Bq+W2KEAD31Dw== Message-ID: <6766c138-90cd-4be2-80c1-0f5c144252ef@kernel.org> Date: Mon, 6 Jul 2026 10:50:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] misc: fastrpc: add missing MODULE_DEVICE_TABLE() To: Pengpeng Hou , Srinivas Kandagatla , Amol Maheshwari , Arnd Bergmann , Greg Kroah-Hartman Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260705001820.72397-1-pengpeng@iscas.ac.cn> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260705001820.72397-1-pengpeng@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/5/26 1:18 AM, Pengpeng Hou wrote: > The driver has a match table for the of bus wired into its driver > structure, but the table is not exported with MODULE_DEVICE_TABLE(). > > Add the missing MODULE_DEVICE_TABLE() entry so module alias information > is generated for automatic module loading. Are you fixing a real issue? Is this patch tested? > > This is a source-level fix. It does not claim dynamic hardware > reproduction; the evidence is the driver-owned match table, its use by > the driver registration structure, and the missing module alias > publication. > > Signed-off-by: Pengpeng Hou > --- > drivers/misc/fastrpc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index 47356a5d5804..0d2196b3f632 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -2265,6 +2265,7 @@ static const struct of_device_id fastrpc_match_table[] = { > { .compatible = "qcom,fastrpc-compute-cb", }, > {} > }; > +MODULE_DEVICE_TABLE(of, fastrpc_match_table); This is adding dead code, these devices are created dynamically by fastrpc driver and does not have a standalone driver. There is already a MODULE_DEVICE_TABLE for this driver. --srini > > static struct platform_driver fastrpc_cb_driver = { > .probe = fastrpc_cb_probe,