mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Kees Cook <keescook@chromium.org>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Dinh Nguyen <dinguyen@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH 2/2][next] clk: socfpga: agilex: Add bounds-checking coverage for struct stratix10_clock_data
Date: Wed, 11 Oct 2023 19:22:07 -0600	[thread overview]
Message-ID: <6779218a-3084-49fb-9f19-1c8d611c235c@embeddedor.com> (raw)
In-Reply-To: <202310111439.35CB04432F@keescook>




>> Hence, we need to move the assignments to `clk_data->clk_data.num` after
>> allocations for `struct stratix10_clock_data` and before accessing the
>> flexible array `clk_data->clk_data.hws`. And, as assignments for both
>> `clk_data->clk_data.num` and `clk_data->base` are originally adjacent to
>> each other, relocate both assignments together.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> 
> Yeah, ew. That's super tricky. Nice find.

Indeed. D:

> 
> Reviewed-by: Kees Cook <keescook@chromium.org>


Thanks!
--
Gustavo


      reply	other threads:[~2023-10-12  1:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 21:31 [PATCH 0/2][next] Fix undefined behavior bug and add bounds-checking coverage Gustavo A. R. Silva
2023-10-11 21:34 ` [PATCH 1/2][next] clk: socfpga: Fix undefined behavior bug in struct stratix10_clock_data Gustavo A. R. Silva
2023-10-11 21:38   ` Kees Cook
2023-10-12  1:22     ` Gustavo A. R. Silva
2023-10-11 21:35 ` [PATCH 2/2][next] clk: socfpga: agilex: Add bounds-checking coverage for " Gustavo A. R. Silva
2023-10-11 21:41   ` Kees Cook
2023-10-12  1:22     ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6779218a-3084-49fb-9f19-1c8d611c235c@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=dinguyen@kernel.org \
    --cc=gustavoars@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®