mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jose Abreu <jose.abreu@synopsys.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Joao Pinto <joao.pinto@synopsys.com>,
	"David S . Miller" <davem@davemloft.net>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH net-next v2 3/3] net: stmmac: dwxgmac2: Also use TBU interrupt to clean TX path
Date: Mon, 18 Feb 2019 13:51:54 +0000	[thread overview]
Message-ID: <677badce-d90b-82c5-0d11-88327d32a05b@synopsys.com> (raw)
In-Reply-To: <b338784c2af1aba885b6822d2ec614774f1f78dd.1550479678.git.joabreu@synopsys.com>

On 2/18/2019 8:49 AM, Jose Abreu wrote:
>  #define XGMAC_DMA_INT_DEFAULT_EN	(XGMAC_NIE | XGMAC_AIE | XGMAC_RBUE | \
> -					XGMAC_RIE | XGMAC_TIE)
> +					XGMAC_RIE | XGMAC_TBUE | XGMAC_TIE)

This is wrong and was a left-over from debug. Enabling this will
cause an high volume of interrupts which I just noticed.

We can only look at the status and not enable the int.

I will send v3 without this define change. Sorry.

Thanks,
Jose Miguel Abreu

      reply	other threads:[~2019-02-18 14:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-18  8:49 [PATCH net-next v2 0/3] net: stmmac: Performance improvements in Multi-Queue Jose Abreu
2019-02-18  8:49 ` [PATCH net-next v2 1/3] net: stmmac: Fix NAPI poll in TX path when in multi-queue Jose Abreu
2019-02-18  8:49 ` [PATCH net-next v2 2/3] net: stmmac: dwmac4: Also use TBU interrupt to clean TX path Jose Abreu
2019-02-18  8:49 ` [PATCH net-next v2 3/3] net: stmmac: dwxgmac2: " Jose Abreu
2019-02-18 13:51   ` Jose Abreu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=677badce-d90b-82c5-0d11-88327d32a05b@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=alexandre.torgue@st.com \
    --cc=davem@davemloft.net \
    --cc=joao.pinto@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®