From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC0FDC33CA9 for ; Tue, 14 Jan 2020 06:35:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9885020678 for ; Tue, 14 Jan 2020 06:35:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728708AbgANGfk (ORCPT ); Tue, 14 Jan 2020 01:35:40 -0500 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:56638 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbgANGfi (ORCPT ); Tue, 14 Jan 2020 01:35:38 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04446;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=38;SR=0;TI=SMTPD_---0TnhU9aL_1578983727; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TnhU9aL_1578983727) by smtp.aliyun-inc.com(127.0.0.1); Tue, 14 Jan 2020 14:35:28 +0800 Subject: Re: [PATCH v7 03/10] mm/lru: replace pgdat lru_lock with lruvec lock To: Daniel Jordan Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, yang.shi@linux.alibaba.com, willy@infradead.org, shakeelb@google.com, hannes@cmpxchg.org, Michal Hocko , Vladimir Davydov , Roman Gushchin , Chris Down , Thomas Gleixner , Vlastimil Babka , Qian Cai , Andrey Ryabinin , "Kirill A. Shutemov" , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrea Arcangeli , David Rientjes , "Aneesh Kumar K.V" , swkhack , "Potyra, Stefan" , Mike Rapoport , Stephen Rothwell , Colin Ian King , Jason Gunthorpe , Mauro Carvalho Chehab , Peng Fan , Nikolay Borisov , Ira Weiny , Kirill Tkhai , Yafang Shao References: <1577264666-246071-1-git-send-email-alex.shi@linux.alibaba.com> <1577264666-246071-4-git-send-email-alex.shi@linux.alibaba.com> <20200113154116.mwly5hl5yfvjkzl2@ca-dmjordan1.us.oracle.com> From: Alex Shi Message-ID: <677cb490-35a4-4186-0935-6d71305a3a3e@linux.alibaba.com> Date: Tue, 14 Jan 2020 14:33:58 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200113154116.mwly5hl5yfvjkzl2@ca-dmjordan1.us.oracle.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2020/1/13 ÏÂÎç11:41, Daniel Jordan дµÀ: > Hi Alex, > > On Wed, Dec 25, 2019 at 05:04:19PM +0800, Alex Shi wrote: >> @@ -900,6 +904,29 @@ static inline struct lruvec *mem_cgroup_page_lruvec(struct page *page, >> { >> return &pgdat->__lruvec; >> } >> +#define lock_page_lruvec_irq(page) \ >> +({ \ >> + struct pglist_data *pgdat = page_pgdat(page); \ >> + spin_lock_irq(&pgdat->__lruvec.lru_lock); \ >> + &pgdat->__lruvec; \ >> +}) >> + >> +#define lock_page_lruvec_irqsave(page, flagsp) \ >> +({ \ >> + struct pglist_data *pgdat = page_pgdat(page); \ >> + spin_lock_irqsave(&pgdat->__lruvec.lru_lock, *flagsp); \ >> + &pgdat->__lruvec; \ >> +}) >> + >> +#define unlock_page_lruvec_irq(lruvec) \ >> +({ \ >> + spin_unlock_irq(&lruvec->lru_lock); \ >> +}) >> + >> +#define unlock_page_lruvec_irqrestore(lruvec, flags) \ >> +({ \ >> + spin_unlock_irqrestore(&lruvec->lru_lock, flags); \ >> +}) > > Noticed this while testing your series. These are safe as inline functions, so > I think you may have gotten the wrong impression when Johannes made this point: > > https://lore.kernel.org/linux-mm/20191119164448.GA396644@cmpxchg.org/ > Thanks for reminder! Daniel! I write them to macro, since I guess it's more favorite for some guys. It's do a bit more neat than function although cost a bit readablity. Thanks a lot! :) Alex