From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 003EF152188 for ; Wed, 3 Apr 2024 17:09:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.134.164.104 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712164147; cv=none; b=VfKBIBUe+om38wKTzwmAne4FobAMx+r5p57jWZoAjVWQ0MUGuGMO/BI2TVJNZ12nQF/xdZBelw+m2cBnfjTJxhHDvvgz7TYM+lNImweXydd6mtxp2qdVnzJ5MJ8Sa4E4M0nJPictFXB7SaEyb5LTBfcYlK1P1TfmJZnR0i2bkKM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712164147; c=relaxed/simple; bh=lyLiABoT0znW9q0c9QeiPcjbxOtFrx1vbT+Bsk6RE60=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=G9zJcTw1H+/z/B4lRqUKVdOmRGpdDUysJuU9epDhKlQHyozdPXgWmqQmuBL1FWEiqYSEbqPxD6bGO6XBcgjgAlsVttRp6Eezvd2tgC5POJD7TlYN9vWtzs73Ch0wy/+MjYe8Bq9B89jTUkDNyYDxZcfcepVKUbrEJ5cSz8Tir64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr; spf=pass smtp.mailfrom=inria.fr; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b=U84infRz; arc=none smtp.client-ip=192.134.164.104 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=inria.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inria.fr Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=inria.fr header.i=@inria.fr header.b="U84infRz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=mEIX8zwty7dKxH47y6oy+4uKOjzsm9yaNYG6n9h1ZLg=; b=U84infRzHS1DjDGzDRS2ObN1S2w4N9gFilR5D+2jt9+fr3YzVRMxe8nk I4eiyL8K6H6A5PfAvZBSVs8YO1YZ8T2K5ATn7arthKRjI5egcvUZXFPPz MCdrTLxlXzuLUNf5YvZ1jJAZ7pmeCAJlo0XFkrQjrFH4kaokwj1uq7TQR I=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=julia.lawall@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.07,177,1708383600"; d="scan'208";a="83810300" Received: from 71-51-181-183.chvl.centurylink.net (HELO hadrien) ([71.51.181.183]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 19:09:03 +0200 Date: Wed, 3 Apr 2024 13:09:00 -0400 (EDT) From: Julia Lawall To: Mike Snitzer cc: Matthew Sakai , linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, dm-devel@list.linux.dev Subject: Re: drivers/md/dm-vdo/data-vio.c:969:2-8: preceding lock on line 966 (fwd) In-Reply-To: Message-ID: <677fa1fd-6f16-438e-2b95-8e81cabf4bf0@inria.fr> References: <801d737e-f7c0-b853-d7e-63eb68c7fd7b@inria.fr> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 3 Apr 2024, Mike Snitzer wrote: > On Wed, Apr 03 2024 at 12:47P -0400, > Julia Lawall wrote: > > > Hello, > > > > Please check whether the lock should be released before the returns. > > > > julia > > > > ---------- Forwarded message ---------- > > Date: Wed, 3 Apr 2024 22:16:44 +0800 > > From: kernel test robot > > To: oe-kbuild@lists.linux.dev > > Cc: lkp@intel.com, Julia Lawall > > Subject: drivers/md/dm-vdo/data-vio.c:969:2-8: preceding lock on line 966 > > > > BCC: lkp@intel.com > > CC: oe-kbuild-all@lists.linux.dev > > CC: linux-kernel@vger.kernel.org > > TO: Mike Snitzer > > CC: Matthew Sakai > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > head: 3e92c1e6cd876754b64d1998ec0a01800ed954a6 > > commit: f36b1d3ba533d21b5b793623f05761b0297d114e dm vdo: use a proper Makefile for dm-vdo > > date: 6 weeks ago > > :::::: branch date: 11 hours ago > > :::::: commit date: 6 weeks ago > > config: s390-randconfig-r052-20240403 (https://download.01.org/0day-ci/archive/20240403/202404032212.NV7EJ2Zj-lkp@intel.com/config) > > compiler: s390-linux-gcc (GCC) 13.2.0 > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Reported-by: Julia Lawall > > | Closes: https://lore.kernel.org/r/202404032212.NV7EJ2Zj-lkp@intel.com/ > > > > cocci warnings: (new ones prefixed by >>) > > >> drivers/md/dm-vdo/data-vio.c:969:2-8: preceding lock on line 966 > > drivers/md/dm-vdo/data-vio.c:972:2-8: preceding lock on line 966 > > > > vim +969 drivers/md/dm-vdo/data-vio.c > > > > 79535a7881c0cb Matthew Sakai 2023-11-16 952 > > 79535a7881c0cb Matthew Sakai 2023-11-16 953 /** > > 79535a7881c0cb Matthew Sakai 2023-11-16 954 * vdo_launch_bio() - Acquire a data_vio from the pool, assign the bio to it, and launch it. > > 79535a7881c0cb Matthew Sakai 2023-11-16 955 * > > 79535a7881c0cb Matthew Sakai 2023-11-16 956 * This will block if data_vios or discard permits are not available. > > 79535a7881c0cb Matthew Sakai 2023-11-16 957 */ > > 79535a7881c0cb Matthew Sakai 2023-11-16 958 void vdo_launch_bio(struct data_vio_pool *pool, struct bio *bio) > > 79535a7881c0cb Matthew Sakai 2023-11-16 959 { > > 79535a7881c0cb Matthew Sakai 2023-11-16 960 struct data_vio *data_vio; > > 79535a7881c0cb Matthew Sakai 2023-11-16 961 > > 79535a7881c0cb Matthew Sakai 2023-11-16 962 ASSERT_LOG_ONLY(!vdo_is_state_quiescent(&pool->state), > > 79535a7881c0cb Matthew Sakai 2023-11-16 963 "data_vio_pool not quiescent on acquire"); > > 79535a7881c0cb Matthew Sakai 2023-11-16 964 > > 79535a7881c0cb Matthew Sakai 2023-11-16 965 bio->bi_private = (void *) jiffies; > > 79535a7881c0cb Matthew Sakai 2023-11-16 @966 spin_lock(&pool->lock); > > 79535a7881c0cb Matthew Sakai 2023-11-16 967 if ((bio_op(bio) == REQ_OP_DISCARD) && > > 79535a7881c0cb Matthew Sakai 2023-11-16 968 !acquire_permit(&pool->discard_limiter, bio)) > > 79535a7881c0cb Matthew Sakai 2023-11-16 @969 return; > > 79535a7881c0cb Matthew Sakai 2023-11-16 970 > > 79535a7881c0cb Matthew Sakai 2023-11-16 971 if (!acquire_permit(&pool->limiter, bio)) > > 79535a7881c0cb Matthew Sakai 2023-11-16 972 return; > > 79535a7881c0cb Matthew Sakai 2023-11-16 973 > > 79535a7881c0cb Matthew Sakai 2023-11-16 974 data_vio = get_available_data_vio(pool); > > 79535a7881c0cb Matthew Sakai 2023-11-16 975 spin_unlock(&pool->lock); > > 79535a7881c0cb Matthew Sakai 2023-11-16 976 launch_bio(pool->completion.vdo, data_vio, bio); > > 79535a7881c0cb Matthew Sakai 2023-11-16 977 } > > 79535a7881c0cb Matthew Sakai 2023-11-16 978 > > > > :::::: The code at line 969 was first introduced by commit > > :::::: 79535a7881c0cbe95063a2670d840cc950ae9282 dm vdo: add data_vio, the request object which services incoming bios > > > > :::::: TO: Matthew Sakai > > :::::: CC: Mike Snitzer > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki > > > > Thanks for the report but this is reacting to older code. Changes were > made to address sparse's concerns about this same code, please see: > commit 872564c501b7 ("dm vdo data-vio: silence sparse warnings about > locking context imbalance"). > > If wait_permit()'s sparse __releases annotation is somehow > insufficient for silencing cocci please let me know. I don't think the Coccinelle rule checks the annotation. But the warning should not be negerated again. thanks, julia