From: Lars-Peter Clausen <lars@metafoo.de>
To: SIMRAN SINGHAL <singhalsimran0@gmail.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] staging: iio: accel: Move header file content to source file
Date: Tue, 28 Feb 2017 20:34:36 +0100 [thread overview]
Message-ID: <6780baa6-178a-111a-b6fb-30917beaa9dc@metafoo.de> (raw)
In-Reply-To: <CALrZqyNWFtPzorYN--eQHyhvaZqgR51xgqcwpio+ZM_vB+ccRw@mail.gmail.com>
On 02/28/2017 08:32 PM, SIMRAN SINGHAL wrote:
> On Wed, Mar 1, 2017 at 12:53 AM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 28/02/17 19:17, Jonathan Cameron wrote:
>>> On 28/02/17 18:51, simran singhal wrote:
>>>> The contents of the header file are used only by this single
>>>> source file. Move content into .c and remove .h.
>>>>
>>>> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
>>> Applied to the togreg branch of iio.git and pushed out as testing
>>> for the autobuilders to play with it.
>>>
>>> Thanks,
>>>
>>> Jonathan
>>
>> One quick note:
>>
>> The title should include the name of the driver being modified
>> as this is probably the bit interested people are most likely
>> to pick up on in a long list of patches.
>>
>> I fixed this up. Thanks,
>>
>> Jonathan
>
> I have included the name of driver being modified.
> Due to want me to include the name of file i.e adis16201_core.c
Not the full filename, but the partnumber. E.g.
'staging: iio: adis16201: ...'
next prev parent reply other threads:[~2017-02-28 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 18:51 simran singhal
2017-02-28 19:17 ` Jonathan Cameron
2017-02-28 19:23 ` Jonathan Cameron
2017-02-28 19:32 ` SIMRAN SINGHAL
2017-02-28 19:34 ` Lars-Peter Clausen [this message]
2017-02-28 19:37 ` SIMRAN SINGHAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6780baa6-178a-111a-b6fb-30917beaa9dc@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®