From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D597C43381 for ; Thu, 21 Feb 2019 11:18:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 380642086C for ; Thu, 21 Feb 2019 11:18:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727699AbfBULSS (ORCPT ); Thu, 21 Feb 2019 06:18:18 -0500 Received: from mga18.intel.com ([134.134.136.126]:43667 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727652AbfBULSS (ORCPT ); Thu, 21 Feb 2019 06:18:18 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Feb 2019 03:18:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,395,1544515200"; d="scan'208";a="135230374" Received: from linux.intel.com ([10.54.29.200]) by FMSMGA003.fm.intel.com with ESMTP; 21 Feb 2019 03:18:13 -0800 Received: from [10.125.252.152] (abudanko-mobl.ccr.corp.intel.com [10.125.252.152]) by linux.intel.com (Postfix) with ESMTP id 9F7E158028E; Thu, 21 Feb 2019 03:18:10 -0800 (PST) Subject: Re: [PATCH v2 3/4] perf record: enable runtime trace compression To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Namhyung Kim , Alexander Shishkin , Andi Kleen , linux-kernel References: <044ee2be-2e1d-e90f-7317-40083b5e716c@linux.intel.com> <5bc6958d-f4bc-d4ea-e5d0-16c5e7b73911@linux.intel.com> <20190212130856.GH775@krava> <20190221094333.GB10990@krava> From: Alexey Budankov Organization: Intel Corp. Message-ID: <6784b0c1-63b8-019b-9daa-3676f9283e52@linux.intel.com> Date: Thu, 21 Feb 2019 14:18:08 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190221094333.GB10990@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.02.2019 12:43, Jiri Olsa wrote: > On Wed, Feb 20, 2019 at 05:53:17PM +0300, Alexey Budankov wrote: >> >> On 12.02.2019 16:08, Jiri Olsa wrote: >>> On Mon, Feb 11, 2019 at 11:23:40PM +0300, Alexey Budankov wrote: >>> >>> SNIP >>> >>>> @@ -774,6 +775,8 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli >>>> struct perf_mmap *maps; >>>> int trace_fd = rec->data.file.fd; >>>> off_t off; >>>> + struct perf_session *session = rec->session; >>>> + perf_mmap__compress_fn_t compress_fn; >>>> >>>> if (!evlist) >>>> return 0; >>>> @@ -785,6 +788,9 @@ static int record__mmap_read_evlist(struct record *rec, struct perf_evlist *evli >>>> if (overwrite && evlist->bkw_mmap_state != BKW_MMAP_DATA_PENDING) >>>> return 0; >>>> >>>> + compress_fn = (record__comp_enabled(rec) ? >>>> + perf_session__zstd_compress : perf_session__zstd_copy); >>>> + >>> >>> I don't follow what's the perf_session__zstd_copy function for..? >> >> It bridges AIO without compression case. > > so current state then.. why do we need new function for that? This copy() function has the same signature as compress() so it can be used as the replacement in the _pack() call instead of memcpy() with different signature. Thanks, Alexey > > jirka