From: Kunwu Chan <chentao@kylinos.cn>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, mokuno@sm.sony.co.jp,
linville@tuxdriver.com, dcbw@redhat.com, jeff@garzik.org,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, kunwu.chan@hotmail.com
Subject: Re: [PATCH] treewide: Spelling fix in comment
Date: Mon, 23 Oct 2023 17:55:04 +0800 [thread overview]
Message-ID: <678a679a-eebf-46e4-b189-cecc7ced2a72@kylinos.cn> (raw)
In-Reply-To: <CAMuHMdUo8tEBQa6soZm=MUWLy2AnkL6Vszt7vzbs-peb20=myQ@mail.gmail.com>
Hi Geert,
Thank you very much for your advice, I am a rookie, I am not familiar
with many aspects, and I need to learn more. I'll modify the patch.
On 2023/10/20 19:07, Geert Uytterhoeven wrote:
> Hi Kunwu,
>
> Thanks for your patch!
>
> This is not a treewide change. Hence the oneline-summary should be
> something prefixed by "[net-next] ps3_gelic"
>
> On Fri, Oct 20, 2023 at 11:32 AM Kunwu Chan <chentao@kylinos.cn> wrote:
>> reques -> request
>>
>> Fixes: 09dde54c6a69 ("PS3: gelic: Add wireless support for PS3")
>
> No need for a Fixes tag for a spelling fix in a comment.
>
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> --- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
>> +++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
>> @@ -1217,7 +1217,7 @@ static int gelic_wl_set_encodeext(struct net_device *netdev,
>> key_index = wl->current_key;
>>
>> if (!enc->length && (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY)) {
>> - /* reques to change default key index */
>> + /* request to change default key index */
>> pr_debug("%s: request to change default key to %d\n",
>> __func__, key_index);
>> wl->current_key = key_index;
>
> Gr{oetje,eeting}s,
>
> Geert
>
next prev parent reply other threads:[~2023-10-23 9:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 9:31 Kunwu Chan
2023-10-20 11:07 ` Geert Uytterhoeven
2023-10-23 9:55 ` Kunwu Chan [this message]
2023-10-23 9:55 ` [PATCH v2] " Kunwu Chan
2023-10-21 0:03 ` [PATCH] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=678a679a-eebf-46e4-b189-cecc7ced2a72@kylinos.cn \
--to=chentao@kylinos.cn \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=jeff@garzik.org \
--cc=kuba@kernel.org \
--cc=kunwu.chan@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linville@tuxdriver.com \
--cc=mokuno@sm.sony.co.jp \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®