From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7DD2C43441 for ; Tue, 13 Nov 2018 05:32:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7985522507 for ; Tue, 13 Nov 2018 05:32:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7985522507 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730656AbeKMP2j (ORCPT ); Tue, 13 Nov 2018 10:28:39 -0500 Received: from smtprelay0090.hostedemail.com ([216.40.44.90]:48502 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726217AbeKMP2j (ORCPT ); Tue, 13 Nov 2018 10:28:39 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id 30588182CF668; Tue, 13 Nov 2018 05:32:14 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: beds12_10e8887c7f730 X-Filterd-Recvd-Size: 3646 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Tue, 13 Nov 2018 05:31:56 +0000 (UTC) Message-ID: <678d66cc417323f248f721cc8e4d271fe8ac80fb.camel@perches.com> Subject: Re: [PATCH] xfs: Remove noinline from #define STATIC From: Joe Perches To: Dave Chinner Cc: "Theodore Y. Ts'o" , Eric Sandeen , "Darrick J. Wong" , Christoph Hellwig , linux-xfs@vger.kernel.org, LKML Date: Mon, 12 Nov 2018 21:31:51 -0800 In-Reply-To: <20181113052651.GR19305@dastard> References: <7302f4a13c1cbf62b07f636878ce25fcca84b6c4.camel@perches.com> <6420cf91-89c8-a876-7a0d-25ab8ba428b8@sandeen.net> <20181112214515.GN19305@dastard> <20181113011804.GP19305@dastard> <20181113015410.GB30750@thunk.org> <20181113030926.GQ19305@dastard> <20181113052651.GR19305@dastard> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-11-13 at 16:26 +1100, Dave Chinner wrote: > On Mon, Nov 12, 2018 at 08:23:42PM -0800, Joe Perches wrote: > > On Tue, 2018-11-13 at 14:09 +1100, Dave Chinner wrote: > > > On Mon, Nov 12, 2018 at 08:54:10PM -0500, Theodore Y. Ts'o wrote: > > > > On Tue, Nov 13, 2018 at 12:18:05PM +1100, Dave Chinner wrote: > > > > > I'm not interested in making code fast if distro support engineers > > > > > can't debug problems on user systems easily. Optimising for > > > > > performance over debuggability is a horrible trade off for us to > > > > > make because it means users and distros end up much more reliant on > > > > > single points of expertise for debugging problems. And that means > > > > > the majority of the load of problem triage falls directly on very > > > > > limited resources - the core XFS development team. A little bit of > > > > > thought about how to make code easier to triage and debug goes a > > > > > long, long way.... > > > > > > > > So at least in my experience, if the kernels are compiled with > > > > CONFIG_DEBUG_INFO and/or CONFIG_DEBUG_INFO_REDUCED, > > > > scripts/decode_stracktrace.sh seems to do a very nice job with inlined > > > > > > That doesn't help with kernel profiling and other such things that > > > are based on callgraphs... > > > > If that's really the case: > > > > I rather suspect the xfs static v STATIC function marking is not > > particularly curated and the marking is somewhat arbitrary. > > That's a common opinion for an outsider to form when they come > across something unfamiliar they don't really understand. "I don't > understand this, so I must rewrite it" is an unfortunate habit that > programmers have. Silly. > > So perhaps given the large number of static, but not STATIC > > functions, perhaps a sed of s/static/STATIC/ should be done > > when it's not inline for all xfs functions. > > That's just as bad as removing them all, if not worse. Why? > If you are writing new code or reworking existing code, then we'll > consider the usage of STATIC/static in the context of that work. > Otherwise, we leave it alone. If your statement is as described above, and the STATIC use to enable call stack tracing i useful, why shouldn't it be systemic? > It if ain't broke, don't fix it. A generically lazy statement.