Re: [PATCH 2/2] arm64: dts: qcom: lemans-evk: Enable the tertiary USB controller

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 2/6/26 11:46 AM, Swati Agarwal wrote:
> Enable the tertiary usb controller connected to micro usb port in OTG mode
> on Lemans EVK platform.
> 
> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
> ---

[...]

> +	vbus_supply_regulator_2: vbus-supply-regulator_2 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vbus_supply_2";
> +		gpio = <&pmm8654au_1_gpios 9 GPIO_ACTIVE_HIGH>;
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		regulator-boot-on;

Are you sure it's boot-on? vbus_supply_regulator_0 isn't marked as such,
or maybe is that one wrong?


[...]

> diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
> index 808827b83553..2710927c9172 100644
> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
> @@ -4270,7 +4270,14 @@ usb_2: usb@a400000 {
>  			snps,dis-u1-entry-quirk;
>  			snps,dis-u2-entry-quirk;
>  
> +			usb-role-switch;
>  			status = "disabled";

Please leave a \n above 'status'

Konrad