From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D92B214814 for ; Wed, 22 Jan 2025 17:04:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737565463; cv=none; b=ssoWCgqQLVz1p8cYpkMSy1j9ErkX+DyPq812ziaAc2H9sDNPCJIChD5OlAskMUX/5ij8++VcQhpa8qtg2SldLvBkZFKfC2V00Wk/DEBNlPF3Ofyfql8Y6n3qjBjtiXCcfjRuFBFbogErODjgYqkj9cBSzrJQIS2gmrkGo0c/oXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737565463; c=relaxed/simple; bh=Mf4r+gYMvANtW4KB8mNxv1/QvGZXcr0cxMqJQxgGcx4=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=SAbqli15Iy49skPUQ5T5nOw8fkqDAGGbGuDx/NcCsTd3Z33ujtimhdQ/UJQxAYoS9i8T1lV2Df2+etvh0T4q7ge1UdjQF9pIdtbsaZbBYr8YJkH0T3/KC1jrXEEDkMutVuPSFqhfqde7+CWhImT8xkjKRm8ONkqQTkk1CDrbQx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-3cfb20d74b5so8848235ab.3 for ; Wed, 22 Jan 2025 09:04:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737565461; x=1738170261; h=content-transfer-encoding:to:from:subject:message-id:in-reply-to :date:mime-version:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3q/nAM7rAqvLTwRvsO6ccwnw5AjtiRGY6KQ17jjceD8=; b=Iy/mC26U4uwa4pEK/SeX9zDgLNcQCRQsV/ICEPHS1sM/5o6yB5bBIghTNxv37l9JQr nA7Z+knpIxu0AZBbyNOnKpNjodtjt8MqsQHew0dDB14byTNcS2Ipbusr4Fbn5t65P0GH 9WaVBQxF8Qf98kEuSbP77/ErxJ4bu1EF9aLClY8YO0caRsNNMlurrk1VIUDHtV1gfuku x1oYnT8RAYeg5rSuYXCngLvhdlGl1AWKWeDIJfgA1TmZTOojYpfCDEyxvyZEKKuJFX9Z Ag3/XQfcDGpRCx7FsQruzHw+p3dy9SbyBJBBeABYOVybMQPcBLiUnPZoOPHWdQbL8Fur d8lA== X-Gm-Message-State: AOJu0Yx7fBInV61VIsEdneaaN4XknojKiU/v4AL5HS4Ko2xJlQJWiBO6 Ec3rke3QB9fSjKQqNqq2KgBe6qRRsuGICvmHB2/EtE9L4gdid5ihf3XHN8KowBmscX3bNrILy1+ IukG+MWioYA4gsWuF7qsCvZe6xfmu3wIc9RxuXg4p5pYQvKEsYe2sG/E= X-Google-Smtp-Source: AGHT+IG6QsVvM5ChBbK5zEqX9K6Kgs6ZRX8lVsh/njNWic8yXQczU5txJv6qon4qu8eJTZXhEtAOnEPvYMKRMRaBcJad4jipqTbe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6e02:4409:b0:3cf:ad21:b7d7 with SMTP id e9e14a558f8ab-3cfad21ba46mr51282785ab.9.1737565460597; Wed, 22 Jan 2025 09:04:20 -0800 (PST) Date: Wed, 22 Jan 2025 09:04:20 -0800 In-Reply-To: <00000000000070784806124596ec@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <67912514.050a0220.194594.0017.GAE@google.com> Subject: Re: [syzbot] Re: [PATCH v4] Bluetooth: L2CAP: Fix slab-use-after-free Read in l2cap_send_cmd From: syzbot To: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable For archival purposes, forwarding an incoming command email to linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com. *** Subject: Re: [PATCH v4] Bluetooth: L2CAP: Fix slab-use-after-free Read in l= 2cap_send_cmd Author: luiz.dentz@gmail.com #syz test On Tue, Jan 21, 2025 at 1:08=E2=80=AFPM Luiz Augusto von Dentz wrote: > > #syz test > > On Fri, Jan 17, 2025 at 3:48=E2=80=AFPM Luiz Augusto von Dentz > wrote: > > > > #syz test > > > > On Fri, Jan 17, 2025 at 1:42=E2=80=AFPM Luiz Augusto von Dentz > > wrote: > > > > > > From: Luiz Augusto von Dentz > > > > > > After the hci sync command releases l2cap_conn, the hci receive data = work > > > queue references the released l2cap_conn when sending to the upper la= yer. > > > Add hci dev lock to the hci receive data work queue to synchronize th= e two. > > > > > > [1] > > > BUG: KASAN: slab-use-after-free in l2cap_send_cmd+0x187/0x8d0 net/blu= etooth/l2cap_core.c:954 > > > Read of size 8 at addr ffff8880271a4000 by task kworker/u9:2/5837 > > > > > > CPU: 0 UID: 0 PID: 5837 Comm: kworker/u9:2 Not tainted 6.13.0-rc5-syz= kaller-00163-gab75170520d4 #0 > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BI= OS Google 09/13/2024 > > > Workqueue: hci1 hci_rx_work > > > Call Trace: > > > > > > __dump_stack lib/dump_stack.c:94 [inline] > > > dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 > > > print_address_description mm/kasan/report.c:378 [inline] > > > print_report+0x169/0x550 mm/kasan/report.c:489 > > > kasan_report+0x143/0x180 mm/kasan/report.c:602 > > > l2cap_build_cmd net/bluetooth/l2cap_core.c:2964 [inline] > > > l2cap_send_cmd+0x187/0x8d0 net/bluetooth/l2cap_core.c:954 > > > l2cap_sig_send_rej net/bluetooth/l2cap_core.c:5502 [inline] > > > l2cap_sig_channel net/bluetooth/l2cap_core.c:5538 [inline] > > > l2cap_recv_frame+0x221f/0x10db0 net/bluetooth/l2cap_core.c:6817 > > > hci_acldata_packet net/bluetooth/hci_core.c:3797 [inline] > > > hci_rx_work+0x508/0xdb0 net/bluetooth/hci_core.c:4040 > > > process_one_work kernel/workqueue.c:3229 [inline] > > > process_scheduled_works+0xa66/0x1840 kernel/workqueue.c:3310 > > > worker_thread+0x870/0xd30 kernel/workqueue.c:3391 > > > kthread+0x2f0/0x390 kernel/kthread.c:389 > > > ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 > > > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 > > > > > > > > > Allocated by task 5837: > > > kasan_save_stack mm/kasan/common.c:47 [inline] > > > kasan_save_track+0x3f/0x80 mm/kasan/common.c:68 > > > poison_kmalloc_redzone mm/kasan/common.c:377 [inline] > > > __kasan_kmalloc+0x98/0xb0 mm/kasan/common.c:394 > > > kasan_kmalloc include/linux/kasan.h:260 [inline] > > > __kmalloc_cache_noprof+0x243/0x390 mm/slub.c:4329 > > > kmalloc_noprof include/linux/slab.h:901 [inline] > > > kzalloc_noprof include/linux/slab.h:1037 [inline] > > > l2cap_conn_add+0xa9/0x8e0 net/bluetooth/l2cap_core.c:6860 > > > l2cap_connect_cfm+0x115/0x1090 net/bluetooth/l2cap_core.c:7239 > > > hci_connect_cfm include/net/bluetooth/hci_core.h:2057 [inline] > > > hci_remote_features_evt+0x68e/0xac0 net/bluetooth/hci_event.c:3726 > > > hci_event_func net/bluetooth/hci_event.c:7473 [inline] > > > hci_event_packet+0xac2/0x1540 net/bluetooth/hci_event.c:7525 > > > hci_rx_work+0x3f3/0xdb0 net/bluetooth/hci_core.c:4035 > > > process_one_work kernel/workqueue.c:3229 [inline] > > > process_scheduled_works+0xa66/0x1840 kernel/workqueue.c:3310 > > > worker_thread+0x870/0xd30 kernel/workqueue.c:3391 > > > kthread+0x2f0/0x390 kernel/kthread.c:389 > > > ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 > > > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 > > > > > > Freed by task 54: > > > kasan_save_stack mm/kasan/common.c:47 [inline] > > > kasan_save_track+0x3f/0x80 mm/kasan/common.c:68 > > > kasan_save_free_info+0x40/0x50 mm/kasan/generic.c:582 > > > poison_slab_object mm/kasan/common.c:247 [inline] > > > __kasan_slab_free+0x59/0x70 mm/kasan/common.c:264 > > > kasan_slab_free include/linux/kasan.h:233 [inline] > > > slab_free_hook mm/slub.c:2353 [inline] > > > slab_free mm/slub.c:4613 [inline] > > > kfree+0x196/0x430 mm/slub.c:4761 > > > l2cap_connect_cfm+0xcc/0x1090 net/bluetooth/l2cap_core.c:7235 > > > hci_connect_cfm include/net/bluetooth/hci_core.h:2057 [inline] > > > hci_conn_failed+0x287/0x400 net/bluetooth/hci_conn.c:1266 > > > hci_abort_conn_sync+0x56c/0x11f0 net/bluetooth/hci_sync.c:5603 > > > hci_cmd_sync_work+0x22b/0x400 net/bluetooth/hci_sync.c:332 > > > process_one_work kernel/workqueue.c:3229 [inline] > > > process_scheduled_works+0xa66/0x1840 kernel/workqueue.c:3310 > > > worker_thread+0x870/0xd30 kernel/workqueue.c:3391 > > > kthread+0x2f0/0x390 kernel/kthread.c:389 > > > ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 > > > ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 > > > > > > Reported-by: syzbot+31c2f641b850a348a734@syzkaller.appspotmail.com > > > Closes: https://syzkaller.appspot.com/bug?extid=3D31c2f641b850a348a73= 4 > > > Tested-by: syzbot+31c2f641b850a348a734@syzkaller.appspotmail.com > > > Signed-off-by: Edward Adam Davis > > > Signed-off-by: Luiz Augusto von Dentz > > > --- > > > net/bluetooth/l2cap_core.c | 45 ++++++++++++++++++++++++++++++++++--= -- > > > 1 file changed, 41 insertions(+), 4 deletions(-) > > > > > > diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c > > > index 27b4c4a2ba1f..cc730135e5d9 100644 > > > --- a/net/bluetooth/l2cap_core.c > > > +++ b/net/bluetooth/l2cap_core.c > > > @@ -951,11 +951,18 @@ static u8 l2cap_get_ident(struct l2cap_conn *co= nn) > > > static void l2cap_send_cmd(struct l2cap_conn *conn, u8 ident, u8 cod= e, u16 len, > > > void *data) > > > { > > > - struct sk_buff *skb =3D l2cap_build_cmd(conn, code, ident, le= n, data); > > > + struct sk_buff *skb; > > > u8 flags; > > > > > > + /* Check if hchan has been dropped since it means hci_chan_de= l has > > > + * been called. > > > + */ > > > + if (!conn->hchan) > > > + return; > > > + > > > BT_DBG("code 0x%2.2x", code); > > > > > > + skb =3D l2cap_build_cmd(conn, code, ident, len, data); > > > if (!skb) > > > return; > > > > > > @@ -1751,12 +1758,16 @@ static void l2cap_conn_del(struct hci_conn *h= con, int err) > > > { > > > struct l2cap_conn *conn =3D hcon->l2cap_data; > > > struct l2cap_chan *chan, *l; > > > + struct hci_chan *hchan; > > > > > > if (!conn) > > > return; > > > > > > BT_DBG("hcon %p conn %p, err %d", hcon, conn, err); > > > > > > + hchan =3D conn->hchan; > > > + conn->hchan =3D NULL; > > > + > > > kfree_skb(conn->rx_skb); > > > > > > skb_queue_purge(&conn->pending_rx); > > > @@ -1792,13 +1803,12 @@ static void l2cap_conn_del(struct hci_conn *h= con, int err) > > > > > > mutex_unlock(&conn->chan_lock); > > > > > > - hci_chan_del(conn->hchan); > > > + hci_chan_del(hchan); > > > > > > if (conn->info_state & L2CAP_INFO_FEAT_MASK_REQ_SENT) > > > cancel_delayed_work_sync(&conn->info_timer); > > > > > > hcon->l2cap_data =3D NULL; > > > - conn->hchan =3D NULL; > > > l2cap_conn_put(conn); > > > } > > > > > > @@ -6785,6 +6795,12 @@ static void l2cap_recv_frame(struct l2cap_conn= *conn, struct sk_buff *skb) > > > u16 cid, len; > > > __le16 psm; > > > > > > + /* Check if hchan has been dropped then drop any packets as w= ell */ > > > + if (!conn->hchan) { > > > + kfree_skb(skb); > > > + return; > > > + } > > > + > > > if (hcon->state !=3D BT_CONNECTED) { > > > BT_DBG("queueing pending rx skb"); > > > skb_queue_tail(&conn->pending_rx, skb); > > > @@ -7466,14 +7482,33 @@ static void l2cap_recv_reset(struct l2cap_con= n *conn) > > > conn->rx_len =3D 0; > > > } > > > > > > +static struct l2cap_conn *l2cap_conn_hold_unless_zero(struct l2cap_c= onn *c) > > > +{ > > > + BT_DBG("conn %p orig refcnt %u", c, kref_read(&c->ref)); > > > + > > > + if (!kref_get_unless_zero(&c->ref)) > > > + return NULL; > > > + > > > + return c; > > > +} > > > + > > > void l2cap_recv_acldata(struct hci_conn *hcon, struct sk_buff *skb, = u16 flags) > > > { > > > - struct l2cap_conn *conn =3D hcon->l2cap_data; > > > + struct l2cap_conn *conn; > > > int len; > > > > > > + /* Lock hdev to access l2cap_data to avoid race with l2cap_co= nn_del */ > > > + hci_dev_lock(hcon->hdev); > > > + > > > + conn =3D hcon->l2cap_data; > > > + > > > if (!conn) > > > conn =3D l2cap_conn_add(hcon); > > > > > > + conn =3D l2cap_conn_hold_unless_zero(conn); > > > + > > > + hci_dev_unlock(hcon->hdev); > > > + > > > if (!conn) > > > goto drop; > > > > > > @@ -7565,6 +7600,8 @@ void l2cap_recv_acldata(struct hci_conn *hcon, = struct sk_buff *skb, u16 flags) > > > break; > > > } > > > > > > + l2cap_conn_put(conn); > > > + > > > drop: > > > kfree_skb(skb); > > > } > > > -- > > > 2.47.1 > > > > > > > > > -- > > Luiz Augusto von Dentz > > > > -- > Luiz Augusto von Dentz --=20 Luiz Augusto von Dentz