From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F598C433EF for ; Sun, 3 Jul 2022 10:47:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232385AbiGCKro (ORCPT ); Sun, 3 Jul 2022 06:47:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232373AbiGCKrb (ORCPT ); Sun, 3 Jul 2022 06:47:31 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBA986431; Sun, 3 Jul 2022 03:47:22 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id z41so8265369ede.1; Sun, 03 Jul 2022 03:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-transfer-encoding:user-agent:mime-version; bh=xtZe00jcrHCWayegr58xFfUp2h3js8Bof36AjGw58FU=; b=LHTZ6sd9Ylw0mhtbQPt/yWf3J9vu7LgLvrQ2hPvUPpfNDO/Mv4xdqmhAlOM4oVSz9+ yP+pH7VDq5J0bfVfFX/4ofM9et9VoauQO6/67ZpO5wlZ7/nxqo8QY/sZW9qbGIMFESzJ y2GhjpLU1+yjhJ3o7oruqb/tO9oUHnpq3BD1WJwxTuMrbGBwkysz2KQxInZkjmd2+HKo 9hnAbYIlJrkOlO7IkbhGKjceeqBoVi9MdS994NI3MopaLTCo2YpYK4VAArGhkCsc/AN0 scmcnr6I9vskBSXS5H3VqnLI42uKWD0fhbgUMkZD+dkgc7swGyy/1Rn/cwisYL3CB/z3 es1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=xtZe00jcrHCWayegr58xFfUp2h3js8Bof36AjGw58FU=; b=uhnbO9nDdzmNSYNLVjvQZZnuj4lUUgGNwBnMG0yWpiia69iBsr3Sl9RYWh4S0L07g7 kHSDuCEHQcMapo026/pSsB3JaqAAhnmK/OhE4ZbzieSiRJGBjfZ36oaQhLfXNSvz7EpG 0+BK4nI2o32g2zYHOZc2ZakMfQNZBqvzYjWI8wq1rC9FiS1GttOnRkObVa2LxQEfc/7H uo44e0LUOMsZnIp0xtHcET4X2XrYWCQ9trmRD6RFn7gcEx8xw+vTP1fZa44GkLwpoPNP N5xebckXdwu1JHgwbDJNwG/ADHg28x2aGA7qwgfTtxm5wr1B31q2NCxJya4wgRV++3zc 9XKA== X-Gm-Message-State: AJIora+xFTipZ1fIVoKI5sW4CPJyhXq0jaifjL7t5YvXcVcprnQy9Sjx Tf4w8p2nfSrgiwPPU5PUGuTkruDeAtQpOA== X-Google-Smtp-Source: AGRyM1tGVPJyIq3szdnRuDtIIMLXe+/hYDrptJIGBirIXbjThF7HJVmbD5r7tXNhzxzCPtbySChhdA== X-Received: by 2002:a05:6402:1e88:b0:435:bf05:f0f with SMTP id f8-20020a0564021e8800b00435bf050f0fmr31256381edf.2.1656845241327; Sun, 03 Jul 2022 03:47:21 -0700 (PDT) Received: from ?IPv6:2a02:ab88:368f:2080:5d6e:322:57b6:5f03? ([2a02:ab88:368f:2080:5d6e:322:57b6:5f03]) by smtp.gmail.com with ESMTPSA id kw24-20020a170907771800b0072a3216c23asm5791972ejc.154.2022.07.03.03.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Jul 2022 03:47:20 -0700 (PDT) Message-ID: <67943ec4dcfe85d6d616a5507437d99f6c5638a2.camel@gmail.com> Subject: Re: [PATCH 0/4] iommu/exynos: Add basic support for SysMMU v7 From: David Virag To: Sam Protsenko , Marek Szyprowski Cc: Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Janghyuck Kim , Cho KyongHo , Daniel Mentz , Sumit Semwal , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 03 Jul 2022 14:47:20 +0200 In-Reply-To: References: <20220702213724.3949-1-semen.protsenko@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2022-07-03 at 00:48 +0300, Sam Protsenko wrote: [...] > Hi Marek, >=20 > As I understand, you have some board with SysMMU v7, which is not VM > capable (judging from the patches you shared earlier). Could you > please somehow verify if this series works fine for you? For example, > this testing driver [1] can be helpful. >=20 > Thanks! >=20 > [1] > https://github.com/joe-skb7/linux/commit/bbadd46fa525fe1fef2ccbdfff81f7d2= 9caf0506 Hi Sam, Not Marek here, but I wanted to try this on my jackpotlte (Exynos 7885). The driver reports it's DPU sysmmu as version 7.2, and manually reading the capabilities registers it looks like it has the 2nd capability register but not the VM capability. After applying your patches, adding your test driver (with SYSMMU_BASE corrected to 7885 value), and adding the sysmmu to dt, I tried to cat the test file that it creates in debugfs and I got an SError kernel panic. I tried tracing where the SError happens and it looks like it's this line: /* Preload for emulation */ iowrite32(rw | vpn, obj->reg_base + MMU_EMU_PRELOAD); Trying to read the EMU registers using devmem results in a "Bus error". Could these emulation registers be missing from my SysMMU? Do you have any info on what version should have it? Or maybe some capability bit? I'll try testing it with DECON/DPP later and see if it works that way. Best regards, David