From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793870823; b=LdujH6p6RFVtz6xZpKy0G5ngvTbM0qdITotwNgEFvzzy/ChBR/r50s6P5OxhRS3BMvtE vjlyb9bwTC643frEhUxa176TLD63SQWXjgEdEU5BaOe9Q+OWSrc2sniNmD/wabPOH1tLR NMNeI9iraWMpE8uMF/KG3FIQNKGmoH9V+mrvNCtYE2DEdXKpsSAmu9K4IGtIUSpUIXDo3 GTS7+y7e3qymher5A1pvDAYdVrEMdxrJdc7gm+PuBYsnzsItB7HzA9ZcbriWsrarETDy/ 39W7PkR68kjaIEfQXeSD4cJDB4Ie+SH5q7Na37eYpw/rFFhHNf36nIZsZo+KUy1naNQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793870823; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:Message-ID:Date:MIME-Version:User-Agent:Subject: To:Cc:References:Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=xZzKTf//DQYIAN9VwQEvMddExwcCW3dbdXpAj0Adyw8=; b=d5h5tQVBWR2pM30TIXrbH5l9n/dLN/g6lmNnNmUrk3PxNvERTKp5G2zlfV65TvOqWPOY RUWBNvC8ATi/AyI6UKcRmwd/gQ2VO3w9EjvsGHQn6ypS+AW9KMTKEpiUcX22/Pj+3QIaA K9vLxGbWhWQ/ap0GkatR5V2hv5eXdSX3HcCQSt2CUYqk3MXIIplkneLxI062vEeI0SB+R 4+CYATsxhZZtMI8Fdvv6ygIPWPYadwp8TudAWd+AWbsmns9zxkDotQfvymM3TvgjUbyAz DzSpzctZnwiLWD8d+1za0xqylHKpzDyDMotet4dPy9qOYRsBD7aAmAfxOp304YKZUlA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=b2pKC2Ub; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=fHaYctB5; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82686606A326 for ; Thu, 5 Nov 2026 09:27:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 82686606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=b2pKC2Ub; dkim=pass (2048-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=fHaYctB5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793870821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xZzKTf//DQYIAN9VwQEvMddExwcCW3dbdXpAj0Adyw8=; b=b2pKC2UbTlalxXeMydjDn4mD7Db7+cdC3bcjvHaiN4yUZZeoGNz/nLfZIn68iq+SSayXCB bP7ZSWCLCNWLJj+kBNimNPdwjzhXdSGKv4V3dvcg3NkDwBm349HGLonEt2FotdfA+5R5D0 8bhGcr9YlrRqOQFka+6y2mSBbERyX/E= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-CuGJ-aX_MqWw4hoZI-V87A-1; Thu, 05 Nov 2026 04:27:00 -0500 X-MC-Unique: CuGJ-aX_MqWw4hoZI-V87A-1 X-Mimecast-MFC-AGG-ID: CuGJ-aX_MqWw4hoZI-V87A_1793870819 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-48e011829easo1016871f8f.3 for ; Thu, 05 Nov 2026 01:27:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1793870819; x=1794475619; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xZzKTf//DQYIAN9VwQEvMddExwcCW3dbdXpAj0Adyw8=; b=fHaYctB5SIwZSj1A3PKQanr9lALpXaILeX/6MjjI404AhOp13dWh1YQif8a1iYbuCt ySunMulrJl/RQRuXZoJWi+csEThcA2w2sRxnSkJzuObKEInFuGhts1j6u7KEZQjwc0nS iekFHHKNsR9BkG4iI+l6Vs5vQzhdorWMsTZvlGtctQFlRAM3MszCGmgZSA2fYamYGTOD bXNig0r2OmPE/0OQJonuA+vmZW2eLXVzEqxcBr06yPf97SsoJbRqk+dHXywiDsC3i572 b9Wd9BRij5gaYN3Wo/u6N8QsdgxHve0jrvQQU+BC7hNliMTmlXMXCUUnkSoc55E9Sbdr Cy/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793870819; x=1794475619; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xZzKTf//DQYIAN9VwQEvMddExwcCW3dbdXpAj0Adyw8=; b=vPcnC1iBobTrxc1RXcxuF6xGfAIyd/7mztQ7X4BvHx5MCZA+XxXbOuiQZh4mmRpNQv zuk3g27l6gqyv0Llqcl68l1T2U9Lli6YwBd2xp81cVSV/5skjAIxdCnE1DAwG4b5Ab6e t73DNY9FK4cKynYCfwnAHW3hOg+zvI96L3A1R6SXrx3n2L0NZKRsiU3rgWFp1vsiy/oU iOLeHp9wWFkZTwbZ5XwZBPUxFO1NeupOELUsSpnzQCNggIojAcROiQ1GZnArnP3WhYPU Py8svDmkYtccsopCf6VlV3z4EKxOF3fp5S7HwhOeywziKyW6iLJmbL4ILQmfhWZiQ732 YucA== X-Forwarded-Encrypted: i=1; AKwUvBxrWYcqtEXFlQxo8MbT3VFIkcoPgL1qdjB/R5TAS2keTH5W3V8z2DEb5ewhsoO0cQ1ULj20aziFPCO4R4A=@vger.kernel.org X-Gm-Message-State: APuU4Z8uYt/B+21eiCY9KSFYXeK9/+zMGMrJ/IeIqo/Ui8Txm+Mzgzac Sksat/tRRYcKV+AkwC7uOw8jT+zHDKSrIHeyBwez4DlSqxHv2/oMyXFGnLcI76MXOkqFPjkdVbT 90IpGD8xNdUe5gqhXpAPPUH8T4Fqq+5KZp0pqORgRXQRPh6W/rBfkOjSKUbHCH4+UGw== X-Gm-Gg: AYBFou0bqfTEb4qeVqPP/S8jHtvX/FqaPklLRo0YUtMfICqN/yWd4XwJbd92kv3AQrF 84P30D4I/zAHEhzRHURmFfpSTr47CpciS9fv43SlRJ1ZRi/p5Uqg+gehI4Pr4G3g5VPPRCZ0yXR gMEQdCbxBOlzy5Ij6dDO7nOiOtYhzUoInu9QIB5IYfHo7SwoYHRfqoCHM5Un9cdKQnrZRz59cXJ nyYRsub2lqv5p+rtTJet9P7HspYRQcN/RN3/yYSLOozr3j5Fr8taKCkkLjkuEb2ELgPDwJ2YpgY JLTbkBU99CVlNlMCgSykfEUjWqoOo9BNSgTVJLF7c+8f0Dq0fSjVxrIWGCBol1yxQYGwKv2Q3Pk B6P78G7ezGAgEpks6dyhKn7ZYVBJw4ESADZdZB54IxkOZrw6HMz8LI8NX1HiKmpqptgaFW54Szy XEo+79YrRQxdo/hyh2RG689T5qils2b6Gwus2Bx9/FKzc= X-Received: by 2002:a5d:64e7:0:b0:48e:17d1:16c9 with SMTP id ffacd0b85a97d-48e6e4f5652mr39090757f8f.40.1793870819117; Thu, 05 Nov 2026 01:26:59 -0800 (PST) X-Received: by 2002:a5d:64e7:0:b0:48e:17d1:16c9 with SMTP id ffacd0b85a97d-48e6e4f5652mr39090709f8f.40.1793870818660; Thu, 05 Nov 2026 01:26:58 -0800 (PST) Received: from [192.168.88.30] (ip231-128-192-82.pool-bba.aruba.it. [82.192.128.231]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48fece998absm9617108f8f.22.2026.11.05.01.26.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Nov 2026 01:26:58 -0800 (PST) Message-ID: <679b8dcf-0aac-4674-a006-5af0156a82ae@redhat.com> Date: Thu, 5 Nov 2026 10:26:57 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 0/5] net: sparx5: add tc matchall port policer offload To: Daniel Machon , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Steen Hegelund , UNGLinuxDriver@microchip.com Cc: robert.marko@sartura.hr, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20261102-b4-lan966x-pci-fdma-sparx5-lan969x-port-policers-v2-0-3bd47ec1b227@microchip.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20261102-b4-lan966x-pci-fdma-sparx5-lan969x-port-policers-v2-0-3bd47ec1b227@microchip.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/2/26 13:21, Daniel Machon wrote: > This series adds offload of tc matchall filters with a police action to > the ingress port policers of Sparx5 and lan969x, which are both served > by the sparx5 driver. > > In hardware, each ingress port has four single-rate leaky bucket > policers. A policer drops the frames that exceed its rate and burst. > The four policers of a port share the pass and drop statistics counters > of the port. > > The driver uses one policer per port, because with more than one, the > statistics reported to tc could not be attributed to the right policer. > This matches lan966x and ocelot. The policer meters each frame without > preamble and inter-frame gap, so the configured rate is a data rate, as > tc police expects and as on lan966x and ocelot. > > Since the policer meters all ingress frames on the port, only filters on > chain 0 with protocol all are offloaded, and filters on shared blocks > are rejected. A police action that is already offloaded as a port > policer on another port is rejected too, since in software it is a > single bucket for all of its users. Only drop is supported as the exceed > action, and the police overhead parameter is not supported. > > Patch #1 drops a redundant prefix from the existing POL_UPD_INT_CFG > register macros. > > Patch #2 adds the registers used by the port policer. > > Patch #3 tracks whether the ingress block of a port is shared, and adds > the per-port policer state. > > Patch #4 adds the hardware programming of the port policer. > > Patch #5 adds the tc matchall offload. > > Signed-off-by: Daniel Machon I understand the following will be very frustrating, but for unknown reason AI review did not kick on this series. The changes looks sane to me, and addressing points raised on v1, but I think nowadays we need an explicit AI feedback. Could you please re-submit the series? Thanks! Paolo