From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B6733D76 for ; Tue, 21 Apr 2026 01:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776736400; cv=none; b=nHrXLadhMCV1VwUy7vCELkmJQc7eYlq5e8rXYtM/1GtdIxnxtmPQvaaWpV/VycJ4D6RRFJIttrXjqlbm2EsoHXaPn5Ae5n4WEl1afLvWJlbFKUeITrWcODpUYliMXm7nXnS9Xd4i9CCDwrxuR/gM2vM1O9Cg+LHM0b83nHuRAn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776736400; c=relaxed/simple; bh=MLZ3fF2adwZOR6sFDAE4hrov221DCiFKz/yQBEa2j8w=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=mv59d/1/Gdu+DSJWi7H4rWhX2xX+B2WhdzQJfMt1WhVWfFkjTBYYxxCzP3qANivg0VluoyCnjv9k2HQXuQw/u2AFlf9RR0a8TMqcGdnkBlhdy8lyGw2yCI6xNizf6aocBUNMciF3LwVIYBtE9p/GrPeJdcNQqeqvG8Ul9N+WTjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U1VXKvOX; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U1VXKvOX" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2b45cb89f7eso26466785ad.0 for ; Mon, 20 Apr 2026 18:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776736399; x=1777341199; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=fKuWhubs2jffoAGuZik7i2LnsTPtRcMNffaFHPjYq00=; b=U1VXKvOX/up0F8mdlSlmtaVzpnKhmgMfqCTMDXP5s8XenNzK1FlOrMT3rsiYNLuwMA vjfoGmeGmF/dypoSO/rWe2AVGHsG+8HCVct9SyBf1HqqVEXCQOO3395qgXt1qTeBvvR5 nTB9/gdOdUbyZHiyrx5ik84Qz2jgOesGz/iMWkARJ1nIKyjin177ZzLFwlwPBJbjleqx hwHvN1Sye9btPAA8WFru5GL8MfG0fvrFYd7N9Iasd1iy2c5CwUUEkX5MOUIyYUB6iQDq /sO+708tdN23bkEaN4Qe+06nO5fXNWm5Pz5aBUJd4t1BL0jG+1dv1zuijIbELgCxNRPs O91g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776736399; x=1777341199; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fKuWhubs2jffoAGuZik7i2LnsTPtRcMNffaFHPjYq00=; b=M5vDAZsd+ordZjREjKIC2okNeyyeu0NHBi+c3D2QliIfdEUeouiICbIvyDxD/KMEBj mF4bWNLn8lplW+isKSm6kh75UM9LfyRHqhp4m5bYSIwXs3lNV5ETk1wihpyflot0KBF+ zjR1A56d8ImHmDDHPfv6Gyk2caldZoPWg+1kZUEKxVjRc7VzZvjpksKRRQ1uuDu2dHA2 7+SLBbLcJKXKzCqQWKOnWqjfGmJJ0HEr2X52WNfke/1LuSHpMu6vGeZfUcHLdv+BaJUb Ofg3anKvFHPRWI2XUg19cdbUDD4oJ60hzoqD+MXau8xi+GsXeITQ4t6BDjwa/5lvBY1o I5tw== X-Forwarded-Encrypted: i=1; AFNElJ/nJjf2N0iWAwMcB3E29y+6QWtI4BIl4N050/BG7m4QtNEVzonNympEShWpjzsiu5r97TmZ75oIIl0jVCk=@vger.kernel.org X-Gm-Message-State: AOJu0YxUTZQBlD8JzZSz0E8gLPe+TstT1qjvP+DMb/oLR/bvoNs1Podb KxaNUYWllMbuZWBAr515KILHXCr4hu4zzV32HaVN6yCvrhSIcsJ4JRzx X-Gm-Gg: AeBDievDu0U18JrQ6JOfM8mGO4BBkYz9kBcSZoiWNECvTWOl0RrEoZelOaeNoPIQApX fjF8HOQZLgAfLubkmvM5xtSKSSUNjvtfdeCcYDxUh71fUuOjF4Fi/tsPuvN2Q6CYG//y+DFriQM 70BHl8FBP+e/drTu2Lr3JyM3obojcG12biC9ArzYHgs8vrUg57aRHHdbeHjozq3OadFa/vIHPPr ReWiPZajh/jFSZoAIPHx2nDsESLqy9d4i/uMYLQk+NaYBWhN3l2NYqrLRTjhE1HdbcstKzN1SzY 5TPhRlK9G9nmz/lZJaffc/2bfUlHe/IcCt3Y2i9+B1+8awutOXht8qS1/oALtugdr41P1KSJE3n Z5jWB1gM9Yr17XV15kELH4xT6ywdX7Be4YNA8vj1EbxqKcMqDjZqB8Z2aivYoG3VESJiOlky96M CfuJCutEFeEtbH0F2cjemeDEtCiKUtw5lTYRv2H5V9MSV90L86c+mI8So4grnlXUgFClNF X-Received: by 2002:a17:903:907:b0:2b0:606b:6fd3 with SMTP id d9443c01a7336-2b5f9e77061mr154975445ad.5.1776736398902; Mon, 20 Apr 2026 18:53:18 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:ae21:d323:b31b:43e0:4f1e:901c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab3c067sm116610065ad.76.2026.04.20.18.53.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 18:53:18 -0700 (PDT) Date: Tue, 21 Apr 2026 07:23:06 +0530 From: Sanjay Chitroda To: Geert Uytterhoeven CC: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: accel: mma8452: use pm_ptr() for dev_pm_ops User-Agent: Thunderbird for Android In-Reply-To: References: <20260414192045.3598010-1-sanjayembedded@gmail.com> Message-ID: <67B89EF1-C05C-4317-8E8A-A8DB87748457@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 20 April 2026 1:36:14=E2=80=AFpm IST, Geert Uytterhoeven wrote: >Hi Sanjay, > >On Tue, 14 Apr 2026 at 21:20, Sanjay Chitroda > wrote: >> From: Sanjay Chitroda >> >> Use pm_ptr() so the PM ops pointer is automatically set to >> NULL when CONFIG_PM is disabled=2E This avoids unused-function warnings >> and follows modern kernel power-management conventions=2E >> >> Signed-off-by: Sanjay Chitroda > >Thanks for your patch! > >> --- a/drivers/iio/accel/mma8452=2Ec >> +++ b/drivers/iio/accel/mma8452=2Ec >> @@ -1744,7 +1744,6 @@ static void mma8452_remove(struct i2c_client *cli= ent) >> regulator_disable(data->vdd_reg); >> } >> >> -#ifdef CONFIG_PM >> static int mma8452_runtime_suspend(struct device *dev) >> { >> struct iio_dev *indio_dev =3D i2c_get_clientdata(to_i2c_client(= dev)); >> @@ -1812,7 +1811,6 @@ static int mma8452_runtime_resume(struct device *= dev) >> >> return ret; >> } >> -#endif >> >> static const struct dev_pm_ops mma8452_pm_ops =3D { >> SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_fo= rce_resume) > >You are still getting defined but not used warnings, as reported by >the kernel test robot, due to the use of SET_SYSTEM_SLEEP_PM_OPS() >and SET_RUNTIME_PM_OPS()=2E Please define the structure using >DEFINE_RUNTIME_DEV_PM_OPS() to fix this=2E > >> @@ -1835,7 +1833,7 @@ static struct i2c_driver mma8452_driver =3D { >> =2Edriver =3D { >> =2Ename =3D "mma8452", >> =2Eof_match_table =3D mma8452_dt_ids, >> - =2Epm =3D &mma8452_pm_ops, >> + =2Epm =3D pm_ptr(&mma8452_pm_ops), >> }, >> =2Eprobe =3D mma8452_probe, >> =2Eremove =3D mma8452_remove, > >Gr{oetje,eeting}s, > > Geert > Hi Greet, Thank you for the review and feedback=2E I will update changes in next version=2E Thank, Sanjay Chitroda