From: Wei Xu <xuwei5@hisilicon.com>
To: Sudeep Holla <sudeep.holla@arm.com>,
"lihuisong (C)" <lihuisong@huawei.com>
Cc: <xuwei5@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] soc: hisilicon: kunpeng_hccs: Simplify PCC shared memory region handling
Date: Tue, 15 Apr 2025 16:55:10 +0800 [thread overview]
Message-ID: <67FE1EEE.1010802@hisilicon.com> (raw)
In-Reply-To: <20250415-cream-jackrabbit-of-psychology-57f038@sudeepholla>
Hi Sudeep,
On 2025/4/15 16:32, Sudeep Holla wrote:
> On Tue, Apr 15, 2025 at 02:26:40PM +0800, lihuisong (C) wrote:
>> +Wei who is Hisilicon SoC maintainer.
>>
>> 在 2025/4/11 19:25, Sudeep Holla 写道:
>>> The PCC driver now handles mapping and unmapping of shared memory
>>> areas as part of pcc_mbox_{request,free}_channel(). Without these before,
>>> this Kunpeng HCCS driver did handling of those mappings like several
>>> other PCC mailbox client drivers.
>>>
>>> There were redundant operations, leading to unnecessary code. Maintaining
>>> the consistency across these driver was harder due to scattered handling
>>> of shmem.
>>>
>>> Just use the mapped shmem and remove all redundant operations from this
>>> driver.
>>>
>>> Cc: Huisong Li <lihuisong@huawei.com>
>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> Reviewed-by: Huisong Li <lihuisong@huawei.com>
>
> Thanks and sorry for dropping it assuming you will pick it up.
> The maintainers file just list you.
>
> Wei,
>
> Let me know if you want me to repost or if you can pick it from [1]
>
It is OK and I will pick that.
Thanks!
Best Regards,
Wei
next prev parent reply other threads:[~2025-04-15 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 11:25 Sudeep Holla
2025-04-15 6:26 ` lihuisong (C)
2025-04-15 8:32 ` Sudeep Holla
2025-04-15 8:55 ` Wei Xu [this message]
2025-04-22 12:14 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67FE1EEE.1010802@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=xuwei5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®