From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00E45302CB6 for ; Tue, 16 Sep 2025 11:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758022503; cv=none; b=fGr4OhXjGoAbQ0FNIEYEbwpEMq1UI4d3QRK+ZvFrrKFEu7siND4iikQvGbbgMC+2UTaSHw8Ob1dYCAEbZ/lsytzpfxRY0WycgeFa9NAoaU0G5NI1T0zq2/PZMGTPv72GVSeqmYhmoM0S7PmAeqmJM+VYb7I4osX4vP76ftjiF8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758022503; c=relaxed/simple; bh=mDUdAClhpngDylpZKamaU8L76ftWrz0ssjp5eVq6BYQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=Xw9sHJhH6IN4zNBNV8d52D3ZlEzEreHMiWV7oasfwWxBYslVZxM8IqYWzlltxeTwOOKmyTKu9jXqKyof2/FqyGWQYLunbU8W8PmeT/FcoeBB1/JxEbX8oQpN4udhW+Xv+yLT9BbHMbUxcwDF2bohFJ6qqdoP5uiKs23zsmVGU3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CnwrSwMm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CnwrSwMm" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58GAKhVo010694 for ; Tue, 16 Sep 2025 11:35:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PmwR9D+tvcvJlEb5/hczlmY/+kQv8mMLdqGi569sPyA=; b=CnwrSwMmSndg1RoR psWTN+6pYKUIsJ6Fh1+b9Fd5xz0fYmy727XciC4m9Qgt7Mr3jPdMpMm4IaI+mf2B X79Mga39k6pEelDcBoj2Tm6QaKe8JdUITkjbIIFUrvfWdLY7ft1mUge9gtNdy7AE c53qAjeGAYzNbCZDIjDycFYa+rZrRadZlOg8VXHqVU5AXdC7B5Lee8FaTJGMlSiB vTgWWbibB2j/EZTi9Hqpjdg2PCUU3MPckSgkRXK8HLbELSPcMr2DrdMfv9+rpms2 5mGvys8Ts2E60ka/w75O9wJ5a1w72r8wULZJvSzCddVhAK4mvnhGJV4nKwtmJMs0 zcjeQQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4951snrg66-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 16 Sep 2025 11:35:01 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-260494984b2so11022015ad.2 for ; Tue, 16 Sep 2025 04:35:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758022500; x=1758627300; h=content-transfer-encoding:in-reply-to:references:cc:to:from:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PmwR9D+tvcvJlEb5/hczlmY/+kQv8mMLdqGi569sPyA=; b=TaQ5EMZM8zVPnCupQgBYfcDsOWCHcocjDTJkKLAw0rUReXRkzUjux0hOs9nl1Euijf r89HaFE6eIG6jLnhfqHXT4hPSAZ8bqHSjCnx63Qdrd6yXEpFQYlJ74eF5dY32h5AakJd rzJ9sH/QEJyZcv+0BAXmgBK53dyxXrpa/w+E7EEpO7Jl0m+wOFkTs7dyg+sfxk4nLf+p elFMrW1jWuspDqIVw5/tS2Vnq+r8Y5qOW4l3m7OLSv22jHtjCXDqYzoHLx+ncAuQq5EI y9P/aVBiJLEZGKvDxv/IF+HXgtzbzaOibpuaKnOj9DzpPXBj7mR9EpPJvXdZ1LrXuXm1 Li2w== X-Forwarded-Encrypted: i=1; AJvYcCWY8HLPR2WOy89SPVlAvCZ3Rqh/cRn0+xXHKAqzvCe7lppfH6DtbqtFT0T8SvCUBd4dyZooVIQyUYh1mFQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5IjjIdW3ccjujLeUqw7r8H71b4UjOEQ8PYPuYKJ2jFJRWA9l+ Ry8xVibfTTlm5GoRjT5ZMd8us+jQC3h2dkfxjPyRfBZ/CVmlB3vwdacy87NC1xFqlr3ww9hwjYH UzDJ4MzKx7VQ41Galy2Gn03IGeruNn0o7agJPBBW/lPBS/7yI3OpEnKcz4+rpcHdxbaY= X-Gm-Gg: ASbGnct0yCWMP78A731Pjf+HTARYdjC1BEqubdYgnsSVr8HnISCOQibtbG5PZfiPhrf sGzWB41u2tKD1a7/PW+ARpj3qbRDdIjR2Nj1Hk84X9MgYhItTDcqZi8WH4fCulKrvmwILrPN0v3 M3145hmcZU1Z2t0gyriwCJniklKeHKz9Lek0a2Yt6QOz6Sa+5CF5QP/CtTnJhGvroV4SYUKxs9b 69m9q2O8mP7vdi0w8PpNxEPb2K8Ir8VaR6haaahD6ovWgmu5X1fZlGVr5VmUlDs7AN7mtnl6JSq Dzoh0TULWkFPj01ciDS5+ktYqXIi3v5B6clQdGeW6V9DBdXcJuYdy/8z9cZUKyiiy+/3HeC8W6z akwvc4/iOpt1xq4jieqZI412mdwDIsuZFzlU= X-Received: by 2002:a17:902:ea03:b0:267:8b4f:df10 with SMTP id d9443c01a7336-2678b4fe1eamr38673885ad.0.1758022500170; Tue, 16 Sep 2025 04:35:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUGBkOmp8SbmqyPrB/ux8BIh6J3rY072mZrg1gtge/X1eT2SGo/MRJMekisexbLCC9g2Zk5g== X-Received: by 2002:a17:902:ea03:b0:267:8b4f:df10 with SMTP id d9443c01a7336-2678b4fe1eamr38673655ad.0.1758022499633; Tue, 16 Sep 2025 04:34:59 -0700 (PDT) Received: from [10.133.33.231] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-267e9372e86sm7196355ad.136.2025.09.16.04.34.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Sep 2025 04:34:59 -0700 (PDT) Message-ID: <67a06487-001a-4af7-83cd-e9d05d848479@oss.qualcomm.com> Date: Tue, 16 Sep 2025 19:34:52 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: display/msm: dp-controller: Add SM6150 From: Xiangxu Yin To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kuogee Hsieh , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, fange.zhang@oss.qualcomm.com, yongxing.mou@oss.qualcomm.com, li.liu@oss.qualcomm.com References: <20250916-add-dp-controller-support-for-sm6150-v2-1-e466da9bb77d@oss.qualcomm.com> <5sg43rsun33i6bm3vz7io7yx2p4m7bmk5bnrnjg6u3zrulyofs@gyxtnfs4gvhz> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=JO87s9Kb c=1 sm=1 tr=0 ts=68c94b65 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ODrqbaRasvCVI81-ReQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: h3uXXPerlW_hTP8CfLBicPoBtJcVDIp3 X-Proofpoint-GUID: h3uXXPerlW_hTP8CfLBicPoBtJcVDIp3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTEzMDA0MCBTYWx0ZWRfX91xqdwH+tWzD Quxo6M+VVmhkbliQREWZIZgXVR1mf7nfIGFRcMc7xEXp8BYw1zu0EzgpvG4Z1HyodV1LAExqflp 03khp6vRRKB8ceOtE80oLeCtEUPqD1wxQ5B1JlGLVvVxnJpcHw0ipblnBZm7rE/JV9knBbHy2S9 zxaQNE8W/mysA+KcnautOcevRGSCoJLIzpQy6JpEJ16CiYz8Xeo4fJyuyd9vFI0/ObRGrjtQFeS yriVb0z0Ff+g8xTgIMjMWl3D7E3TQIAjk+4t7qufIuXGIhuFeyCI1NbM1L24QK6b/Q5IzwmJYK1 Co74aENXXqa7X9RdxbqjYtfDdEprP+oXHFhoi5iQS+rTCTgovsDVxZWi37LhtEHJNgFw7xotelF KV2qVIlp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-16_02,2025-09-12_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 adultscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509130040 On 9/16/2025 7:25 PM, Xiangxu Yin wrote: > On 9/16/2025 6:22 PM, Dmitry Baryshkov wrote: >> On Tue, Sep 16, 2025 at 03:31:35PM +0800, Xiangxu Yin wrote: >>> Add DisplayPort controller binding for Qualcomm SM6150 SoC. >>> 'qcom,sm6150-dp' uses the same controller IP as 'qcom,sm8150-dp'. >>> Declare 'qcom,sm6150-dp' as a fallback compatible to 'qcom-sm8350-dp' >>> for consistency with existing bindings and to ensure correct matching and >>> future clarity. >>> >>> Signed-off-by: Xiangxu Yin >>> --- >>> This series splits the SM6150 dp-controller definition from the >>> '[v3] Add DisplayPort support for QCS615 platform' series and rebases >>> 'dt-bindings: msm/dp: Add support for 4 pixel streams'. >>> >>> The devicetree modification for DisplayPort on SM6150 will be provided >>> in a future patch. >>> --- >>> Changes in v2: >>> - Update commit message and binding with fallback configuration. [Dmitry] >>> - Drop driver patch since SM6150 is declared as a fallback to 'qcom-sm8350-dp'. >>> - Link to v1: https://lore.kernel.org/r/20250912-add-dp-controller-support-for-sm6150-v1-0-02b34b7b719d@oss.qualcomm.com >>> --- >>> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> index aeb4e4f36044a0ff1e78ad47b867e232b21df509..82481519005a1b038a351aa358b9266239d0e8a9 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >>> @@ -46,6 +46,7 @@ properties: >>> - items: >>> - enum: >>> - qcom,sar2130p-dp >>> + - qcom,sm6150-dp >> In the review to the previos iteration I think I was a bit explicit: >> "qcom,sm6150-dp", "qcom,sm8150-dp", "qcom-sm8350-dp". You seemed to >> agree to it. Now you didn't implemet that. Why? > > Sorry, I misunderstood your previous comment. > I thought the recommendation was only about the commit message, not the > binding structure. > > Does the current implementation mean that qcom,sm6150-dp and qcom,sm8150-dp > fallback to "qcom,sm8350-dp"? >     - items: >         - enum: >             - qcom,sar2130p-dp >             - qcom,sm6150-dp >             - qcom,sm7150-dp >             - qcom,sm8150-dp >             - qcom,sm8250-dp >             - qcom,sm8450-dp >             - qcom,sm8550-dp >         - const: qcom,sm8350-dp > > Do you mean modifying it as below? >     - items: >         - enum: >             - qcom,sar2130p-dp >             - qcom,sm6150-dp >             - qcom,sm7150-dp >             - qcom,sm8250-dp >             - qcom,sm8450-dp >             - qcom,sm8550-dp >         - const: qcom,sm8150-dp >         - const: qcom,sm8350-dp > Or this?     - items:         - enum:             - qcom,sm6150-dp         - const: qcom,sm8150-dp         - const: qcom,sm8350-dp >>> - qcom,sm7150-dp >>> - qcom,sm8150-dp >>> - qcom,sm8250-dp >>> >>> --- >>> base-commit: c3067c2c38316c3ef013636c93daa285ee6aaa2e >>> change-id: 20250916-add-dp-controller-support-for-sm6150-525ac2ed8c86 >>> >>> Best regards, >>> -- >>> Xiangxu Yin >>>