From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04D47C433F5 for ; Thu, 3 Mar 2022 11:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbiCCLhJ (ORCPT ); Thu, 3 Mar 2022 06:37:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233147AbiCCLg6 (ORCPT ); Thu, 3 Mar 2022 06:36:58 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05B8B4B840; Thu, 3 Mar 2022 03:36:01 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6434D218E6; Thu, 3 Mar 2022 11:36:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646307360; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IDiQKJrDpIO7+2X0qZBOWb0f8AHNA+AoPBY4gI4/LKk=; b=cTmRBz8F83E1yHKbJThlcDmx0Lhn1CoJRik6ZO46mItJ1F5211m4z4XagQoi77clhsZ/2s 19gDh0lYUziEm1ws5oWGZtcDbixOaAYNtzHlpJZ7pofO44JLPEev1jkNPVmJ3JxCc6dVxf wSlPR9WgwPVswQXZS5n/Pogpec3NxRQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646307360; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IDiQKJrDpIO7+2X0qZBOWb0f8AHNA+AoPBY4gI4/LKk=; b=AkhkNvd5C2h4CZs/sf+t+jQr9jypWdfbeSbPkPQLh7oD4tOmAFR1GgkQk4UPjn/mjVm0I7 7uF6GmQZdb3BmKCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4566813AB4; Thu, 3 Mar 2022 11:35:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NFGoDx+oIGLmJAAAMHmgww (envelope-from ); Thu, 03 Mar 2022 11:35:59 +0000 Message-ID: <67a0df7a-aa19-e323-3af5-00fda7e7dd62@suse.cz> Date: Thu, 3 Mar 2022 12:35:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v3] serial: make uart_console_write->putchar()'s character an unsigned char Content-Language: en-US To: "Maciej W. Rozycki" , Paul Cercueil Cc: David Laight , =?UTF-8?Q?=27Uwe_Kleine-K=c3=b6nig=27?= , gregkh@linuxfoundation.org, Alexandre Belloni , Mateusz Holenko , Neil Armstrong , Benjamin Herrenschmidt , Liviu Dudau , Baruch Siach , linux-kernel@vger.kernel.org, Paul Mackerras , Michael Ellerman , Michal Simek , Karol Gugala , Jerome Brunet , Peter Korsgaard , Florian Fainelli , Alexander Shiyan , Krzysztof Kozlowski , Alexandre Torgue , Fabio Estevam , Russell King , Ludovic Desroches , Andy Gross , bcm-kernel-feedback-list@broadcom.com, NXP Linux Team , linux-serial@vger.kernel.org, Vineet Gupta , Orson Zhai , Tobias Klauser , Patrice Chotard , Albert Ou , Maxime Coquelin , Manivannan Sadhasivam , Martin Blumenstingl , Sascha Hauer , Takao Orito , Vladimir Zapolskiy , Lorenzo Pieralisi , Paul Walmsley , Bjorn Andersson , Sudeep Holla , Richard Genoud , Chunyan Zhang , Nicolas Ferre , "David S. Miller" , Taichi Sugaya , Palmer Dabbelt , Pengutronix Kernel Team , Kevin Hilman , Baolin Wang , Shawn Guo , =?UTF-8?Q?Andreas_F=c3=a4rber?= References: <20220302072732.1916-1-jslaby@suse.cz> <20220302175242.ejiaf36vszr4xvou@pengutronix.de> <5c7045c1910143e08ced432d938b5825@AcuMS.aculab.com> <84ad3854-28b9-e450-f0a2-f1448f32f137@suse.cz> From: Jiri Slaby In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03. 03. 22, 12:30, Maciej W. Rozycki wrote: > It does, but, oh dear, it's a "solution" to a problem we have created in > the first place. Why do we ever want to have signed characters in the TTY > layer, We don't. We use char, which is signed or unsigned, depending on arch. After all, this is text coming from printk layer, i.e. char * by convention coming from the standard. thanks, -- js suse labs