From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA5BEC4338F for ; Mon, 23 Aug 2021 17:07:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C740361372 for ; Mon, 23 Aug 2021 17:07:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230304AbhHWRIG (ORCPT ); Mon, 23 Aug 2021 13:08:06 -0400 Received: from pegase2.c-s.fr ([93.17.235.10]:55711 "EHLO pegase2.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230474AbhHWRGd (ORCPT ); Mon, 23 Aug 2021 13:06:33 -0400 Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Gtdt53jKnz9sTr; Mon, 23 Aug 2021 19:05:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fbdMG_FqIlnR; Mon, 23 Aug 2021 19:05:49 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Gtdt52kzjz9sTg; Mon, 23 Aug 2021 19:05:49 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 268CE8B7AD; Mon, 23 Aug 2021 19:05:49 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 2xoQtNv-6Qji; Mon, 23 Aug 2021 19:05:49 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id BABDA8B7BA; Mon, 23 Aug 2021 19:05:48 +0200 (CEST) Subject: Re: [PATCH] powerpc/booke: Avoid link stack corruption in several places To: Segher Boessenkool Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20210823155837.GX1583@gate.crashing.org> From: Christophe Leroy Message-ID: <67a5be3f-a443-03eb-aa8e-a1fa6c0b3d3f@csgroup.eu> Date: Mon, 23 Aug 2021 19:05:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210823155837.GX1583@gate.crashing.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 23/08/2021 à 17:58, Segher Boessenkool a écrit : > On Mon, Aug 23, 2021 at 07:53:01AM +0000, Christophe Leroy wrote: >> /* Be careful, this will clobber the lr register. */ >> #define LOAD_REG_ADDR_PIC(reg, name) \ >> - bl 0f; \ >> + bcl 20,31,0f \ >> 0: mflr reg; \ >> addis reg,reg,(name - 0b)@ha; \ >> addi reg,reg,(name - 0b)@l; > > The code ended each line with a semicolon before, for absolutely no > reason that I can see, but still. Fixing that would be nice, but only > doing it on one line isn't good. Sure, forgetting the semicolon broke the build. That's because the backslash removes the newline. The cleanest way I found to fix that quite of stuff is by using GAS macro, as I did for LOAD_REG_IMMEDIATE() some time ago. > > Btw. Both the 7450 and the modern cores implementing this really need > this to be $+4, so it is a lot clearer to write that instead of 1f or > a named label. I like that, removing unneeded labels will make it smoother and clearer. I'll do it. Christophe