From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74C73E7F153 for ; Fri, 29 Sep 2023 10:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233083AbjI2Kqh (ORCPT ); Fri, 29 Sep 2023 06:46:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233009AbjI2Kqd (ORCPT ); Fri, 29 Sep 2023 06:46:33 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5F4A1AC for ; Fri, 29 Sep 2023 03:46:30 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-32615eaa312so137096f8f.2 for ; Fri, 29 Sep 2023 03:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695984389; x=1696589189; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PomosRj11Rw7FzKt/a27wORhob1DvLPTYexDbFcMqUs=; b=INsUeXM1TY6KKYp8pfy65YcGDbN/CIe+8uhc4oxq3hOMsUNEwGtUUv0XMKTV8m8oPC aZ09sdIQjreGeD/XHyXqLTnJtuySXWQyNkVtkfXRqddC3PsfM1cy5zoWu0f+/LyAvtBD vydADrdEkX/OWdFENKaD4dxEHiyZZsIb2t/5nXGO5ej6gGQHMYGMdgKGZ0kqrVptxQmN PjPHe4glEDpeJTCOLurGNnlMfQUmtHKULfozGxdI3sMkJjwdS7p9Oi50iNoRqDQ76Dke VrPFrMb7gqG85PoFxQfNaoUag55ZDMk8i8Fp5RitocNzqKPyqgVyAyXCHQ0ETQHapuNK 7Q3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695984389; x=1696589189; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PomosRj11Rw7FzKt/a27wORhob1DvLPTYexDbFcMqUs=; b=GFWScnBddkWwSQTkqrZwleuJfuqO50aRMwGqTFZnq11OA8Kj3jcb0CDPopbV8ML2rP FsXwfGJDsapSfYNhoyxGdFgaNBz4RRV96+IGE2P0oAC/iAz/fojVwMFqL1kUrsD79feD f4bg/2754y9jVH3jre3DZu0hfsj5kHedOIM4Ycin2283rpFS7FZFRBJkmkd9lF2Pw83M u9bhFajb9C69/GK8cONe/EuyJqpbOpDkIE7MwqEBPnnlrMLIsmBQvZ3yZPqlzFl6kTrn 6lV1S9NldvL1ae+mv1UjDPSKqOsiUvNr7+6mXQMdw9kqPM2hyyO23ZwlDSkj4oqQUopx emtA== X-Gm-Message-State: AOJu0YxNHTSdLhsUdnhCtLj6E1e8a0OcSDgMCKSuZ4tVnf/Fr7vpEc7X z38Y71+h1GsFM0qqpwjZVkT0xA== X-Google-Smtp-Source: AGHT+IHBLhu5LKmDqs0T5cSdi68jCaHZTesf9t3PrH+Vv6MsavFenUPBewzcl5FLn6EjfCUg4Sdw9g== X-Received: by 2002:adf:f1c9:0:b0:31f:e428:8a4d with SMTP id z9-20020adff1c9000000b0031fe4288a4dmr3556690wro.33.1695984389171; Fri, 29 Sep 2023 03:46:29 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:c49e:e1a5:3210:b8c0? ([2a05:6e02:1041:c10:c49e:e1a5:3210:b8c0]) by smtp.googlemail.com with ESMTPSA id s28-20020adfa29c000000b003232f167df5sm10830720wra.108.2023.09.29.03.46.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Sep 2023 03:46:28 -0700 (PDT) Message-ID: <67a7d507-7025-ee3e-f388-0a96e11eae41@linaro.org> Date: Fri, 29 Sep 2023 12:46:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 4/7] thermal: exynos: simplify regulator (de)initialization Content-Language: en-US To: m.majewski2@samsung.com, Krzysztof Kozlowski , "linux-pm@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Cc: Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , ALIM AKHTAR , Liam Girdwood , Mark Brown , Marek Szyprowski References: <20230911133435.14061-1-m.majewski2@samsung.com> <20230911133435.14061-5-m.majewski2@samsung.com> <20230926110239eucms1p2b539245c5b10591def4cd15f14896ad6@eucms1p2> From: Daniel Lezcano In-Reply-To: <20230926110239eucms1p2b539245c5b10591def4cd15f14896ad6@eucms1p2> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/09/2023 13:02, Mateusz Majewski wrote: > Hi, > >> This is not equivalent. If regulator is provided and enable fails, the >> old code is nicely returning error. Now, it will print misleading >> message - failed to get regulator - and continue. >> >> While this simplifies the code, it ignores important running condition - >> having regulator enabled. > > Would doing this be correct? > > ret = devm_regulator_get_enable_optional(&pdev->dev, "vtmu"); > switch (ret) { > case 0: > case -ENODEV: Not sure to understand why -NODEV is not an error > break; > case -EPROBE_DEFER: > return -EPROBE_DEFER; > default: > dev_err(&pdev->dev, "Failed to get enabled regulator: %d\n", > ret); > return ret; > } ret = devm_regulator_get_enable_optional(&pdev->dev, "vtmu"); if (ret < 0) { if (ret != EPROBE_DEFER) dev_err(&pdev->dev, "Failed to get enabled regulator: %d\n", ret); return ret; } ?? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog