From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, linux-fsdevel@vger.kernel.org,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Viacheslav Dubeyko <slava@dubeyko.com>,
Yangtao Li <frank.li@vivo.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] HFS: btree: fix missing error check after hfs_bnode_find()
Date: Wed, 10 Dec 2025 18:09:24 +0100 [thread overview]
Message-ID: <67b5e999-2380-46db-aee1-a81df3ceeb36@web.de> (raw)
In-Reply-To: <20251209021401.1854-1-vulab@iscas.ac.cn>
> In hfs_brec_insert() and hfs_brec_update_parent(), hfs_bnode_find()
> may return ERR_PTR() on failure, but the result was used without
> checking, risking NULL pointer dereference or invalid pointer usage.
>
> Add IS_ERR() checks after these calls and return PTR_ERR()
> on error.
* Can an other word wrapping look eventually a bit nicer here?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18#n658
* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18#n145
Regards,
Markus
next prev parent reply other threads:[~2025-12-10 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 2:14 Haotian Zhang
2025-12-10 17:09 ` Markus Elfring [this message]
2025-12-11 23:13 ` Viacheslav Dubeyko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67b5e999-2380-46db-aee1-a81df3ceeb36@web.de \
--to=markus.elfring@web.de \
--cc=frank.li@vivo.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®