RE: [PATCH v2 06/11] wifi: rtw88: coex: reassert the antenna path when associating

[Ping-Ke Shih <pkshih@realtek.com>]

luka.gejak@linux.dev <luka.gejak@linux.dev> wrote:

[...]

> +/* Replayed immediately before start_clnt_join()/auth: BT_INFO + PS-TDMA type 8
> + * then the forced WiFi PTA antenna path, so the auth window is clean.
> + */

Comment style. 

> +void rtw_coex_8723bs_pre_auth_h2c(struct rtw_dev *rtwdev)
> +{
> +       lockdep_assert_held(&rtwdev->mutex);
> +
> +       if (!rtw_coex_8723bs_bt_disabled(rtwdev))
> +               return;
> +
> +       rtw_fw_query_bt_info(rtwdev);
> +       rtw_fw_coex_tdma_type(rtwdev, 0x08, 0x00, 0x00, 0x00, 0x00);
> +       rtw_fw_coex_tdma_type(rtwdev, 0x08, 0x00, 0x00, 0x00, 0x00);
> +       rtw_fw_coex_tdma_type(rtwdev, 0x08, 0x00, 0x00, 0x00, 0x00);
> +       rtw_coex_8723bs_fw_gnt_bt_low(rtwdev);
> +       rtw_coex_8723bs_force_assoc_pta_ant(rtwdev);
> +}
> +
>  static const char *rtw_coex_get_algo_string(u8 algo)
>  {
>         switch (algo) {
> @@ -3115,6 +3150,17 @@ void rtw_coex_connect_notify(struct rtw_dev *rtwdev, u8 type)
>         if (coex->manual_control || coex->stop_dm)
>                 return;
> 
> +       /* 8723BS SDIO BT-disabled: the vendor ConnectNotify() early-returns
> +        * without sending H2Cs; scan_workaround already established the PTA
> +        * path / coex table / PS-TDMA. Keep only the register-level PTA
> +        * reassertion at associate-start.
> +        */
> +       if (rtw_coex_8723bs_bt_disabled(rtwdev)) {
> +               if (type == COEX_ASSOCIATE_START)
> +                       rtw_coex_8723bs_force_assoc_pta_ant(rtwdev);
> +               return;
> +       }
> +
>         rtw_coex_write_scbd(rtwdev, COEX_SCBD_ACTIVE | COEX_SCBD_ONOFF, true);
> 
>         if (type == COEX_ASSOCIATE_5G_START) {