From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Marcus Wichelmann <marcus.wichelmann@hetzner-cloud.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: willemdebruijn.kernel@gmail.com, jasowang@redhat.com,
andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com,
jolsa@kernel.org, mykolal@fb.com, shuah@kernel.org,
hawk@kernel.org, marcus.wichelmann@hetzner-cloud.de
Subject: Re: [PATCH bpf-next v4 4/6] selftests/bpf: refactor xdp_context_functional test and bpf program
Date: Thu, 27 Feb 2025 10:58:14 -0500 [thread overview]
Message-ID: <67c08b96d1f88_37f929294af@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20250227142330.1605996-5-marcus.wichelmann@hetzner-cloud.de>
Marcus Wichelmann wrote:
> The existing XDP metadata test works by creating a veth pair and
> attaching XDP & TC programs that drop the packet when the condition of
> the test isn't fulfilled. The test then pings through the veth pair and
> succeeds when the ping comes through.
>
> While this test works great for a veth pair, it is hard to replicate for
> tap devices to test the XDP metadata support of them. A similar test for
> the tun driver would either involve logic to reply to the ping request,
> or would have to capture the packet to check if it was dropped or not.
>
> To make the testing of other drivers easier while still maximizing code
> reuse, this commit refactors the existing xdp_context_functional test to
> use a test_result map. Instead of conditionally passing or dropping the
> packet, the TC program is changed to copy the received metadata into the
> value of that single-entry array map. Tests can then verify that the map
> value matches the expectation.
>
> This testing logic is easy to adapt to other network drivers as the only
> remaining requirement is that there is some way to send a custom
> Ethernet packet through it that triggers the XDP & TC programs.
>
> The Ethernet header of that custom packet is all-zero, because it is not
> required to be valid for the test to work. The zero ethertype also helps
> to filter out packets that are not related to the test and would
> otherwise interfere with it.
>
> The payload of the Ethernet packet is used as the test data that is
> expected to be passed as metadata from the XDP to the TC program and
> written to the map. It has a fixed size of 32 bytes which is a
> reasonable size that should be supported by both drivers. Additional
> packet headers are not necessary for the test and were therefore skipped
> to keep the testing code short.
>
> This new testing methodology no longer requires the veth interfaces to
> have IP addresses assigned, therefore these were removed.
>
> Signed-off-by: Marcus Wichelmann <marcus.wichelmann@hetzner-cloud.de>
Reviewed-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2025-02-27 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 14:23 [PATCH bpf-next v4 0/6] XDP metadata support for tun driver Marcus Wichelmann
2025-02-27 14:23 ` [PATCH bpf-next v4 1/6] net: tun: enable XDP metadata support Marcus Wichelmann
2025-02-27 14:23 ` [PATCH bpf-next v4 2/6] net: tun: enable transfer of XDP metadata to skb Marcus Wichelmann
2025-02-28 19:49 ` Martin KaFai Lau
2025-03-03 16:13 ` Marcus Wichelmann
2025-03-03 19:28 ` Martin KaFai Lau
2025-02-27 14:23 ` [PATCH bpf-next v4 3/6] selftests/bpf: move open_tuntap to network helpers Marcus Wichelmann
2025-02-27 14:23 ` [PATCH bpf-next v4 4/6] selftests/bpf: refactor xdp_context_functional test and bpf program Marcus Wichelmann
2025-02-27 15:58 ` Willem de Bruijn [this message]
2025-02-27 14:23 ` [PATCH bpf-next v4 5/6] selftests/bpf: add test for XDP metadata support in tun driver Marcus Wichelmann
2025-02-27 22:26 ` Stanislav Fomichev
2025-02-27 14:23 ` [PATCH bpf-next v4 6/6] selftests/bpf: fix file descriptor assertion in open_tuntap helper Marcus Wichelmann
2025-02-28 5:43 ` [PATCH bpf-next v4 0/6] XDP metadata support for tun driver Lei Yang
2025-02-28 15:55 ` Marcus Wichelmann
2025-02-28 16:08 ` Marcus Wichelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67c08b96d1f88_37f929294af@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcus.wichelmann@hetzner-cloud.de \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®