mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Kevin Krakauer <krakauer@google.com>,
	 netdev@vger.kernel.org,  linux-kselftest@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Paolo Abeni <pabeni@redhat.com>,
	 Simon Horman <horms@kernel.org>,  Shuah Khan <shuah@kernel.org>,
	 linux-kernel@vger.kernel.org,
	 Kevin Krakauer <krakauer@google.com>
Subject: Re: [PATCH v2 3/3] selftests/net: deflake GRO tests
Date: Thu, 27 Feb 2025 11:14:13 -0500	[thread overview]
Message-ID: <67c08f55b0ae7_37f929294b0@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20250226192725.621969-4-krakauer@google.com>

Kevin Krakauer wrote:
> GRO tests are timing dependent and can easily flake. This is partially
> mitigated in gro.sh by giving each subtest 3 chances to pass. However,
> this still flakes on some machines. Reduce the flakiness by:
> 
> - Bumping retries to 6.
> - Setting napi_defer_hard_irqs to 1 to reduce the chance that GRO is
>   flushed prematurely. This also lets us reduce the gro_flush_timeout
>   from 1ms to 100us.
> 
> Tested: Ran `gro.sh -t large` 1000 times. There were no failures with
> this change. Ran inside strace to increase flakiness.
> 
> Signed-off-by: Kevin Krakauer <krakauer@google.com>

Nice! Thanks

Reviewed-by: Willem de Bruijn <willemb@google.com>

> ---
>  tools/testing/selftests/net/gro.sh        | 4 ++--
>  tools/testing/selftests/net/setup_veth.sh | 3 ++-
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/net/gro.sh b/tools/testing/selftests/net/gro.sh
> index aabd6e5480b8..9e3f186bc2a1 100755
> --- a/tools/testing/selftests/net/gro.sh
> +++ b/tools/testing/selftests/net/gro.sh
> @@ -18,10 +18,10 @@ run_test() {
>    "--smac" "${CLIENT_MAC}" "--test" "${test}" "--verbose" )
>  
>    setup_ns
> -  # Each test is run 3 times to deflake, because given the receive timing,
> +  # Each test is run 6 times to deflake, because given the receive timing,

Only if respinning: this was always imprecise: it is run up to X times. But
exits immediately on success.

  reply	other threads:[~2025-02-27 16:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 19:27 [PATCH v2 0/3] selftests/net: deflake GRO tests and fix return value and output Kevin Krakauer
2025-02-26 19:27 ` [PATCH v2 1/3] selftests/net: have `gro.sh -t` return a correct exit code Kevin Krakauer
2025-02-27 16:20   ` Willem de Bruijn
2025-02-27 21:25     ` Kevin Krakauer
2025-02-27 21:31       ` Willem de Bruijn
2025-02-26 19:27 ` [PATCH v2 2/3] selftests/net: only print passing message in GRO tests when tests pass Kevin Krakauer
2025-02-27 16:20   ` Willem de Bruijn
2025-02-26 19:27 ` [PATCH v2 3/3] selftests/net: deflake GRO tests Kevin Krakauer
2025-02-27 16:14   ` Willem de Bruijn [this message]
2025-02-27 16:36 ` [PATCH v2 0/3] selftests/net: deflake GRO tests and fix return value and output Willem de Bruijn
2025-02-28  2:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67c08f55b0ae7_37f929294b0@willemb.c.googlers.com.notmuch \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=krakauer@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®