mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chintan Vankar <c-vankar@ti.com>
To: Julien Panis <jpanis@baylibre.com>, Arnd Bergmann <arnd@arndb.de>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Andrew Lunn <andrew@lunn.ch>, Roger Quadros <rogerq@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>, <s-vadapalli@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v8 0/2] Enable RX HW timestamp for PTP packets using CPTS FIFO
Date: Mon, 22 Apr 2024 17:09:41 +0530	[thread overview]
Message-ID: <67c7f423-18ce-4804-8be9-cc4521733cd2@ti.com> (raw)
In-Reply-To: <20240419082626.57225-1-c-vankar@ti.com>



On 19/04/24 13:56, Chintan Vankar wrote:
> The CPSW offers two mechanisms for communicating packet ingress timestamp
> information to the host.
> 
> The first mechanism is via the CPTS Event FIFO which records timestamp
> when triggered by certain events. One such event is the reception of an
> Ethernet packet with a specified EtherType field. This is used to capture
> ingress timestamps for PTP packets. With this mechanism the host must
> read the timestamp (from the CPTS FIFO) separately from the packet payload
> which is delivered via DMA.
> 
> In the second mechanism of timestamping, CPSW driver enables hardware
> timestamping for all received packets by setting the TSTAMP_EN bit in
> CPTS_CONTROL register, which directs the CPTS module to timestamp all
> received packets, followed by passing timestamp via DMA descriptors.
> This mechanism is responsible for triggering errata i2401:
> "CPSW: Host Timestamps Cause CPSW Port to Lock up."
> 
> The errata affects all K3 SoCs. Link to errata for AM64x:
> https://www.ti.com/lit/er/sprz457h/sprz457h.pdf
> 
> As a workaround we can use first mechanism to timestamp received
> packets.
> 
> Series is based on linux-next tagged next-20240419.
> 
> Link to v7:
> https://lore.kernel.org/r/20240417120913.3811519-1-c-vankar@ti.com/
> 
> Changes from v7 to v8:
> - Removed empty lines between trailers in [PATCH v7 2/2] as suggested
>    by Jakub.
> 

Is it possible to merge this series if no further comment ?

> Chintan Vankar (2):
>    net: ethernet: ti: am65-cpts: Enable RX HW timestamp for PTP packets
>      using CPTS FIFO
>    net: ethernet: ti: am65-cpsw/ethtool: Enable RX HW timestamp only for
>      PTP packets
> 
>   drivers/net/ethernet/ti/am65-cpsw-ethtool.c |  13 ++-
>   drivers/net/ethernet/ti/am65-cpsw-nuss.c    |  51 +++++-----
>   drivers/net/ethernet/ti/am65-cpts.c         | 107 ++++++++++++++------
>   drivers/net/ethernet/ti/am65-cpts.h         |  11 +-
>   4 files changed, 118 insertions(+), 64 deletions(-)
> 

  parent reply	other threads:[~2024-04-22 11:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19  8:26 Chintan Vankar
2024-04-19  8:26 ` [PATCH net-next v8 1/2] net: ethernet: ti: am65-cpts: " Chintan Vankar
2024-04-19  8:26 ` [PATCH net-next v8 2/2] net: ethernet: ti: am65-cpsw/ethtool: Enable RX HW timestamp only for PTP packets Chintan Vankar
2024-04-22 11:39 ` Chintan Vankar [this message]
2024-04-22 18:44   ` [PATCH net-next v8 0/2] Enable RX HW timestamp for PTP packets using CPTS FIFO Jakub Kicinski
2024-04-23 10:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67c7f423-18ce-4804-8be9-cc4521733cd2@ti.com \
    --to=c-vankar@ti.com \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=dan.carpenter@linaro.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=jpanis@baylibre.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®