From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EF8E395D87 for ; Mon, 30 Mar 2026 20:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774902458; cv=none; b=oWNhQtS5h4hUcoJIIvMD+8qlH9sTe1NANwv+edMjP3UpjuO72uKu0YsgzoryrnrRcxohz27v4gwU7cgGubdt1bLeLhY23zfdpT6jeaebJzrYkbDoSYFE2auJ4mptbCUFHUsvxwUdCDfbTsvnLo4hUFeZ9tZG2pGmYjha7Dz56Ys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774902458; c=relaxed/simple; bh=XVd4Tu5zgwr/8hebhHmeN+IF8tn0T9cQG8Ak92ZG+g8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FmiO0r7OKoRMKgcEvvdp83B2sC3Rx02iao6V3fJ43O2Un9RpCz7KBTxg7/SJ8NWddFmEQeHm6CEJ1Q9ydsVBFryp8TBsniOAcHzdpfhtSFdyocpCfz3Nbn7r3UybKaLM2H7wosxPNy2Xd8sN2LN8SeoKSzG9iAHxJTTpUruu4n8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eXvOf1TI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q33THhyG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eXvOf1TI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q33THhyG" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UF2iwi3539591 for ; Mon, 30 Mar 2026 20:27:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EzrJyb1gVN/4tm0vA1K96mY4OKgfW/vr9tGl8NUqDQI=; b=eXvOf1TI6dbzFYA7 YvK2ZIq5YV0inm+hOZ0OjAyLbPu6mPpzwqro5GloE+xCQGJtfWn8pB3B1NXHFLbA OQJVVF8zIKl1k3/MAmHSulaBXMeMyPVMW4mp0psAEPkHjpHLl398mK+xxzFBdi18 8113PMT2N7PtZXjPDVVksytgroqYpl1Xh/2Gt/CCxaIymz/y73ymn5lC3WZXT7eO n3pS+6F6wF5r+Uiiefzmo4t9mvTQNYqhtxCMcHSfz6KugKzwxN+KVZetb+IO7rns ZqZKnVz11vNkGnFU7DQ8ZQVcbaYjVp+5/zIKjDSMuLWf1JTaawQXi2Bht4CBn0tt E4HbdQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7q59tdcc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 20:27:35 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2adef9d486bso91771175ad.2 for ; Mon, 30 Mar 2026 13:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774902455; x=1775507255; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EzrJyb1gVN/4tm0vA1K96mY4OKgfW/vr9tGl8NUqDQI=; b=Q33THhyGlfTpTIazHfmbzfecMgSlLFWdeE/D0JKspaMpvcmTaeXIccI2iI4YOi7Ijh P2BdB5tP1yrh1lfLIWySiyoZswNuoEJRqMQSERkDGbFkoHZY+oshGOfGrKmrQpWseVD8 g69Uon9YhVHbpeeUecpTJ557HiSPg4+ssHUitOylwMmU8MrjjkF4CNvcq0vKlehrJh/c 46S+dVfYfc6MGZN2wH0a8XEvUs2yX8Nhz5Px5nK3KclOtW8Xo0P7bMNWKVCiBa5kDCor Zli5dwrmELbnA05JJBPWpVW14Mrj7BNPe9nfRDN2JOqKROX87XUREE6KnmBP0slm3aLk T/ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774902455; x=1775507255; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EzrJyb1gVN/4tm0vA1K96mY4OKgfW/vr9tGl8NUqDQI=; b=gZqfprU6c8oM/UNAFw1+q5q+cz3Re0e7uLUVq6s+kLcnrJuz/effAboN7qKV9iX2DC SAl806VmbUuNKnlhMZn/hN0SmeBRrnvrOBO7qaDv80L/3bUN7KTjw3DGlKBr0FwG/ze+ 6n5XuLa14crwo7cDpSpyCFToEtjiLU7+boER4zpazZ26tM16ck9SP7dkDPiNlD3wiabn Hjk47I1buBnC5aeoSpRQaXu8at3sA63I5bOROLqYbrDjVaxiO9ut/E1Jydw6nHVzqYRR ikPVtvvIcC+ph+YTKah71lMF4QCq5o5gzKNmFXTTyuplR/bDaMQXGP64i5GSS5xXUCx7 6JtA== X-Forwarded-Encrypted: i=1; AJvYcCXoEUm0yWtd0SKDlBgOvbbcLDJ8TLgpzqd9D8HOnZ4IqzGwAXRwKh4zEcWzE1MLkof2AcojAjfi73YyWm8=@vger.kernel.org X-Gm-Message-State: AOJu0YxXotcXhrhQLMO3kp5h4Dye0698xZXRRsuny/aLg/jsp1bYk/pW 4zuC1fG3XEvCUF3xcACv+FfGIMFQv1sImQCkRjiUJqjjSHukWHn1Ui/49DySRSSekmDoVoH0j3I D/6CIib6yIm8uFOH7Re+6kRMPCe8ZS++oyYHEZaXiVpHiRJUs3ArtX0i42SvpHcPKNZ8= X-Gm-Gg: ATEYQzytftyzgrHqQueSVc8YhshKe+SS1/ZJGomA6TTJStZ3KG5lqBIV6GoZRbSp3KF 1iHGkLvqg1P5z4YEWUj5am00hyQ/XEX8RIaaZt/nGuxjbQm+ZHwDLhQqc1hmhAYclFIpS5MOdHA lBKhRzpUBQLqo9lKoLFEXONZmDfbvMXt7pdkrDsZYGeerabKxpBLsHCBI3xtZ2J3MijUSgiP3Tc wTjznhn0k6KOcNuDDQkGHTSp9nbDNRggN897ppTfdMwebZ6DoxPhSPaT4YkHRvbfVizKsYm2uZF nBa/J/bjPPqiyXz7Id/isLjdUhqvZIl98s8mA10UU9HDVeF/tzOHXIQKwrEYW/KYqSNpBmCPtMS SyUX5AE+FEPT4iOtRWqLcYO1jb3dsnezRzeeoqBmgBjM8 X-Received: by 2002:a17:902:ef0c:b0:2b2:5637:149f with SMTP id d9443c01a7336-2b2563717b6mr43048765ad.23.1774902454925; Mon, 30 Mar 2026 13:27:34 -0700 (PDT) X-Received: by 2002:a17:902:ef0c:b0:2b2:5637:149f with SMTP id d9443c01a7336-2b2563717b6mr43048495ad.23.1774902454453; Mon, 30 Mar 2026 13:27:34 -0700 (PDT) Received: from [10.91.121.222] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24266e487sm88192835ad.24.2026.03.30.13.27.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 13:27:34 -0700 (PDT) Message-ID: <67cca0c6-669c-4dcf-be3f-76fc46d1e59f@oss.qualcomm.com> Date: Tue, 31 Mar 2026 01:57:26 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/17] drm/msm/a6xx: Update HFI definitions To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> <20260327-a8xx-gpu-batch2-v2-10-2b53c38d2101@oss.qualcomm.com> <3465929e-262f-407e-bc3d-7564787bce3d@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <3465929e-262f-407e-bc3d-7564787bce3d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 5mcnix0Js6fYEnGIrE61mFVnHi9qEKlT X-Proofpoint-GUID: 5mcnix0Js6fYEnGIrE61mFVnHi9qEKlT X-Authority-Analysis: v=2.4 cv=EcXFgfmC c=1 sm=1 tr=0 ts=69cadcb7 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=IYtLGEtn8_M1e06QnFgA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDE3MiBTYWx0ZWRfX7SYtOxSr3kFH ULC1l4/1gQoBt25H+c0S6rjiQOQUEc3Ml4k1/u2uUcF1i2GMcg/o2Wd4OaU1ifI7zA42/MNB6Zg GrgQJ2m8fBDB87jLHwC4YT6mblF7EteMFIjHA3W2Cr1DpFWQ8qyV5aJVIXIFw6yogw08CCeEoE7 SzJNJ1lwPdv9Yyv1txcVKSmU+llVp0arPy01jSgj/ve0xyO4aGCU6dHuqOEkeqI2qS6v4zthJLI oUNDBwHctOrI0BjJHDDdkTCL7kS2iLoKRLiXOa3G1GZwYvDFlGsTHNZOyMoquSEZ8OQtlDoo6CH ggx3QQD+PHfM2/sOLZ5XqV3w+ikS+UHjIwn0jq8nr2ZKkNvpIqBFcY61STAuYMT1OtIGa3PHxLp nX3BM4rkcyb0R2CiwWpT8a6u1WdqzPACIU6tiZp+0cEWjhbRmgINuSkBWLR0HhIVx75wugeFrfm UtCOfdyeq+LZh5OQoFg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-30_01,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300172 On 3/30/2026 4:45 PM, Konrad Dybcio wrote: > On 3/27/26 1:13 AM, Akhil P Oommen wrote: >> Update the HFI definitions to support additional GMU based power >> features. >> >> Signed-off-by: Akhil P Oommen >> --- > > Whether you want to proceed with bitfields or not: > > Reviewed-by: Konrad Dybcio Thanks. I still feel it is bitfield layout is a 'bit' complicated. I did an experiment: #include #include #include struct packed_u8 { uint16_t mitigation_time; uint8_t current_rating : 6; uint8_t num_phases : 6; uint8_t path_notification : 1; uint8_t extra_features : 3; } __packed; void main() { struct packed_u8 data = { .mitigation_time = 0xffff, .current_rating = 0x3f, /* all 6 bits set */ .num_phases = 0x3f, .path_notification = 1, .extra_features = 0x7, }; printf("Akhil 0x%x\n", *((uint32_t *) &data)); } The output I got in Kaanapali is: Akhil 0x7f3fffff This means that the compiler inserted a padding between current_rating and num_phases. -Akhil. > > Konrad